Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1569285pxy; Mon, 2 Aug 2021 05:13:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzVH5OCtcZ4E1+MUijHYDiIZUiAsWct2p59yw2HbkeIrxJ0K2QzUEltMVRIhF2+fMmnxgU X-Received: by 2002:a05:6e02:1aa2:: with SMTP id l2mr2094531ilv.224.1627906407769; Mon, 02 Aug 2021 05:13:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627906407; cv=none; d=google.com; s=arc-20160816; b=HY6HdfdVHcxv/RQzdCM6SzSRf4pZrgwBR8/45k+jR/PMDMVFi20FmPpVp9eucsuP/E 0vjvFjf28ZP5dCFQK3w7U05eWEYF15piYH4S0ySEMRMESjrVFFmW7Ge2aHQwFvTr4Ypd vkro8LVJG1k7xolWJCTeK/z+FUJ1bcA8d28xJYw6fH2goJFn0fDFtPR0/bm2XjXZqVxU Ejv7tEZ5VQxiKLCrA3P43OAo2A3VjUB77G+QdiptF+F2+HZcoMkbv97oRCZvxqC5JS74 8M9CCjyh3wu8UG+IytsBYOt8FZhrx36GtLXwYtDJtnF4o9dJbf9gQkpuo49fmMwvyR+W SSPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yhCy+jdg2z+Eckz1yvxcPdL/SuIBQamgSG0Pchby1eE=; b=L46KFNu8d/INZP6XLqydwTDHtiZJXjiZjMtWgkK2E85gA9SrS4BCKTDF1eFq96ySBO zZHSxmMzWwhDpANygebcoYFjZ9brl1+LH+QCpz9KbpL/8zX8HdUK9ZYk3gERLHDYq+Qc Z36+0E9+0Al7fPMOsnHINiQk+b9z7kLYdUC1gPmAUnk1WshdorJlARv57W3u82iYGgRe KfSYG5Pb4G1VT9BwcZW/CZLHwNTEBahv8pZktV3x592WKfsOTEAhr9IZBPjVsshxC48T UUmUtIM2KH0boUulKei7Lj3Fu2xanUMUlGpbHyfPWTQWH4oU02Rt3i7tu004vRciIlEU lS9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IHFEat4k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g13si13598019ilf.35.2021.08.02.05.13.16; Mon, 02 Aug 2021 05:13:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IHFEat4k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233558AbhHBMMj (ORCPT + 99 others); Mon, 2 Aug 2021 08:12:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233516AbhHBMMi (ORCPT ); Mon, 2 Aug 2021 08:12:38 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB2CBC06175F for ; Mon, 2 Aug 2021 05:12:28 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id g23-20020a17090a5797b02901765d605e14so24339804pji.5 for ; Mon, 02 Aug 2021 05:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yhCy+jdg2z+Eckz1yvxcPdL/SuIBQamgSG0Pchby1eE=; b=IHFEat4kyp7BJrcnOYKhWyx2BgxojQqKz+Q69zBBnJ9SF6H/hSn+HkbWOVx8/ye6ir b/2N1/CLAwC6wSGNYMbfA6QLp/HMduvyqpQv0/r+QOCJNRawHSLCsegT5OYBch2dGAZt vFsHXxQKt0chTg+3kP4mAeEs6RBwjb0C5OEag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yhCy+jdg2z+Eckz1yvxcPdL/SuIBQamgSG0Pchby1eE=; b=gHsAZuutRatksGJo9BiX9dnUIjPPMZg7BxckQhynXdZOKqG+foumquSlTaVLcGihpn Yzy9dcUD670ygIbNZUIo1IXAFyAG5FHCiqKy97KIDorTpEu8iOIBcOjIjjyxsK/2Iv6f P9RGCgYRCdczzNGlWu8Nhvvsku1wNqXHsTvaLgZbeB0tRF3tyeD+atUn2lxaXq71bQOA n2FqIlN8sETRXgyOKgDUSkUk/NNdVPVQNYFpEAZLmAC4d6K56M3+8MochPQ8VuUKszJ5 7nx6GKAChfILP02S4XL7qXq5TwPG6t3qf0XirENOizIwJX5kdJg8aIzhBmkKVE1zt7TA wUAw== X-Gm-Message-State: AOAM5308RLmDGPCeLsyNNxc9K5OxZ7VWY+j8o1UgljojlNRHVvyNf93m nQG4E48OUMJgqXlGN+xkdpGVnkJor8eTsQ== X-Received: by 2002:a17:90a:de18:: with SMTP id m24mr16795133pjv.78.1627906348032; Mon, 02 Aug 2021 05:12:28 -0700 (PDT) Received: from localhost ([2401:fa00:9:14:cd34:e942:c094:baef]) by smtp.gmail.com with UTF8SMTPSA id w134sm11685775pfd.124.2021.08.02.05.12.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Aug 2021 05:12:27 -0700 (PDT) From: Eizan Miyamoto To: linux-kernel@vger.kernel.org Cc: wenst@chromium.org, houlong.wei@mediatek.com, yong.wu@mediatek.com, enric.balletbo@collabora.com, devicetree@vger.kernel.org, chunkuang.hu@kernel.org, Eizan Miyamoto , Andrew-CT Chen , Matthias Brugger , Mauro Carvalho Chehab , Minghsiu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH v6 0/9] Refactor MTK MDP driver into core/components Date: Mon, 2 Aug 2021 22:12:06 +1000 Message-Id: <20210802121215.703023-1-eizan@chromium.org> X-Mailer: git-send-email 2.32.0.554.ge1b32706d8-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an update to https://patchwork.kernel.org/project/linux-mediatek/list/?series=283075 To address some comments and fixes. This series has been verified to work on 5.13. Changes in v6: - Don't propagate errors from clock_on/off as an afterthought. - Split apart modifying mdp driver to be loadable from mmsys from actually loading it from mmsys into two changs to make review easier. - Update devicetree bindings to reflect no longer needing the mediatek,vpu property in the mdp_rdma0 device node. - Some stylistic cleanups. Changes in v5: - rebase and test on 5.13-next @ e2f74b13dbe6 Changes in v4: - rebase and test on 5.13 - don't depend on https://patchwork.kernel.org/project/linux-mediatek/list/?series=464873 Changes in v3: - get mdp master from aliases instead of strcmp against of_node->name Changes in v2: - rebased onto Linux 5.12 - 100 char line length allowance was utilized in a few places - Removal of a redundant dev_err() print at the end of mtk_mdp_comp_init() - Instead of printing errors and ignoring them, I've added a patch to correctly propagate them. - Use of C style comments. - Three additional patches were added to eliminate dependency on the mediatek,vpu property inside the mdp_rdma0 device node. Eizan Miyamoto (9): mtk-mdp: propagate errors from clock_on mtk-mdp: add driver to probe mdp components mtk-mdp: use pm_runtime in MDP component driver media: mtk-mdp: don't pm_run_time_get/put for master comp in clock_on mtk-mdp: make mdp driver to be loadable by platform_device_register*() soc: mediatek: mmsys: instantiate mdp virtual device from mmsys media: mtk-mdp: use mdp-rdma0 alias to point to MDP master dts: mtk-mdp: remove mediatek,vpu property from primary MDP device dt-bindings: mediatek: remove vpu requirement from mtk-mdp .../bindings/media/mediatek-mdp.txt | 3 - arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 - drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 268 +++++++++++++++-- drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 34 +-- drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 282 ++++++++++++------ drivers/media/platform/mtk-mdp/mtk_mdp_core.h | 3 + drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 4 +- drivers/soc/mediatek/mtk-mmsys.c | 20 +- 8 files changed, 470 insertions(+), 145 deletions(-) -- 2.32.0.554.ge1b32706d8-goog