Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1572275pxy;
        Mon, 2 Aug 2021 05:17:26 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwyWw8sD0j4eQx3yCqIDoxcv8AF66ttmOyxFU53zNGTjVOhhQ+c4y2VA1F3cOL6jpDoZAcT
X-Received: by 2002:a17:906:2813:: with SMTP id r19mr14988589ejc.150.1627906646674;
        Mon, 02 Aug 2021 05:17:26 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1627906646; cv=none;
        d=google.com; s=arc-20160816;
        b=lEqCBqzmzPyl9DziWDRo10qyikKkb12zvJc3EntDvVdQSibK9KP7MUKUOk/HxNB5Pz
         zD8MXCEg3TF/S3oXMZKNHiChrhnrM4tVxD8Kn70SIYCv8VSmkVeWgd/wVYEGtrZlek/i
         zCQZLbdkN8aSqy+YJdRAa6kYnhdSJHp7HyRtJYIX2P3zd/iN1G8r1STVruSzHwZDxcrf
         nk56kI2XC3EXiAHY4OYhAcfnFXGs3r900mfKdRUwt5UKRR/x8QbFOzHX8zpDN9ecVHkB
         mRjg0DPQS/+mwVBnzeTJRS1NlIwVFuRLwuUMaYn3EcVI7sfCl0N7yZf5n/RBn7+00m9+
         mgjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:mail-followup-to:message-id:subject:cc:to:from:date;
        bh=QhFQre90IGlYitAvW60quKg//tCSbgsUFxoDHo/IKfw=;
        b=CW9t4p8jWZxDoYJiEsZ+AENqtDdAhZzMJVcZaZwZcRFO/6346yxAaVn4JqF+RHdOhf
         9vl6yn3UvWtB8ziXL12eD/miaJOR3BIJOtK4TBwsjkSqwsX1LHJMGOjLf540kRiNCoVE
         YKIEjH48rohxlqkGtWoBeN0+JXERv+FmQ6MRncbwjG9eCqu2BGNKNdpF+Ki9xXQQFm8b
         19nbANHB3QaphNKier8MmNLi8CkiMTBsF8z7+p49gCHrIgFiK0kkabjxPg6uYU+KEPdX
         tCDHEla1d3sFHKGHPGsWLPRtUkKJPEHAX5yAc234s1WxRaF6SQw+gCzO9+fPcnnBlvcP
         2jXw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id dn7si9588220edb.408.2021.08.02.05.17.01;
        Mon, 02 Aug 2021 05:17:26 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233558AbhHBMPz (ORCPT <rfc822;linux.whf@gmail.com> + 99 others);
        Mon, 2 Aug 2021 08:15:55 -0400
Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:55492 "EHLO
        out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S233498AbhHBMPy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Aug 2021 08:15:54 -0400
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R571e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0UhmnTvb_1627906541;
Received: from B-P7TQMD6M-0146.local(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0UhmnTvb_1627906541)
          by smtp.aliyun-inc.com(127.0.0.1);
          Mon, 02 Aug 2021 20:15:42 +0800
Date:   Mon, 2 Aug 2021 20:15:41 +0800
From:   Gao Xiang <hsiangkao@linux.alibaba.com>
To:     Andreas Gruenbacher <agruenba@redhat.com>,
        "Darrick J . Wong" <djwong@kernel.org>
Cc:     linux-erofs@lists.ozlabs.org,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Huang Jianan <huangjianan@oppo.com>,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        Christoph Hellwig <hch@lst.de>,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v9] iomap: Support file tail packing
Message-ID: <YQfh7V0lvLNx0QlR@B-P7TQMD6M-0146.local>
Mail-Followup-To: Andreas Gruenbacher <agruenba@redhat.com>,
        "Darrick J . Wong" <djwong@kernel.org>,
        linux-erofs@lists.ozlabs.org,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Huang Jianan <huangjianan@oppo.com>,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        Christoph Hellwig <hch@lst.de>,
        Matthew Wilcox <willy@infradead.org>
References: <20210727025956.80684-1-hsiangkao@linux.alibaba.com>
 <CAHc6FU5x3XOTyu8vooReSZ-hacfTdo3cu7wFJRcQrfTH8NkVeg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAHc6FU5x3XOTyu8vooReSZ-hacfTdo3cu7wFJRcQrfTH8NkVeg@mail.gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andreas,

On Sun, Aug 01, 2021 at 02:03:33PM +0200, Andreas Gruenbacher wrote:
> On Tue, Jul 27, 2021 at 5:00 AM Gao Xiang <hsiangkao@linux.alibaba.com> wrote:

...

> > +static int iomap_write_begin_inline(struct inode *inode,
> > +               struct page *page, struct iomap *srcmap)
> > +{
> > +       /* needs more work for the tailpacking case, disable for now */
> 
> Nit: the comma should be a semicolon or period here.

Sorry for some delay (busy in other things...)

Yeah, that's fine to me, in English contexts it'd be better like that
(there is some punctuation rule difference between languages.)


Hi Darrick,
Should I resend v10 for this punctuation change or could you kindly
help revise this?

(btw, would you mind set up a for-next iomap branch so I could rebase
 other EROFS patches on iomap for-next, thank you very much!)

Thanks,
Gao Xiang