Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1573375pxy; Mon, 2 Aug 2021 05:19:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoGFg5zo+hUcIX59qZ0QY+DC+pn2CD51VlNT+4a4WjZ5YpwCdS87cEHGWZHIBPpvGPMuNI X-Received: by 2002:a05:6402:1cb9:: with SMTP id cz25mr18761626edb.81.1627906742902; Mon, 02 Aug 2021 05:19:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627906742; cv=none; d=google.com; s=arc-20160816; b=yS8TxAxo49rwKZUnHNqEGEJifXlj4V/rNbVov5F8Qeb6O9eTqkkIqKu1vKfsiwwxdU L9XWX8rBj/Sx0JRUeO2WdtDmx7MjfC+aeL/ADIAPnVfRVZVuJJ0lSJqL4zGPlB8ssmw1 BJdxKiXIGaluuEAQEydaPFEwPd1tTqLLKyI/47yUZzlMeSH1hLCrllsIKBCnZlbAe19B Z59+DuALIa6Q8M3QJaK5v0RoLKCY97DfGqEzO1rUlGoT/6lRRcjAgkuxRMNzUNtoj9Tc zrF8OSXs5GEdjkf4b1qz5FsuEigU6zFQn9PlmxeMOW2IeHK0X2T5hZ6ciw8NTUA7nSI3 ov7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0zu21kiNvImId2TwNkUErMIavgZTTIniT9piGF6zj0c=; b=eKeI6p2qJrW/YtCiTMYADekntkcXpZscG80c38ul1/tE1LAVOAM1WmfUa6m8Wbstzs quS5McBWC+ZVm/aUqmbVyTl7QHk7G5vdizTw5pa8vLYlf0j0//J0xobaPfcdJUnFCgFq kg+PeaixoJgwd4X8Mzctloqsi4f/wOW5EBoxCs7iexDh4DT7Ql06tF8OUOc1WoYV6sSu 8ERP/s20ppvFgExyojZAK+5Lq8QjfBtZv8maDFui5VMyzHMafJYsEqqcjyVKKsLjU0ud UolIiIjybwLiGXU9TyBpaG9VK/FcBhKFRYBQ4B277MMn1dIV094aiKNQ30yNYqjJOTP2 EEIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id la14si9641445ejc.142.2021.08.02.05.18.38; Mon, 02 Aug 2021 05:19:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233604AbhHBMRZ (ORCPT + 99 others); Mon, 2 Aug 2021 08:17:25 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:19886 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233498AbhHBMRY (ORCPT ); Mon, 2 Aug 2021 08:17:24 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.17]) by rmmx-syy-dmz-app09-12009 (RichMail) with SMTP id 2ee96107e23dbe9-e8925; Mon, 02 Aug 2021 20:17:03 +0800 (CST) X-RM-TRANSID: 2ee96107e23dbe9-e8925 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr09-12009 (RichMail) with SMTP id 2ee96107e23c18d-e74d0; Mon, 02 Aug 2021 20:17:02 +0800 (CST) X-RM-TRANSID: 2ee96107e23c18d-e74d0 From: Tang Bin To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] input: cpcap-pwrbutton: Add an error handling Date: Mon, 2 Aug 2021 20:17:40 +0800 Message-Id: <20210802121740.8700-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function cpcap_power_button_probe() does not perform sufficient error checking after executing platform_get_irq(), thus fix it. Signed-off-by: Tang Bin --- drivers/input/misc/cpcap-pwrbutton.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c index 0abef6321..0a1f2e8b4 100644 --- a/drivers/input/misc/cpcap-pwrbutton.c +++ b/drivers/input/misc/cpcap-pwrbutton.c @@ -57,6 +57,9 @@ static int cpcap_power_button_probe(struct platform_device *pdev) int irq = platform_get_irq(pdev, 0); int err; + if (irq < 0) + return irq; + button = devm_kmalloc(&pdev->dev, sizeof(*button), GFP_KERNEL); if (!button) return -ENOMEM; -- 2.20.1.windows.1