Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Aug 2021 14:59:40 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Aswath Govindraju <a-govindraju@ti.com>
Cc:     linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        Faiz Abbas <faiz_abbas@ti.com>
Subject: Re: [PATCH v2 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN
Message-ID: <20210802125940.w2djzwuwysco566p@pengutronix.de>
References: <20210726101012.26983-1-a-govindraju@ti.com>
 <20210726101012.26983-2-a-govindraju@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xdpgrz6pysvgzjon"
Content-Disposition: inline
In-Reply-To: <20210726101012.26983-2-a-govindraju@ti.com>
Precedence: bulk


--xdpgrz6pysvgzjon
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 26.07.2021 15:40:07, Aswath Govindraju wrote:
> From: Faiz Abbas <faiz_abbas@ti.com>
>=20
> Add Support for two MCAN controllers present on the am65x SOC. Both suppo=
rt
> classic CAN messages as well as CAN-FD.
>=20
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 30 +++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dt=
s/ti/k3-am65-mcu.dtsi
> index c93ff1520a0e..6445f2d976e8 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -159,6 +159,36 @@
>  		};
>  	};
> =20
> +	m_can0: mcan@40528000 {
> +		compatible =3D "bosch,m_can";
> +		reg =3D <0x0 0x40528000 0x0 0x400>,
> +		      <0x0 0x40500000 0x0 0x4400>;
> +		reg-names =3D "m_can", "message_ram";
> +		power-domains =3D <&k3_pds 102 TI_SCI_PD_EXCLUSIVE>;
> +		clocks =3D <&k3_clks 102 0>, <&k3_clks 102 5>;
> +		clock-names =3D "cclk", "hclk";

The binding says the first should be hclk.

|  clock-names:
|    items:
|      - const: hclk
|      - const: cclk

Please also fix in the other dts files.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--xdpgrz6pysvgzjon
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmEH7DoACgkQqclaivrt
76kxjwf9Gmlc6XvgdcEz4U7PNHFbVNMc1088UadMxSH07/kQAaRW90wlWXKlQTG2
tVFCdoj5cPqT4PVeqf1k5F/N/WicVa8SHTKZcpLQz1GZLVbXmVgI6zRKJOHVtGfI
32g9po0Xol0E5kPtMusw954W0elkTGO2CuWkhQ5DwODL3GElegqKfrz3IWueiR7E
Zk8GjJRdmP1BqFiokaT+/TEOSWMrzHNXO2EYahaEO6YEoc7CjA66eP+4tmH560rs
Kgr56k7Rghl5uF843geaZinyWPJLfH04K0yDnaKIltW9aLuavAABcHITJhsNO2fS
fjR/9fVIdGaorFu77/7WjEgeFw/51A==
=O+hV
-----END PGP SIGNATURE-----

--xdpgrz6pysvgzjon--