Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Keller, Jacob E" <jacob.e.keller@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Saleem, Shiraz" <shiraz.saleem@intel.com>,
        "intel-wired-lan-bounces@osuosl.org" 
        <intel-wired-lan-bounces@osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH] ethernet/intel: fix PTP_1588_CLOCK
 dependencies
Thread-Topic: [Intel-wired-lan] [PATCH] ethernet/intel: fix PTP_1588_CLOCK
 dependencies
Thread-Index: AQHXgiMw8RcSz1WqMk2A4/Ocf/AkqqtgOf5A
Date:   Mon, 2 Aug 2021 13:07:10 +0000
Message-ID: <BYAPR11MB336781A3C6B41DFFFD838157FCEF9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20210726084540.3282344-1-arnd@kernel.org>
In-Reply-To: <20210726084540.3282344-1-arnd@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?os+dUpXjdh50yI/JcqS1a+PPzJR5oFW7WvEG2m8ATEpx8r3MsNQ2YfIdTVky?=
 =?us-ascii?Q?EjbHae8EIUiiX2lVIy4tHTzpQtvEnU3yi0OgZ8n6JMzezMgbMNV9Ls8AhxnC?=
 =?us-ascii?Q?fMiAl/nNMftCAy62MLoZqrNICnR+S14ruBLN5qZ4hsPXDLTibey0GibeuFdU?=
 =?us-ascii?Q?Bz+4HxQPVz4gyO7R9n6Mp/fWh8tr5nQ0MPe5BKH0sHkiQf68bU0CEUNs0wdg?=
 =?us-ascii?Q?PeR9osaN3N+ECvwSfvxIj8EZqA8CHiozr7sZCOtK0o0LpAPNe6I4YneApKel?=
 =?us-ascii?Q?VX3tIinpDkKJQ7vu2Bu98pLXZaEWW9kH+32yXWC9EaKMDdd9yfnnNFSH7Axq?=
 =?us-ascii?Q?JzkTEhQHrlsz6qycPrzuKlCzrZ73IiGqIZcXAPdEG3MTgWplS8qv4KVSVO9a?=
 =?us-ascii?Q?Fn73jve7+1kAuCvh7G4ctajSplxdvjWJTHaiSBwuVGizjGNwlaiao+bi2n1S?=
 =?us-ascii?Q?nTUVSl7yF0jHyVFynNKB4IuAnkwFHqC7lnN+Wi82G4DLPViuArY4/vuC+tMA?=
 =?us-ascii?Q?8aJwycc51uPVFn8bH5o7dT9oSGxXqnKc2Oz0SmTtY/r/wkqFK0h7GmObHg7f?=
 =?us-ascii?Q?ozeUT2TPcrk2G3jeYudndogTjTKDwRX/THpzMyCVhIcgwaL2xCOYIGLDnSmz?=
 =?us-ascii?Q?cyFRvzHDJGoaAOED9kovgqpcXCKsZUtLjgaUoItuqCedh67pFeAGNyZk+UDU?=
 =?us-ascii?Q?/t16c3y4tDlJQTMWkNLtxMO7musKKvjh+0JQAeXGpES39b5uaaLyGttGSet+?=
 =?us-ascii?Q?TSzHxCKCqspqXgmanFFXRyF1aorDZ0wnz3FSJBYei7s7pBWtg5hGc9lPzpTR?=
 =?us-ascii?Q?I6h1vjp5LYzpw0xbSOmMIDU9/nkfDPwrcMsNwDjwOteCkDhtWaAjxQshaltd?=
 =?us-ascii?Q?cvmQ9Q2tXHvOxj82JnykgsmId178pI/j9wJ7TiMfg5opPRP8qvZNjLdS7srC?=
 =?us-ascii?Q?JXMs1m2az9B9Ig7XjHu+oid7aW8sQPHvU3+XnFRppWO5xsy5/0jsu4qu3Sut?=
 =?us-ascii?Q?iyd01IOj4MI7CDWIXQGt56cw++GKQCnZjJF4k81MqP1n1M1GivTLWtnYlbrr?=
 =?us-ascii?Q?SmChpnGoTQW8mj1+iTjYiDpdKDQ2BWjsB18y8JYQvn5IjT2pp4UEPWgQSOiZ?=
 =?us-ascii?Q?1hHnHuCIK+h7KEgDM7yLe9QUnZP8iHkLcBWyK4BxGN/Q4zlaC6xTCJSUz92R?=
 =?us-ascii?Q?yS4UZdmSSIh5NMBFBI7mqKrnh6ziAcCQcW9OpmfPRY8dJfvhfUbo0E0jJeI3?=
 =?us-ascii?Q?ut8u/35WoZD6EaO4kxyrM8LwseLiAsXnpRJtbT0H15LBFa+XDaEv8iT7jYHd?=
 =?us-ascii?Q?SE0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bcc53fa-1746-4f1f-cbce-08d955b670a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2021 13:07:10.9725
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7XQl+ZwHCiIJEbKv/g0PSUQN03EwjzpQKKNMEX0tvhO5G2Nz/NOXF8bnzYxT8WKqKY/KSRVcaBDe1o+gYuMiDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5151
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Arnd Bergmann
> Sent: Monday, July 26, 2021 2:15 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Jakub Kicinski <kuba@kernel.org>; Keller, Jacob E
> <jacob.e.keller@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; netdev@vger.kernel.org; Kurt
> Kanzenbach <kurt@linutronix.de>; linux-kernel@vger.kernel.org; intel-
> wired-lan@lists.osuosl.org; Saleem, Shiraz <shiraz.saleem@intel.com>
> Subject: [Intel-wired-lan] [PATCH] ethernet/intel: fix PTP_1588_CLOCK
> dependencies
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The 'imply' keyword does not do what most people think it does, it only
> politely asks Kconfig to turn on another symbol, but does not prevent it =
from
> being disabled manually or built as a loadable module when the user is bu=
ilt-
> in. In the ICE driver, the latter now causes a link failure:
>=20
> aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function
> `ice_eth_ioctl':
> ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'
> ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `ice_ptp_get_ts_config'
> aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to
> `ice_ptp_set_ts_config'
> ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `ice_ptp_set_ts_config'
> aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function
> `ice_prepare_for_reset':
> ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'
> ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26
> against undefined symbol `ice_ptp_release'
> aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function
> `ice_rebuild':
>=20
> For the other Intel network drivers, there is no link error when the driv=
ers
> are built-in and PTP is a loadable module, because linux/ptp_clock_kernel=
.h
> contains an IS_REACHABLE() check, but this just changes the compile-time
> failure to a runtime failure, which is arguably worse.
>=20
> Change all the Intel drivers to use the 'depends on PTP_1588_CLOCK ||
> !PTP_1588_CLOCK' trick to prevent the broken configuration, as we already
> do for several other drivers. To avoid circular dependencies, this also r=
equires
> changing the IGB driver back to using the normal 'depends on I2C' instead=
 of
> 'select I2C'.
>=20
> Fixes: 06c16d89d2cb ("ice: register 1588 PTP clock device object for E810
> devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/intel/Kconfig | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20

Tested-by: Gurucharan  G <Gurucharanx.g@intel.com> (A Contingent Worker at =
Intel)