Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1642016pxy; Mon, 2 Aug 2021 06:55:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMikyRAV+Gtb8Q3B4d48T8/1phO/A6dJr5Kwnoyr6uAj+OPWPvDDMXfIBysf+YjGYw6g2l X-Received: by 2002:a02:90d0:: with SMTP id c16mr14845697jag.106.1627912540576; Mon, 02 Aug 2021 06:55:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627912540; cv=none; d=google.com; s=arc-20160816; b=GqjT2oeet1IYTtoeucS+g3gSpJ3wylRu/2RU2yJVYfSZ1VXW97kqoT8IwcOWRvYNCx UVXc0nAdCzj1Idu/iNPoNuHpgq8KymmT4JN9j3DhL5VzBemYwzGe2oxhFgM1envG1W5+ Vd/ph2OpmCRtezx8mjt1K3mp2Y0buJxMKNeauq1hSnBqxDzWOFk+ItzbWEwcxyHMic3E zCIunoLkNI44zTOVtOlMIpIqNFvYOHylRVDil5mkRdi5/eH2vx2EdYMbxlXBTS4EBXUM Jk0AxiHizgPTu5+Ry4NQcjNSi+s9PWE+2hkk9HcYfTy3VJcZql7etfyM6zYBIJh2Y23m 89Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=B7Lo4q1ZSHHDkABfutJDf4ejpSfsPbvmSZBJdskc81Q=; b=FhpYTeXXXLn0AekHCtrwPnHInk2LI4guDPrDBo4xuhyKN0tDuVlcIdtYQ8pOW8D+d3 Y0Qnrt64rWLCFeUuuH9wpqdCVIGULMfGz7AQL2+vh1/GgTM7hEprEzGZqGEu8YvQaXR/ zT5sVSze1uM5zA+Orp+3agNXlh4fByjvSdRjh7Sn+w/IRXZ2UczQikD9rD7Y2PeGRvkB aEmwzRVttfsdlkBLiMYIYE9X1U0ccYnoGr1ljkrb+/UiXSJb/n6SA/80kYsxLt+Z/fcn kLh19zmPuA1ErRc5Q9o9pCHWh5KA7Xq0xgk2BTXbJfuziJ08um09jSu1FXOT2kyRJc1G FZAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=A84OkxJ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c15si12139533ioa.59.2021.08.02.06.55.29; Mon, 02 Aug 2021 06:55:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=A84OkxJ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235374AbhHBNxF (ORCPT + 99 others); Mon, 2 Aug 2021 09:53:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:60202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234655AbhHBNtA (ORCPT ); Mon, 2 Aug 2021 09:49:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EAA12610A2; Mon, 2 Aug 2021 13:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912130; bh=5sT6IPa0R3i6SC+ECb6Kd3jrWd0vH06MCPYzrXHaFQM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A84OkxJ+WJ2gLOMuXXx2TMw3CoQrvXsWCnlZtASkbFP3zfsp06vue2MAIVBT+XxdO cvLOxJsq9OpzbVCgekjDxi/KJS5F5MxZC8QWAAvMoe+YNK4Ru0vQMG4607wpVaPQfd h28xXfyReqTZG/4d9a4rouvKhTjv9ZrK+sRc+4Ek= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 4.14 29/38] netfilter: nft_nat: allow to specify layer 4 protocol NAT only Date: Mon, 2 Aug 2021 15:44:51 +0200 Message-Id: <20210802134335.744303273@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134334.835358048@linuxfoundation.org> References: <20210802134334.835358048@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pablo Neira Ayuso [ Upstream commit a33f387ecd5aafae514095c2c4a8c24f7aea7e8b ] nft_nat reports a bogus EAFNOSUPPORT if no layer 3 information is specified. Fixes: d07db9884a5f ("netfilter: nf_tables: introduce nft_validate_register_load()") Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nft_nat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netfilter/nft_nat.c b/net/netfilter/nft_nat.c index a18cceecef88..04dd813ed775 100644 --- a/net/netfilter/nft_nat.c +++ b/net/netfilter/nft_nat.c @@ -153,7 +153,9 @@ static int nft_nat_init(const struct nft_ctx *ctx, const struct nft_expr *expr, alen = FIELD_SIZEOF(struct nf_nat_range, min_addr.ip6); break; default: - return -EAFNOSUPPORT; + if (tb[NFTA_NAT_REG_ADDR_MIN]) + return -EAFNOSUPPORT; + break; } priv->family = family; -- 2.30.2