Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1642438pxy; Mon, 2 Aug 2021 06:56:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+V0CAGwNOFunb5qcERVnTT4kGia4sE30Ws1SRxVmkcG9y9CjPnlIeCiEyGGKQ/maNEl/p X-Received: by 2002:a02:cce6:: with SMTP id l6mr15071321jaq.114.1627912578948; Mon, 02 Aug 2021 06:56:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627912578; cv=none; d=google.com; s=arc-20160816; b=TTPuX7516KNwRUEK+HXeKGV6L+5/l/dgOSc4RuN99s/JVT5FmfE0uVlRN1LLZFRW5L 7m0j4U0Z+8Utgs0mAoEuwrkw+UKPRsm0ERPpIllAlRtFS3YQPMKC5L/X0tNBmrWgE8jL uBjEZFNYKAGMh3lmIceOHN+bu4b7bbpwX0/0A2RLZJj6lqEu0JUaseAJn3eJKFOn/bNt Q2pZ+auruwyem6mgpSMh89Vh4dW56KQFQONjiilSYDlMtvO7sB9ffyG/LAPwsN1A4j+3 F+X/V1dLHAdaCalPLcKBLIsJN0FBg+zTRcBW1uQcKFrruaauItDIwddM96KGEjTDsq3F OOjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Fwc4zTRSU2h8rDlqrkkwd6Fm224krYr9e3AlMhtD04k=; b=dRdG4faWChEWk4RQo0uTgix5yyj7p6zZSz9Wp7mB1+ezK4hs+zIZBSJZnYaXKf6Vq6 pejluDf0/Hr4vmgZEoroaQQUNLNn/ukN7XE/VAvhbUWpNd2OX+DhG3i9naOCBGY2Sj0t va28fnljCjv2lMFUUDRL2CJYZ7aImfixOZv8Sw7hhUxe3T6uX9c11LfLgaO11ouDczD+ JfyYWAsCB9UW6uHImiCd915B0wQW/eA/V/dQvO1cgCOSrDXflqiUWKxD7iSRS5cimZpo jUkdyw8/3wVv2PUVDdxZZQj9CuQn3a0Vg3opTE6pT943phMdgFQCVbzlQL0UKs+gfnWN B58Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bvs7o2Rf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w12si12622076ilv.127.2021.08.02.06.56.05; Mon, 02 Aug 2021 06:56:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bvs7o2Rf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236283AbhHBNzM (ORCPT + 99 others); Mon, 2 Aug 2021 09:55:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:58758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234815AbhHBNuL (ORCPT ); Mon, 2 Aug 2021 09:50:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9679E61029; Mon, 2 Aug 2021 13:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912202; bh=scVr84yU6zMraBDp2yvTMR8huTBSWNGSxSxjw70NDn8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bvs7o2Rf3kVl/xSscwj0B59g7faJWM0bXGUi7BNP0t5jmEltQ98UhTioC3PadaG5L 5EKWBf9EIu6p0Q6jnxKdal0vBhnnf+V3fY+O7cfzbMKM7NG6u/ZFfe72WgVAYVekWO 2E3zN+aXbnzmEk0qLbmwIydsIWysrKydX1AAkJaw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ben Hutchings , Marcelo Ricardo Leitner , Xin Long , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 24/30] sctp: fix return value check in __sctp_rcv_asconf_lookup Date: Mon, 2 Aug 2021 15:45:02 +0200 Message-Id: <20210802134334.851870155@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134334.081433902@linuxfoundation.org> References: <20210802134334.081433902@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcelo Ricardo Leitner [ Upstream commit 557fb5862c9272ad9b21407afe1da8acfd9b53eb ] As Ben Hutchings noticed, this check should have been inverted: the call returns true in case of success. Reported-by: Ben Hutchings Fixes: 0c5dc070ff3d ("sctp: validate from_addr_param return") Signed-off-by: Marcelo Ricardo Leitner Reviewed-by: Xin Long Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/sctp/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/input.c b/net/sctp/input.c index 203aaefd8d04..23c4f14bec25 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1132,7 +1132,7 @@ static struct sctp_association *__sctp_rcv_asconf_lookup( if (unlikely(!af)) return NULL; - if (af->from_addr_param(&paddr, param, peer_port, 0)) + if (!af->from_addr_param(&paddr, param, peer_port, 0)) return NULL; return __sctp_lookup_association(net, laddr, &paddr, transportp); -- 2.30.2