Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1648108pxy; Mon, 2 Aug 2021 07:03:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJycGpowKh9ccdCKWzJPWhmHDoBS/Jp9BYdIwbYkwAzhVDz+NVVsGByAowxiU2JtyP1HGiLb X-Received: by 2002:a05:6e02:78a:: with SMTP id q10mr1278137ils.229.1627912997944; Mon, 02 Aug 2021 07:03:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627912997; cv=none; d=google.com; s=arc-20160816; b=EtjxZv474T3QqAdVPA6o07sc4jmSMCOJl/6OAxi2CeUZZyv/O+tE1Xp2zASpw5/L7h Gv2AqTzfec8OAAFLMaCiJH22MCoO/T/d6UpD9ieN9UKFAr3pAEg3AQzUEB4J+/SxXV5z seOJJ9NCEjzTQ8ZQOXr9Kn3ZT2QUlG4hiTkwYNs2JU+2mrZTqF9b7W5WigAHdEcy8Fw6 Jh6e8Jx5p3GjhFv2S07bINDy1c52pKf7nzRIZguO15n6gxwSl+rwJs4PZQC56YA6jWtk GHZyIp66gUsE92zA06ur0kV8WV4TiNUQJ8F6VgeVcXdiTu/agNFvi+1/ndlxQFX2RbZq VLKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=px5qzRMA1Mq+hnzFRpMFHBxI74M1Hm6ZlkBpXSBRNp4=; b=rf6iVTRhYhQXNL1efz2dZA/VSCvTiaatCn0NBaTe0wDXu6YejHFMkPx3IA7BimbHvW qY9PXh/TARaMnJRVGu+rW1/XuFdcUUlzcYYc9SDqH2zXjQdz6qLRwd1gAnfYeRb5mr/T 78wigF8ge3A4A8PZ+rgKC6WvmU4vhzGC8Y3PlmcQ8+uukcsxvi0/MQWZWPaRflnYvjJP CPGOc5Of0SkvTWU/8yJBB6857lBpjeCFwUYr7wOchRlCLtUbliwQ+F0qr0wHGiMiGRG7 7dhFlR7BAQtFIDF8K1WIT0V+cHcwqexayNGzgQcrtsax/6i6N1uN+WmaD5xL4CrZ3kHt A2jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TsiaTsEx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u11si11853540jak.14.2021.08.02.07.03.06; Mon, 02 Aug 2021 07:03:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TsiaTsEx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236429AbhHBOCe (ORCPT + 99 others); Mon, 2 Aug 2021 10:02:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:34138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236007AbhHBNyv (ORCPT ); Mon, 2 Aug 2021 09:54:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5BBF36052B; Mon, 2 Aug 2021 13:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912384; bh=lvIAxlLhGE2iuoi5wxCJ5/WOViEUZ5YmrqZyje3/kNM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TsiaTsEx9Py3lK6KxrLWtrnWTZU5k3A+FqaiIgIUFxOHhnitX+oCOObQFUEj9xZdM vKaMOwzdhfQrAuoiDAsTMzgUHfYcy5hlaWLssNnJd5cJR2RCh/8kqRdI5+g7xzEBzX qq6b2v1CQCLM1ZlpSFlMOsgGEozPQtmV4JSoPRog= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Grzegorz Szczurek , Jedrzej Jagielski , Imam Hassan Reza Biswas , Tony Nguyen , Sasha Levin Subject: [PATCH 5.10 36/67] i40e: Fix log TC creation failure when max num of queues is exceeded Date: Mon, 2 Aug 2021 15:44:59 +0200 Message-Id: <20210802134340.253386501@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134339.023067817@linuxfoundation.org> References: <20210802134339.023067817@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jedrzej Jagielski [ Upstream commit ea52faae1d17cd3048681d86d2e8641f44de484d ] Fix missing failed message if driver does not have enough queues to complete TC command. Without this fix no message is displayed in dmesg. Fixes: a9ce82f744dc ("i40e: Enable 'channel' mode in mqprio for TC configs") Signed-off-by: Grzegorz Szczurek Signed-off-by: Jedrzej Jagielski Tested-by: Imam Hassan Reza Biswas Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index b3a9dec414a5..bc648ce0743c 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -6933,6 +6933,8 @@ static int i40e_validate_mqprio_qopt(struct i40e_vsi *vsi, } if (vsi->num_queue_pairs < (mqprio_qopt->qopt.offset[i] + mqprio_qopt->qopt.count[i])) { + dev_err(&vsi->back->pdev->dev, + "Failed to create traffic channel, insufficient number of queues.\n"); return -EINVAL; } if (sum_max_rate > i40e_get_link_speed(vsi)) { -- 2.30.2