Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1648119pxy; Mon, 2 Aug 2021 07:03:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmF48wZ9ShjF0/wA7ij/6GuZs6FzM5ZhO62TKFoq40yOJ+WWGSFYAX1vTaMCQ9Fzt3f0ds X-Received: by 2002:a05:6638:1915:: with SMTP id p21mr15065678jal.104.1627912998348; Mon, 02 Aug 2021 07:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627912998; cv=none; d=google.com; s=arc-20160816; b=SLQZDj3a2ktk/2ItbFNZs20uFlyrnnbS+2lMldmfhJwEq9u15eMsH1KnWN++JRh960 f72jD83qeWctrGtX6LdJA0mRNLVO8aJOvU/e5aoNqun/zUxyt/lMi6kARb/11r5EZCeA 59VYdODWgAjMBeEWOXDE7if9lDD7GkdVJcCX2GsK4StAcwtE+lYqg7reu5j+WUKaszt0 LEESskwMwlexyITZU2/TP8ySVR68Z5ipo3lrNmkVmkejEcsOLOUi+KapI0GNkMWVnX5D IT9tqYLkgFzhjF+BTWXOblhPKPEKggnMJe6NdBOl9TUCbohMXp7YDGASlC2cHEST+i/b 4J3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q2ar/DBhSBsxDVoZz3Q7WzKb/7VzCeSKgqeJrL3vzxA=; b=h7q8dH+uAMWg2EyrH83YCMn4Tei9h5U8B/Q6YA2mgz13Tx2uwWQkXr7aNllwdGHgBN 7+9MxDxOM+koxZwTMAPLNbaDfn521uURY9kd28Bwyu/UKevcZfevOzkoGyXbU/YFoZ9I nEqF8XXJBZCr6NgpH4hgbCgUyIsqB9gpOhLo7fX7SdXDV4qcl1nHpcTL+c9Vpzw8gmkO s5sl3vilueEdozARqs6zOdoGPCvoG5scWgLpNyfSTXccogMuphOVEqPO3nWeQh6rEP+S Dz9Hex54qfUsmq4wE6LqC1V62PeFQYTWIPR8vbkGF41M9ZElAKN3ASph+mJzf2rftOhG zqFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="gNqh/5Td"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si12645396ioq.17.2021.08.02.07.03.06; Mon, 02 Aug 2021 07:03:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="gNqh/5Td"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236052AbhHBOC1 (ORCPT + 99 others); Mon, 2 Aug 2021 10:02:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:34014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235914AbhHBNyg (ORCPT ); Mon, 2 Aug 2021 09:54:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 07CED610FE; Mon, 2 Aug 2021 13:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912380; bh=fxTKlP8bCqlQHIzZGwX0bK1SBTINMya2l7UTR2QEIg8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gNqh/5Td5mgy+lQc5twhm3lgCjsIaL/XrZL++3qXOucVI8rhgRhGB0N2CFc28BEgz Ovszwxvk88c+gJZiSvStbHJMjcmJIblOI7b8VD0NB0T+RM6SR6DmYcT+gnz2+zddss I5YNTTz1DBrGl2nOvexO08ZY9oL3PaM9Otca4+w4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aleksandr Loktionov , Arkadiusz Kubalewski , Imam Hassan Reza Biswas , Tony Nguyen , Sasha Levin Subject: [PATCH 5.10 34/67] i40e: Fix firmware LLDP agent related warning Date: Mon, 2 Aug 2021 15:44:57 +0200 Message-Id: <20210802134340.183880856@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134339.023067817@linuxfoundation.org> References: <20210802134339.023067817@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arkadiusz Kubalewski [ Upstream commit 71d6fdba4b2d82fdd883fec31dee77fbcf59773a ] Make warning meaningful for the user. Previously the trace: "Starting FW LLDP agent failed: error: I40E_ERR_ADMIN_QUEUE_ERROR, I40E_AQ_RC_EAGAIN" was produced when user tried to start Firmware LLDP agent, just after it was stopped with sequence: ethtool --set-priv-flags disable-fw-lldp on ethtool --set-priv-flags disable-fw-lldp off (without any delay between the commands) At that point the firmware is still processing stop command, the behavior is expected. Fixes: c1041d070437 ("i40e: Missing response checks in driver when starting/stopping FW LLDP") Signed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Imam Hassan Reza Biswas Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 874073f7f024..a952ae07d253 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -5106,6 +5106,10 @@ flags_complete: dev_warn(&pf->pdev->dev, "Device configuration forbids SW from starting the LLDP agent.\n"); return -EINVAL; + case I40E_AQ_RC_EAGAIN: + dev_warn(&pf->pdev->dev, + "Stop FW LLDP agent command is still being processed, please try again in a second.\n"); + return -EBUSY; default: dev_warn(&pf->pdev->dev, "Starting FW LLDP agent failed: error: %s, %s\n", -- 2.30.2