Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1648673pxy; Mon, 2 Aug 2021 07:03:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD5UDoLrdLA3E0ECwtkpeD7DwpfmQoz4YYBxj9z7gjTK1FCY6wfvj0g3Rtlz8XpUwE0/BM X-Received: by 2002:a05:6402:d67:: with SMTP id ec39mr19281670edb.117.1627913034412; Mon, 02 Aug 2021 07:03:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627913034; cv=none; d=google.com; s=arc-20160816; b=Lr0rL4+LaGpv3/GtSgPTJEmDL9uqrs4+gWhM+udfDspOi+AS8qbPySmJ95JY+/W7Bz AYcvy1poHVGeEH34zG2W8Zcy1ecQCeBJVgasHvlEcXvWCsTTKOH4SuaIeVu+mX85T5fZ T1QVMICxIsl8fuPYwMKxqFSb1q3eqqHa/h9EcY2iaeojKqjLraP06/GBB8iO2SKGcDbs lAN4EF9BedBV2u8nZyKumfsBYWNFGrBD4bex96AP2m9ExQCbQxrWIMEAzZXR7GW8c6yJ bVehlvDrYNMIa2DsJwyeVZb2jZA2z7nNJxyBuPhQK7FgRmorJ0ckNvChx4dpmoxkV77k xNiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=utAw26IU7KU/iVG8AKlQVLrhi3yXD5IGFYrgroWXLs8=; b=AFo9+CmlNVs351RWMah2b9a7ndvJk6PqcgJRTkYRhRh+iF6fPc+fDKfd1fGmZsCUgb XLI1V+USR6pG4IJHQ8rEoOZgZL1AozFAQAF2paSJ4lUyPpAb6pR7+ecbKeZDXajP/r4M dvbh5vpgmWIGCMp2ttpafppw843FIB3KNrPrVh52Ioo5Yvy7Oh+McSxCJZYEtL6ZbyKB oK1VDqDEYxUr5Nl5vAuzhJkrE6o1QT1fHQyUCYaE1JtrpnJ3lhQO9k20nkoEQ55h02nF Q9jeU8kFeEnRhMtzjC3EfrL0k6RQ0ez5IrK1rkMo01F7Q0gyUFOh1h5T3avq1D7MQlY+ Zbsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BK+HIw2j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu1si10631911ejb.482.2021.08.02.07.03.30; Mon, 02 Aug 2021 07:03:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BK+HIw2j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236375AbhHBOCN (ORCPT + 99 others); Mon, 2 Aug 2021 10:02:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:60854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235747AbhHBNyU (ORCPT ); Mon, 2 Aug 2021 09:54:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3618761183; Mon, 2 Aug 2021 13:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912358; bh=k+5vxf2jg4fS0EDyw3i+2FAXvaetqSfv4NJ24XYIk6w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BK+HIw2jghYrk/4hwwPk0NwHJz7M9sh5QIqxilI04hmy3R6WTTjzNfUtlPBRqXGLI QfdwalRqowr209TFF0I9wTU8WE5GxfmnyMglpoaUkfjPv+obVh97efQyerflWbtPq/ uEUes1r1m1nM+oFEtHJR7kpxKfY6K+Sn+lf4KHL4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, PGNd , Hui Wang , "Rafael J. Wysocki" Subject: [PATCH 5.10 06/67] Revert "ACPI: resources: Add checks for ACPI IRQ override" Date: Mon, 2 Aug 2021 15:44:29 +0200 Message-Id: <20210802134339.237262137@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134339.023067817@linuxfoundation.org> References: <20210802134339.023067817@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hui Wang commit e0eef3690dc66b3ecc6e0f1267f332403eb22bea upstream. The commit 0ec4e55e9f57 ("ACPI: resources: Add checks for ACPI IRQ override") introduces regression on some platforms, at least it makes the UART can't get correct irq setting on two different platforms, and it makes the kernel can't bootup on these two platforms. This reverts commit 0ec4e55e9f571f08970ed115ec0addc691eda613. Regression-discuss: https://bugzilla.kernel.org/show_bug.cgi?id=213031 Reported-by: PGNd Cc: 5.4+ # 5.4+ Signed-off-by: Hui Wang Acked-by: Greg Kroah-Hartman Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/resource.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -430,13 +430,6 @@ static void acpi_dev_get_irqresource(str } } -static bool irq_is_legacy(struct acpi_resource_irq *irq) -{ - return irq->triggering == ACPI_EDGE_SENSITIVE && - irq->polarity == ACPI_ACTIVE_HIGH && - irq->shareable == ACPI_EXCLUSIVE; -} - /** * acpi_dev_resource_interrupt - Extract ACPI interrupt resource information. * @ares: Input ACPI resource object. @@ -475,7 +468,7 @@ bool acpi_dev_resource_interrupt(struct } acpi_dev_get_irqresource(res, irq->interrupts[index], irq->triggering, irq->polarity, - irq->shareable, irq_is_legacy(irq)); + irq->shareable, true); break; case ACPI_RESOURCE_TYPE_EXTENDED_IRQ: ext_irq = &ares->data.extended_irq;