Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1657051pxy; Mon, 2 Aug 2021 07:13:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyB9leqFzp4xzleZNPThc1GjdQZxArqBOspOBvxdFkr1J8DnU1YkA3Gwi6d/V91/Qqddqtt X-Received: by 2002:a5e:c70d:: with SMTP id f13mr700540iop.95.1627913580889; Mon, 02 Aug 2021 07:13:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627913580; cv=none; d=google.com; s=arc-20160816; b=nL9lYAoJxXZ3ICB5zs5/8iB/2Tei2VUHRa8d4tlqJs0hnXLmSZ3sW5SWOhk9WHMXP+ TUDFATGhYEvTFlR55X3x29sgFd/3Hoozzs4J+XGyoiumN+JZpsjDKZJ8lBqdEmQ+KOPY DUXR7vjDq7LD7tL2NeXU9Vf3X3v2WHfSJJFAmdnubmdSVI25FZomcjo6cm5GiklrBfOl nGGLKDWFC0SDXR6qcpUmIkH+RrXTR2tsnZcLPNgj+fI0zowZhofTsurBz4mbtbMtx2LP JJ3DFLcWKjKBP2BdBIdWIcJfhmfZQ8hi2ekOdXpiEIf2jDqi3Gvk4Zm4JDwc0cPQk7Bc QdmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IzcoI5tDLR0LJKEu3cu9RQo3o7eN9XE0crpz7SnZgTI=; b=vgynLvWrVSekjCuvrhOP73eqxnxnQ4MnfhDnUNrvoyDO5WraruVAsV50DjM/LwFUZj 8V+gSkqfefzi6QQySDOvUz6HC8oK+rIaaSsUL/Fva+upTk0Nx2pkTdBf/cBIeXKGomsg Tq0GANR1hSE85ta0ohyOjwiagPnHB/ZgGhL1aFQhyPEWggoPMIwrZtnstI+1jiFtFt7l czLaeZTiFHWKjb0tH7DMPco3isZS2g5+dTfg5cPnbytEo8HISa9dl8G6v4Cqy605A3wN p0mhK2yQ48W36rA6IWGqdsav9D3A2bq16HKxmbmru5DZa4ZLFTxfUJ9E09QFldXlmBRO pz+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uHIUx96y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s14si13199326jar.33.2021.08.02.07.12.46; Mon, 02 Aug 2021 07:13:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=uHIUx96y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236572AbhHBOGY (ORCPT + 99 others); Mon, 2 Aug 2021 10:06:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:40684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236757AbhHBN7y (ORCPT ); Mon, 2 Aug 2021 09:59:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 551C76117A; Mon, 2 Aug 2021 13:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912559; bh=CbHqfKkY1wgCkbRplNT5SH0BTFiahUojKwPdvoQlDTI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uHIUx96yTor7IAjy4b8cu4MP67Tb1pybaVHOm+rESCjQvPEjqt8SdDiOeSxIrQEBX fLIw0S3csvLUOACdk7sgFPwehNy54VHh4HhklqHE9tEXgHAKWBniFPuCW+WpzQ7Y0D uFHskB9TeVfcl0GXFOHpU49n2EiXhK8oIWiIkmHU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aleksandr Loktionov , Arkadiusz Kubalewski , Imam Hassan Reza Biswas , Tony Nguyen , Sasha Levin Subject: [PATCH 5.13 046/104] i40e: Fix firmware LLDP agent related warning Date: Mon, 2 Aug 2021 15:44:43 +0200 Message-Id: <20210802134345.540766466@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134344.028226640@linuxfoundation.org> References: <20210802134344.028226640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arkadiusz Kubalewski [ Upstream commit 71d6fdba4b2d82fdd883fec31dee77fbcf59773a ] Make warning meaningful for the user. Previously the trace: "Starting FW LLDP agent failed: error: I40E_ERR_ADMIN_QUEUE_ERROR, I40E_AQ_RC_EAGAIN" was produced when user tried to start Firmware LLDP agent, just after it was stopped with sequence: ethtool --set-priv-flags disable-fw-lldp on ethtool --set-priv-flags disable-fw-lldp off (without any delay between the commands) At that point the firmware is still processing stop command, the behavior is expected. Fixes: c1041d070437 ("i40e: Missing response checks in driver when starting/stopping FW LLDP") Signed-off-by: Aleksandr Loktionov Signed-off-by: Arkadiusz Kubalewski Tested-by: Imam Hassan Reza Biswas Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 3e822bad4851..d9e26f9713a5 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -5294,6 +5294,10 @@ flags_complete: dev_warn(&pf->pdev->dev, "Device configuration forbids SW from starting the LLDP agent.\n"); return -EINVAL; + case I40E_AQ_RC_EAGAIN: + dev_warn(&pf->pdev->dev, + "Stop FW LLDP agent command is still being processed, please try again in a second.\n"); + return -EBUSY; default: dev_warn(&pf->pdev->dev, "Starting FW LLDP agent failed: error: %s, %s\n", -- 2.30.2