Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1657931pxy; Mon, 2 Aug 2021 07:14:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQVzDcxo+kx5BCtAYtBmbS4MVRp8jj6N9qoZtNdGbuVrdTi13SWTU4wvVAQ6zMkR/tzpGE X-Received: by 2002:a05:6e02:111:: with SMTP id t17mr567129ilm.221.1627913647420; Mon, 02 Aug 2021 07:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627913647; cv=none; d=google.com; s=arc-20160816; b=GQnCJIDS6dOJg7XStpEDbq5LiPXwzaRJAPgh3QYdT+vajgdk5MrxIFyznRS9TNI30c nygbDgmAoisPw+d+eCUgD8m2Gx4Vds5DpugNHnM9teNquyIfEgnqOqmXOEA8dGUfChMq b3mhnN7xJQ4tGyNEnOSmGRR1Cbm9i+FRZ+mZ9B/L2SWKfvGr4AzOCado4byiBMQcEANK VweFLTp7Is8bp6PartiT/nGWrw/snTdmnkw59ejgxdt7I9OBvJm410IJ1b7lY+Wpp2dV IfaR1Ax9+Yz8dJTH5YreVSqqTEVI+5e2SPbEBaCuOxiwUS5LY6ZOb8dFssy8VeQXZt+E DM2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=u5itwkFMlxViIXL5yq3wE0mw41UoGgfr5mazyz0uyZE=; b=ONp5aXIESgahTpGywOj3kiF7zv2DWu4CvdI0oiGZXyZGg0M86h007X7YjU6TZVurCL JPpmvHhzRjFXZJhADF+vLyhlgWwDNCFdBnMqS79ngw0gmN8w2rKbDA/SpoNaZvUvsIEj E4Du9x7kJZifYvAPhvMMEhvN4wg6YKNAQvoghLWO9gDp7Bvto0DpDqswLdlKycv8zmU1 hsQuqojvPV79LUp+6Hsi+9PLhvOj9CpC0/NxlRzKq7Ihtmg2ewsOCOpAg4bTZSSaYGfJ FSLKbfMBnB+aA3XsqAXBd3MHjpVMprzPHHSHunJm85iBCwBrLvtInhQZfLNpqN+9cYZG qFIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Kj1n9ssT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c7si12789035iot.72.2021.08.02.07.13.56; Mon, 02 Aug 2021 07:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Kj1n9ssT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235215AbhHBONN (ORCPT + 99 others); Mon, 2 Aug 2021 10:13:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:47228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236287AbhHBOCE (ORCPT ); Mon, 2 Aug 2021 10:02:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2274060F51; Mon, 2 Aug 2021 13:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912607; bh=PID4COQ8dq3pZ6rNMV2PSeT1oQnsspD1+0eG2YKCBH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kj1n9ssTfIZ8J1xNBq/EUvRF0FYV4Pu3Vosw9kk5VhwdsJwIJQy8juWo7uMVjUcdn SYddDc0vA6hvjZQFKz20+3oB9RNEsp0Uo6fu2SzCLvHTQK1O34EXdL7xiEQ4LfcHJS bMU8kPAeX/N2OK2emqVQ+R/l+kSHm8x3laUnDBTI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vladimir Oltean , "David S. Miller" , Sasha Levin Subject: [PATCH 5.13 052/104] net: dsa: mv88e6xxx: silently accept the deletion of VID 0 too Date: Mon, 2 Aug 2021 15:44:49 +0200 Message-Id: <20210802134345.733543157@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134344.028226640@linuxfoundation.org> References: <20210802134344.028226640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladimir Oltean [ Upstream commit c92c74131a84b508aa8f079a25d7bbe10748449e ] The blamed commit modified the driver to accept the addition of VID 0 without doing anything, but deleting that VID still fails: [ 32.080780] mv88e6085 d0032004.mdio-mii:10 lan8: failed to kill vid 0081/0 Modify mv88e6xxx_port_vlan_leave() to do the same thing as the addition. Fixes: b8b79c414eca ("net: dsa: mv88e6xxx: Fix adding vlan 0") Signed-off-by: Vladimir Oltean Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index beb41572d04e..272b0535d946 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2155,7 +2155,7 @@ static int mv88e6xxx_port_vlan_leave(struct mv88e6xxx_chip *chip, int i, err; if (!vid) - return -EOPNOTSUPP; + return 0; err = mv88e6xxx_vtu_get(chip, vid, &vlan); if (err) -- 2.30.2