Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1658307pxy; Mon, 2 Aug 2021 07:14:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu0Jpa94OUlzF54EXOyNMLEcaij4+SnTKg6KhKr+O+6Q2N8myLnrZVqmVKb3PT/pvNxdzt X-Received: by 2002:a6b:ba02:: with SMTP id k2mr1533873iof.164.1627913672973; Mon, 02 Aug 2021 07:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627913672; cv=none; d=google.com; s=arc-20160816; b=cR4rOhzsdFP0FnSlT1smCCsyh+/0JNu/7DT+4L9h+U1h6EetYBuVrLvFu+ID7AM0D+ r58IKrSUfhYiMfQr4vk+gLPUs4uOqV1fjkeu/e6sdolk8HCUGztBS+1Yo/4MK32mP5kL QuH53viIR82FWSKA0dJkEAn1goaGLHIq1EKYHfQZ5l+/wbfZh9xmVPGmv0NEucHTG6fS Pns4bxFOvEPwE9u4lJGPP9Lj8yKIVkXxXazBLHFiexAVSEaLiA1u2wfk8UYhOy4y0b1v cpYwGG5/UMbLiAmUtuzLPw9cSOphuPSHFd0qHvdjav9Gb/Mq5rL/jKaLJp2QgQWJFT41 ayxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0haupu9ZZTaCDeKUBCY9/tzDabO1jYgOLKXxKKyD/Vg=; b=pxGT2++sCcFVvFPZxfSXrhnu2fA0+86vss+GKJ/764TGLWMW37QokgXcKIt5mdghum /ncjIBnCU5F39aHIu+1UowZ/U88X4fnk2Cx+qtJj1Ed6zujTrCFa3yGSHX5KiusLJbcv ZVe5qj5mLM0VZAFKtIhzOmvNh/JfVyFinodYpPWXrqHVxD0opePgqmcZ9BziKPoVugnt mNw4qAKCPoF6qMgRhZ8xUQSs+mgpBYzK8K5CEyQ4BB2qmxMl4EsQ6YK5izXjQeJ25xZM 6UQXHc5H0atlmbjcTxsRpWtGrB7Jfuw70Lu2zY4NAKq/fWHWE9yDxenO/pnaPx3qO8mx CGSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CseNrlxP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o8si11062318jap.10.2021.08.02.07.14.22; Mon, 02 Aug 2021 07:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CseNrlxP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234525AbhHBONf (ORCPT + 99 others); Mon, 2 Aug 2021 10:13:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:44350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236346AbhHBOCK (ORCPT ); Mon, 2 Aug 2021 10:02:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD2E3611ED; Mon, 2 Aug 2021 13:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912616; bh=LInH/tI0eUELG0RI9th8yJ+JRNq+nK7IMp+t/D13LGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CseNrlxP5lEtZPFJDXQvg/KyAwQx1/R5x7/6s/fw1qAKU1RJDHEFPJB4qDGBANebK Bai9zvAuadigkbyWB3hJ+1U91q4nJiUAtxtkZzQfB9GWTiyJyBrnDE1ON7OHSgUImt rzCIm7Wz3neMi4VqckR3yQZoJ7NvIUKgX9Vjuc6E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ben Gardon , David Matlack , Paolo Bonzini , Sasha Levin Subject: [PATCH 5.13 073/104] KVM: selftests: Fix missing break in dirty_log_perf_test arg parsing Date: Mon, 2 Aug 2021 15:45:10 +0200 Message-Id: <20210802134346.420213869@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134344.028226640@linuxfoundation.org> References: <20210802134344.028226640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Matlack [ Upstream commit 15b7b737deb30e1f8f116a08e723173b55ebd2f3 ] There is a missing break statement which causes a fallthrough to the next statement where optarg will be null and a segmentation fault will be generated. Fixes: 9e965bb75aae ("KVM: selftests: Add backing src parameter to dirty_log_perf_test") Reviewed-by: Ben Gardon Signed-off-by: David Matlack Message-Id: <20210713220957.3493520-6-dmatlack@google.com> Signed-off-by: Paolo Bonzini Signed-off-by: Sasha Levin --- tools/testing/selftests/kvm/dirty_log_perf_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c index 04a2641261be..80cbd3a748c0 100644 --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c @@ -312,6 +312,7 @@ int main(int argc, char *argv[]) break; case 'o': p.partition_vcpu_memory_access = false; + break; case 's': p.backing_src = parse_backing_src_type(optarg); break; -- 2.30.2