Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1659408pxy; Mon, 2 Aug 2021 07:15:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBcn+fn1Y1+wH5tFjPRO53Eu+Upm5tarAuUHPd1R/5SGok7XVer3H7b9RM5v7JigUMGmFC X-Received: by 2002:a05:6e02:154b:: with SMTP id j11mr11878449ilu.96.1627913759559; Mon, 02 Aug 2021 07:15:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627913759; cv=none; d=google.com; s=arc-20160816; b=w+00rIxLL8lAynXO3f0o1y6/3eZ2Ax+VGd0Bqt/DOC5vhsbzqEZLXelogsHOEYGor/ 9slePLrkZ8kUXkOyFKxxk2xXD12g4zUVGnIAWD/Ew2nSVq5KiT/2CvvPuH6thbhFbPp4 9+6XvebOpO8xxj8OX/evDs+v8MJsZI9OBS4/c42N/tojmO8De0Q1tZsKoc3Qr43kblrZ y9tQ4GwrW9lWdWDRGy4U9nbQTsfSUnZwqT2OmXWGtfIUR7ZVs1G/W5YuzDqfAAgzEbkB jFxwuBDGDnHferee7l8GtnqjJMeE5O/pPuX+Ltwsje+B0jlFuJoqLuLAZEFtBb4u2KAV ZM8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hKHYo/npVgEZm/vLIsguPaPoaUcG/XORM7+WAJIHyeo=; b=hekSzcY6UoxFY+RKOCtXLY7W/QuUa6oiJx7RIePr/8h5CDfVtQAWpSoESRiY/AM/MG bZXrR3wAa03PYWYLv97edLdtkw2HqEWYxBJhVB1dsuX1yyyLsCD2FzGu5JYL1t67k9KB dsxiJMAstqQGs5YoeDtiD4yHnpiEBXhyyphaxMIztM/G671KijqdVD+aZ2RT6lrDcqbt aoLM4RGkJekDkp8GBDzRbSTug4zpsm/WoDO3zdnzHwQfLzlLD7rs8q4searTDI7E3AmF ieU/DbN/771Y/vuvTGemKZbNag7SCSXvhnsZAirr++W+ia8SUyrzFazr2dzP/MMQDM6G n0QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kBWm6vf7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k4si4784389iov.69.2021.08.02.07.15.47; Mon, 02 Aug 2021 07:15:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kBWm6vf7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238318AbhHBOOu (ORCPT + 99 others); Mon, 2 Aug 2021 10:14:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:48968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237018AbhHBOE2 (ORCPT ); Mon, 2 Aug 2021 10:04:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B2D0D61246; Mon, 2 Aug 2021 13:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912675; bh=mtAyM5L3tHxPRG8Xun/z/inxFpSPyTVOTAv0BBc/6Kk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kBWm6vf7CAYOt9PBzs1IuoeJ8hctm40hxsbsPpqmGo5Ck3pldGALgwxkkilkARUpT F8D9o/n9/LgfkRPsIaARAFyFWgxQLTbz/9m37alRuwsQYSNKvG9uh4BIctvf94Xf7x /HFIAnEwdiYHGBIfU5b8SntHeNIKjHcH5r3jB73s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukasz Cieplicki , Michal Maloszewski , Tony Brelinski , Tony Nguyen Subject: [PATCH 5.13 101/104] i40e: Add additional info to PHY type error Date: Mon, 2 Aug 2021 15:45:38 +0200 Message-Id: <20210802134347.326654469@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134344.028226640@linuxfoundation.org> References: <20210802134344.028226640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lukasz Cieplicki commit dc614c46178b0b89bde86ac54fc687a28580d2b7 upstream. In case of PHY type error occurs, the message was too generic. Add additional info to PHY type error indicating that it can be wrong cable connected. Fixes: 124ed15bf126 ("i40e: Add dual speed module support") Signed-off-by: Lukasz Cieplicki Signed-off-by: Michal Maloszewski Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -980,7 +980,7 @@ static void i40e_get_settings_link_up(st default: /* if we got here and link is up something bad is afoot */ netdev_info(netdev, - "WARNING: Link is up but PHY type 0x%x is not recognized.\n", + "WARNING: Link is up but PHY type 0x%x is not recognized, or incorrect cable is in use\n", hw_link_info->phy_type); }