Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1661788pxy; Mon, 2 Aug 2021 07:19:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxH944zFMq+9GfYbsP6uAb07bHGd7S1/YsEZtdoMddoBB7moz2Z4TM089yG4N9hbDYMfYL9 X-Received: by 2002:a05:6512:31d6:: with SMTP id j22mr13873861lfe.138.1627913950711; Mon, 02 Aug 2021 07:19:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627913950; cv=none; d=google.com; s=arc-20160816; b=LXnopsVPtaOprxqEHe5Nde3aCDZ2hl1QON/99yBXp6xRMONIVGC9BhPNwBD5nF8Aot jfP9mK1IVRJ1GrksUZX7Vus948trb3HuUA5D3648vWM/Pe02JA3cQkRPZlcVRO3bP57j wIscf+hiGSuIByF4dALs+g0Xtdjn0XhY7MdENOMoYyJ4eQ9o5NWHnrz7dAPRBANWPNAL SGECzenLo26p5SSDKrazS1fNkXGj7lmVYuN+/sorts6YnHxIK9AvzSVcyTmvC5qUrBlu isN6fYPcbbXYN4FEQLp4gpKK3Kq5Hp0ulZt7bCjJc8Um8wKzzIauUXKaCb7zaFVqX5j7 MhIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YbzRbo4dG9OltW+Re/tSYnSbw7tndidVsKDxh2IRSQI=; b=SzcMKTmXh6lt4XZ7uMHdoOAcTJwF7QT5UywvLCsxcglHX6yAuRUPLVC00rrUf3G6nK e3ad0k7SKHIXLB0qjlaS7ACobYM43IUs0UEcdHYJXdPZwfhdWrkqxqiuPY8MrXmND4h2 Lj5pRNPvrgeSDh2HpIFw5qYgNvcVetII2YWBCrgNtpWnGjYgrICwBfsBonyRSMCoRUSh VxG43tPgFq6R8u9VvCmsELG3iBZkEesRUJ/1Mq+v7mdjjYuvgCGYcyykg1wmhBvlwrVx jXvmiSHuEvDiaAnyKCLy88ZEoS+oMxkDwSrihzFMwJbh5W5jCuENkjAOC3ZdGkdoaohi 7KBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=g1zDaTob; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v75si10905796lfa.532.2021.08.02.07.18.43; Mon, 02 Aug 2021 07:19:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=g1zDaTob; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238076AbhHBOOa (ORCPT + 99 others); Mon, 2 Aug 2021 10:14:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:47242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236449AbhHBOEL (ORCPT ); Mon, 2 Aug 2021 10:04:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 25B0F61220; Mon, 2 Aug 2021 13:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627912668; bh=P4O20h24Avn0zbvhuuzMM0lafSI1Gr1v8bn5k7oeJwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g1zDaTobytdBt/t8+Sw7N5peeC61iezBwMB0S6acWGRXorDCfbX4uD2MKEkAuHy9q 7+RsS/mqEylHCuzns5+Z0E2PWpAfGi0WLLyDcrKtKx7TBjRk3zHZtAfAlCPm2Fcqbg CfSInnLx9VShqeim++rc3rEX76JaAK8u/x538AIM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, marc.c.dionne@gmail.com, Srikar Dronamraju , Michael Ellerman Subject: [PATCH 5.13 098/104] powerpc/pseries: Fix regression while building external modules Date: Mon, 2 Aug 2021 15:45:35 +0200 Message-Id: <20210802134347.230376153@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210802134344.028226640@linuxfoundation.org> References: <20210802134344.028226640@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srikar Dronamraju commit 333cf507465fbebb3727f5b53e77538467df312a upstream. With commit c9f3401313a5 ("powerpc: Always enable queued spinlocks for 64s, disable for others") CONFIG_PPC_QUEUED_SPINLOCKS is always enabled on ppc64le, external modules that use spinlock APIs are failing. ERROR: modpost: GPL-incompatible module XXX.ko uses GPL-only symbol 'shared_processor' Before the above commit, modules were able to build without any issues. Also this problem is not seen on other architectures. This problem can be workaround if CONFIG_UNINLINE_SPIN_UNLOCK is enabled in the config. However CONFIG_UNINLINE_SPIN_UNLOCK is not enabled by default and only enabled in certain conditions like CONFIG_DEBUG_SPINLOCKS is set in the kernel config. #include spinlock_t spLock; static int __init spinlock_test_init(void) { spin_lock_init(&spLock); spin_lock(&spLock); spin_unlock(&spLock); return 0; } static void __exit spinlock_test_exit(void) { printk("spinlock_test unloaded\n"); } module_init(spinlock_test_init); module_exit(spinlock_test_exit); MODULE_DESCRIPTION ("spinlock_test"); MODULE_LICENSE ("non-GPL"); MODULE_AUTHOR ("Srikar Dronamraju"); Given that spin locks are one of the basic facilities for module code, this effectively makes it impossible to build/load almost any non GPL modules on ppc64le. This was first reported at https://github.com/openzfs/zfs/issues/11172 Currently shared_processor is exported as GPL only symbol. Fix this for parity with other architectures by exposing shared_processor to non-GPL modules too. Fixes: 14c73bd344da ("powerpc/vcpu: Assume dedicated processors as non-preempt") Cc: stable@vger.kernel.org # v5.5+ Reported-by: marc.c.dionne@gmail.com Signed-off-by: Srikar Dronamraju Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20210729060449.292780-1-srikar@linux.vnet.ibm.com Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/platforms/pseries/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c @@ -77,7 +77,7 @@ #include "../../../../drivers/pci/pci.h" DEFINE_STATIC_KEY_FALSE(shared_processor); -EXPORT_SYMBOL_GPL(shared_processor); +EXPORT_SYMBOL(shared_processor); int CMO_PrPSP = -1; int CMO_SecPSP = -1;