Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1677674pxy; Mon, 2 Aug 2021 07:41:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqut9QJMG9ob33BAKZWWZYNi8rtgVWKGUfxgOyxfC2VC3FQ6X2znwwyseglToMR3+Ky9Uu X-Received: by 2002:adf:fc8b:: with SMTP id g11mr17970093wrr.224.1627915298743; Mon, 02 Aug 2021 07:41:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627915298; cv=none; d=google.com; s=arc-20160816; b=zLPUfOrspR2iqUD5u4ZbaRY1VmQ+20NUEVuO0NAqiz2JBNW/xaK45Yo8nSb4SsOMUL euX5E+Y5kTn5gEfeiuUk2aIm/lYqBfbfQ5XJ21kRmOGv0kfk83CyxgG8HOrE+8JOaAQm cwEQyCV9N/KTViIRKD/l0xoAvus5Cz+4yrg0z7c+fJSzobXR70299i7oJ+1/GeIwg6mD soUT9Abe6f9b+ok4LFXQxqUd/s1DZRlDqSuxeE8+m6983SWoBLv+Nsq/tBXqUyOpfjff S7VoakQVtCteh52+g0hVPzildtkdS552daifkj1mshTmAQy449WzofAVk+ZHGQbiV+0h pe7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=wFIHWiCsTyaJ28kYvzwbXDTYKoKwfWvjZIwC0ZVSCJA=; b=TUYxwNbh7z/sZNLtrOO16cTrytu31mBjWFNtUWx5Qw6/qWHNW/XxpTiFUsgAGbJ4Em i9INMwaOZpmiTQevSkI5cHuz52PcuC8nn9Rzh/KwnAoKEj9tvP1hOsLRamGGSpiiIYRW rdhmDLOgtiUssRp4JeTfWyg6+mQuCQeawI4DXVM1udNevm81qEQeDOySu+d0KC+6BMSy gMsafsNqmLZq/oY1WH+l8R+xl9s74yVoKxpjifWLBzFRmL02uDxrveD5jx/B064tT0fu p8thIBrfC3+HyaaXs+9YBvZmR8t1MvEprdaDH5rn5+P3HrNQl2HjzfQAyp2eOaYHhCxD SaHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AGjDHM9z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si10527728wru.205.2021.08.02.07.41.15; Mon, 02 Aug 2021 07:41:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AGjDHM9z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234220AbhHBOh7 (ORCPT + 99 others); Mon, 2 Aug 2021 10:37:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:44878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233925AbhHBOh7 (ORCPT ); Mon, 2 Aug 2021 10:37:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A7EA760F5A; Mon, 2 Aug 2021 14:37:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627915069; bh=rjcQFbefs4y8JgCbUFdJmgVkXkThVhcwqF9WjgoJ+Qo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AGjDHM9zoZPQcQ1/pFuwYYKiW7tWnt6cXUBqqRX0DQIFsMIpy4MS+2E2mSMbcyH0/ uGVd3PF/DEkXYoTs03fpVZDpKfCNCYYIOMS1IeaAObHxH1X0CrcGnfnESnWkDLuE7D fGKsdmEmw72k9cxtW3bGaUp1GoUes1itvEl0D/G6SdjUO5rKNFVEBald3rv2D7obxw EcMGlTFylFkv3c1lL2I8B+7jMqkQspRafaG37PmQBq/pm5pxzxQRWaWjMmGRCzdvyU oz3ogpGHtKb8Yrnsq7fmJCqWcDUgblaStB+jFYjNMPlU1yQu5jL/cyTIbIniUO4fP0 QYWK9wbWArvmQ== Received: by mail-wm1-f48.google.com with SMTP id l34-20020a05600c1d22b02902573c214807so8509980wms.2; Mon, 02 Aug 2021 07:37:49 -0700 (PDT) X-Gm-Message-State: AOAM533wkjgxel0mit8wO03GeCVGIv7lSwXY04S+cErTWR/8IBunu1w8 VIVGjQVu17DCbGTxWEYxghpvJMthuSpDyp+/MYM= X-Received: by 2002:a05:600c:3641:: with SMTP id y1mr8196846wmq.43.1627915068330; Mon, 02 Aug 2021 07:37:48 -0700 (PDT) MIME-Version: 1.0 References: <20210726084540.3282344-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 2 Aug 2021 16:37:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Intel-wired-lan] [PATCH] ethernet/intel: fix PTP_1588_CLOCK dependencies To: "G, GurucharanX" Cc: "Brandeburg, Jesse" , "Nguyen, Anthony L" , "David S. Miller" , Jakub Kicinski , "Keller, Jacob E" , "intel-wired-lan@lists.osuosl.org" , Arnd Bergmann , "netdev@vger.kernel.org" , Kurt Kanzenbach , "linux-kernel@vger.kernel.org" , "Saleem, Shiraz" , "intel-wired-lan-bounces@osuosl.org" , Richard Cochran Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 2, 2021 at 3:10 PM G, GurucharanX wrote: > > > > From: Arnd Bergmann > > > > The 'imply' keyword does not do what most people think it does, it only > > politely asks Kconfig to turn on another symbol, but does not prevent it from > > being disabled manually or built as a loadable module when the user is built- > > in. In the ICE driver, the latter now causes a link failure: ... > Tested-by: Gurucharan G (A Contingent Worker at Intel) Sorry for the delay. I had remembered that there was a previous discussion about that option but couldn't find the thread at first. I now found https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/ and will add Richard to Cc for my new version as well, just in case he has objections to this version and wants to fix it differently. Arnd