Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210731192637.3653796-1-lrizzo@google.com> <YQf9h+qvWCx6D7XT@8bytes.org>
 <CAMOZA0LEr+xM6RrsJErPMqHP7-0GdLmNDqbGVKbKTn92=Ncejg@mail.gmail.com> <YQgDfIcFW5h9TH+n@8bytes.org>
In-Reply-To: <YQgDfIcFW5h9TH+n@8bytes.org>
From:   Luigi Rizzo <lrizzo@google.com>
Date:   Mon, 2 Aug 2021 17:26:57 +0200
Message-ID: <CAMOZA0J7B=rnVpaa6WiMf3Hpr6=tk1QZeDRWjRFFW04FLx4n=A@mail.gmail.com>
Subject: Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault()
To:     Joerg Roedel <joro@8bytes.org>
Cc:     Will Deacon <will@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        David Rientjes <rientjes@google.com>,
        Luigi Rizzo <rizzo.unipi@gmail.com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 2, 2021 at 4:39 PM Joerg Roedel <joro@8bytes.org> wrote:
>
> On Mon, Aug 02, 2021 at 04:30:50PM +0200, Luigi Rizzo wrote:
> > Ah didn't realize that. Thank you!
> >
> > Two questions on the topic:
> > 1. how comes only the AMD driver is so verbose in reporting io page faults?
> >    Neither intel nor other iommu drivers seem to log anything
>
> What do you mean by 'verbose'? It is only a line per fault, and at least
> the Intel driver also logs DMAR faults with one line per fault :)

Ah never mind, I was grep'ing keywords from the amd message and
there is almost zero overlap!

thanks
luigi