Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1720990pxy; Mon, 2 Aug 2021 08:38:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWKIH/9YiK48wfMNboLn61OZmBmPggiyxfg8sCsMMp/+rsPJ6WC/Qecvwo3oA5QNkE/IJA X-Received: by 2002:a17:907:1687:: with SMTP id hc7mr15759488ejc.314.1627918715124; Mon, 02 Aug 2021 08:38:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627918715; cv=none; d=google.com; s=arc-20160816; b=Z3o+rygad8GQm+P3pSuAoZjFol8I0yjJQk5LY7bLfUqOpSKC/Vqqp0EWdSBxAIBmmL PLnSvVJqGVkHAdQ2OP3HMQNZed/41s0CllKqo4VQFSLX2k7Hd+rp7/QcfZKe4AjlzZM2 5KnfIh6MX/zgpLNbQbrRgPgnvjuZymhdyU2PBngtI7JQ0fymgNqNyvCAqStp8a0wkame hLZeG+AxCdoAy50cSfPRallNxUOS4USg83X6VfhrhIPUf0GW6tjWiTs2QvGuuogmyDcb cdbIbDHpHPtwzvnYls009AlF/25ICahmY5fi48nb0AadCCQK6BWBD26FV5B2IFIZFhBn 8IQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=OVPe1BDO1mAI1uMQKOi0f+U32DpIBdtvHOdMIPouaos=; b=ZP0fVoa8/0ixX8BhptDL1f98QhH1CjRGW8vYiWYWwgLVVr+fZg++eqKCR2GReT+FbY WjdNGgVl0MN8aesdOISvru4yxQK08HBHBvLtgP8+EjjX2JULVmwLwSGP2YbZ1pjVX90K f6w2Cy4DpRCSW3LU+8KVQD4Gap9MZgG4P+bQo/Okqk5KBuhATq/Au4ha2hOzdYwopuNk jB8SvdC5ypazA4Re2BPDQMb5VRDeJDsaK6XbWiXX8G8CZkpWmb96NyzaPCLR/N6z4Lod YaCDMkMHQRHpkGCkHQpx/TKwKhUQ8QL7iObYQ/BEcpm12lvwMFCaSOonieLwaFTO3JVf HOYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f9si8858530ejl.743.2021.08.02.08.38.10; Mon, 02 Aug 2021 08:38:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234313AbhHBPgt (ORCPT + 99 others); Mon, 2 Aug 2021 11:36:49 -0400 Received: from mga06.intel.com ([134.134.136.31]:45034 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233939AbhHBPgs (ORCPT ); Mon, 2 Aug 2021 11:36:48 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10064"; a="274541762" X-IronPort-AV: E=Sophos;i="5.84,289,1620716400"; d="scan'208";a="274541762" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2021 08:36:38 -0700 X-IronPort-AV: E=Sophos;i="5.84,289,1620716400"; d="scan'208";a="418704479" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2021 08:36:35 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 8870C2036B; Mon, 2 Aug 2021 18:36:33 +0300 (EEST) Date: Mon, 2 Aug 2021 18:36:33 +0300 From: Sakari Ailus To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Pavel Skripkin , Arnd Bergmann , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: atomisp: restore missing 'return' statement Message-ID: <20210802153633.GN3@paasikivi.fi.intel.com> References: <20210802143820.1150099-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210802143820.1150099-1-arnd@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 02, 2021 at 04:38:14PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The input_system_configure_channel_sensor() function lost its final > return code in a previous patch: > > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor': > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type] > > Restore what was there originally. > > Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code") > Signed-off-by: Arnd Bergmann Thanks! Acked-by: Sakari Ailus -- Sakari Ailus