Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1729666pxy; Mon, 2 Aug 2021 08:52:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwW0XjGcYdTJeNXU7urhnDcS88cYeT7zTls3XO6J3c/xwpdBxLQgD+J0HsnaTNzmoqyAbt+ X-Received: by 2002:a17:906:31d4:: with SMTP id f20mr15660598ejf.383.1627919538782; Mon, 02 Aug 2021 08:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627919538; cv=none; d=google.com; s=arc-20160816; b=uBKtSHPCh+Om3jRNvWfcovfhP6T/iGC7G3hqRvhUk/ixdWE/5GzCQjOjp8VoYIfIkb DOuwWhPLeaWk6qlc/wKFeNG9xRVa/b1/G5eZ1guFqVpmBiZ3Q3XDezH4dqzAS7fPyqrJ 5zrXqHbF4DlRR4ZJkxw+w+BKqn4+DJ/Yqcb1EaZBJHNTM8y/LO0leZSuOWLLpyAyj7v2 wUP+zvJfnDHnMOGO1WBGGOJoA3SDZqHJI61HPQxnV1Gq94oUHRY0I0GfereQsEjpoowj Y40ald10EWvDcf/V8JU2rX30YiCRqSqaw5RyVxtL744drFaPzIBREmkaqEJ0urubVlIp TxBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-disposition :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=iFEvhb+pWS2fHWjo0SPK+/xVkX5ExnAVIzPe3nLKKpI=; b=MzNPJ2pIkprHhf5E8g2hZK4b8OH1fbIm70U754psnfQsvFdEWMhKelCANqksVLwghZ 1QAsUQlOlCdLPQS3i9jhz8YfGyIX/r/HZ87L5ovLpjylKfv/RqyYikox/aQ6zvjXBGSu UR2iAFONHjT94Upmzuqm3iC1l4k2KQAN1i19Ur9BCtwvm20iqsKvauBrzGMDkUR87uLh KCX1ChQ2nsbJMZrWBmtyB0dQ/sm2HYjzP+EeujkPmSmfiTU9IWUq3SLOLGLC1eLH0+oI Yoyfu++PyJ+yHqXEAd9VQ3BxOeYaWrLnwIKgRPu5i3orBN7rpIO39vN+37Gb9+oOl0hg nZLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gkFlepEt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q23si10479366edb.44.2021.08.02.08.51.53; Mon, 02 Aug 2021 08:52:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gkFlepEt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235254AbhHBPs6 (ORCPT + 99 others); Mon, 2 Aug 2021 11:48:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234148AbhHBPs5 (ORCPT ); Mon, 2 Aug 2021 11:48:57 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F709C06175F; Mon, 2 Aug 2021 08:48:48 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id m10-20020a17090a34cab0290176b52c60ddso559958pjf.4; Mon, 02 Aug 2021 08:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=iFEvhb+pWS2fHWjo0SPK+/xVkX5ExnAVIzPe3nLKKpI=; b=gkFlepEtWgxNsrASRfaQY1uh8Mj1erqxFQyyuDQKRDZoyjFfTKzszqOVZfchtHwSxB EayR11JSZNgAg968gT6S5f08lqOqp40AozL+gcIs7p5U/u2OvSV997QvGXceRBSUSyq0 8/6BeEz2l8ggw7ohQ7L9Aqemvo6H9iS/AjnavSo+8Sgpyfrw4pMw/juAPvShadnZ2p8G XdZMWRPfIFvuGlHWcniw9F9dTzaQXIVkbANdvzc8rBVJgzP+WjOZSWpCFVWshcxHwMRc FJBkEMGTYBwjm7Q7JKTBiVdV+ncrbrvMr3zySwWg7xAfLcyzwHYcG1lj6KnPs2mk69GR ANgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=iFEvhb+pWS2fHWjo0SPK+/xVkX5ExnAVIzPe3nLKKpI=; b=MQdKrF5SP3C578dUjo7aYHUEl1LZAQ8zCnNv7UQ+sfTVm0nUt6vGvFZnTrcgHhqnCU W01YBSb+3aSrtVwBvFTXMS5gBuLmkT9a/Qyp+3r2Vi72DpkIHXQMC2yo2goRAbIlcUn1 CmgXFIQjRqFj18+T7S/fa6AHnimMbL6KeoI8z1z1Z+tinqLCV5n4SgGzTHYn71wweRQ9 KpDS8zZCnv/nMasj/keazhG/7QXMT+8hCtew0mt3IvJFjn0EnrfRPwqn+IZeE5weuseG Meerg/WXrL1L2AcUBufcsRPMDFhHw6obkscBqG7lUoiafBZILiQa2PYRAbu9oCtilZcf POYg== X-Gm-Message-State: AOAM530TVyk0GoNyajzJS+gfy8G09pdj3rA3E+aFNcZqzRvbs7VDRWzs Z8ST8dbI80bZ3SKF7oqT0ek= X-Received: by 2002:a62:8fd4:0:b029:3af:3fa7:c993 with SMTP id n203-20020a628fd40000b02903af3fa7c993mr16580168pfd.77.1627919327667; Mon, 02 Aug 2021 08:48:47 -0700 (PDT) Received: from haswell-ubuntu20.lan ([138.197.212.246]) by smtp.gmail.com with ESMTPSA id v13sm11244135pja.44.2021.08.02.08.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 08:48:47 -0700 (PDT) From: DENG Qingfang To: Vladimir Oltean Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Woudstra , =?iso-8859-1?Q?Ren=E9?= van Dorst , Frank Wunderlich Subject: Re: [RFC net-next v2 4/4] Revert "mt7530 mt7530_fdb_write only set ivl bit vid larger than 1" Date: Mon, 2 Aug 2021 23:48:38 +0800 Message-Id: <20210802154838.1817958-1-dqfext@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210802134409.dro5zjp5ymocpglf@skbuf> References: <20210731191023.1329446-1-dqfext@gmail.com> <20210731191023.1329446-5-dqfext@gmail.com> <20210802134409.dro5zjp5ymocpglf@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 02, 2021 at 04:44:09PM +0300, Vladimir Oltean wrote: > Would you mind explaining what made VID 1 special in Eric's patch in the > first place? The default value of all ports' PVID is 1, which is copied into the FDB entry, even if the ports are VLAN unaware. So running `bridge fdb show` will show entries like `dev sw0p0 vlan 1 self` even on a VLAN-unaware bridge. Eric probably thought VID 1 is the FDB of all VLAN-unaware bridges, but that is not true. And his patch probably cause a new issue that FDB is inaccessible in a VLAN-**aware** bridge with PVID 1. This series sets PVID to 0 on VLAN-unaware ports, so `bridge fdb show` will no longer print `vlan 1` on VLAN-unaware bridges, and we don't need special case in port_fdb_{add,del} for assisted learning.