Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1760215pxy;
        Mon, 2 Aug 2021 09:32:39 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxrVDfz+uGluxNNZ+q/PJcXgWfVbmZW9u/+q4JNKelzMrRgs3+0FME58XGX58hLaRH4GYV1
X-Received: by 2002:a17:906:cc57:: with SMTP id mm23mr15607716ejb.12.1627921959189;
        Mon, 02 Aug 2021 09:32:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1627921959; cv=none;
        d=google.com; s=arc-20160816;
        b=qoMFFkaiTVsBEg7E+i4g6jhgiF9oq/b/rCs+EXZ2vvWgGEXda5M1NTHY747oHGPA/7
         pTnvYtbp5Y9nYHY6/qWVdXOV5oQRNwMBHoYfmmhcHMJ9LXCLUdUWFTc5smWd7KTZaZEM
         sox3hSMlcGBBaNNY4NZj41T6ryV+mJj3+wo9/WHvGP8hNBSpiOSRyrgQGuhdoHqcivso
         OyihZo5FSgZF29G43irbn77DVcrzvMabjD+BLStCkggu/yxOcSH4Hq95qqbK41l4S983
         XsQVjkm/kch57fLUL339UCI9/NFpoZfAk/LrDzPr8eqRkCVMkMnqie/0sy1whn9pXbXa
         cuVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=Ink7RCVzVbTa9ShgDcfLhqsNlFtzgpAD+HPzQTS47rQ=;
        b=P+Fb2De6OFe7K/IkqlQtWE9UP1XJZwC0B1aHBIzeGidn7JWBli2PwwmNSWiNbozdN1
         aciYx1oBqiGJKXDev4a5hw2zfd0eWOP6P7Bcw3aIDmrhh0mfycX09ESE97RIWU34hRFL
         xpmss9wONWOk1lJWXINDFTh1fJqxsssHrxXcQH1BeUnCR2gNRiZnyP99R04o6lKQJzIp
         MB3Ym8rZEsGL9vR+ZYLWfL1D5QJ1rCdUy+kVXSC90kz1HwmhVIuMSVhyp7mobfR07lVn
         OhJPvFnc/ET13QPw6D/cyjp+koLyu0qp0ZFpRiRSC57sZ6KPAjsKnBz2iuxmn8xFiTFJ
         VQIQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TTHTtbpm;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id q18si12922589edi.368.2021.08.02.09.32.16;
        Mon, 02 Aug 2021 09:32:39 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TTHTtbpm;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232215AbhHBQbB (ORCPT <rfc822;linux.whf@gmail.com> + 99 others);
        Mon, 2 Aug 2021 12:31:01 -0400
Received: from mail.kernel.org ([198.145.29.99]:43692 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229744AbhHBQbA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Aug 2021 12:31:00 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 15E8460FC0;
        Mon,  2 Aug 2021 16:30:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1627921851;
        bh=8jE3OUxJl9dbV/Xx+Vz/QVOO/iSlqKM/+hmL/9lbkD8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=TTHTtbpm21w0nqjLTebJFvefzdBg5PDyP37z1fWUduVzpWeKfP34nEKt0QEJL1vVh
         bvfuuSY+86Yv6txP5Ms2834d0zHfUhHDVeV4up9H8WgW83r6xg9eLS2An2B0zX0VJH
         TlN6DpbW5g7ZINK+uQJFrMPCW38PgopsS7Tl3KXynnRpTzvtTyZSD0HLpFb/f5gd8t
         e2abbU4N5UHeCZmEXgOY6973lkeVcNTldC45k9KjB/WNvRu4WixG7AEE9iUcbtlviz
         UbCpU7LQdk34jJOB3nBcjzxUZ0KaULNxpRK+c/y8X2yXwenrNdcPK+cGVxpslVvPbU
         CcoE62NH6J17Q==
Date:   Mon, 2 Aug 2021 09:30:50 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] neighbour: Rename procfs entry
Message-ID: <20210802093050.67c361f4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210802035745.29934-1-yajun.deng@linux.dev>
References: <20210802035745.29934-1-yajun.deng@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon,  2 Aug 2021 11:57:45 +0800 Yajun Deng wrote:
> Use gc_thresh_{min, default, max} instead of gc_thresh{1, 2, 3}.
> This is more friendly for user.

We can't rename files in procfs after they had been present 
in an official kernel release. They are uABI. Same goes for 
your default -> current rename patch.

You also forgot to update documentation.