Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210719223153.1618812-1-namhyung@kernel.org> <YPaQ94VCtYWSXYnh@krava>
 <YQfwLP4Ebsc3Wzb2@kernel.org>
In-Reply-To: <YQfwLP4Ebsc3Wzb2@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 2 Aug 2021 09:33:14 -0700
Message-ID: <CAM9d7cijTT9DFec1LRHM0PFwRe6zZ7qE-n9Yw2Qu1hDhLdTfDQ@mail.gmail.com>
Subject: Re: [PATCHSET v3 0/5] perf inject: Fix broken data with mixed input/output
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Arnaldo,

On Mon, Aug 2, 2021 at 6:16 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> Em Tue, Jul 20, 2021 at 11:01:43AM +0200, Jiri Olsa escreveu:
> > On Mon, Jul 19, 2021 at 03:31:48PM -0700, Namhyung Kim wrote:
> > > The perf inject processes the input data and produces an output with
> > > injected data according to the given options.  During the work, it
> > > assumes the input and output files have the same format - either a
> > > regular file or a pipe.  This works for the obvious cases, but
> > > sometimes makes a trouble when input and output have different
> > > formats (like for debugging).
>
> > >  * changes in v3
> > >   - use task-clock:u in the pipe-test.sh
>
> > Acked-by: Jiri Olsa <jolsa@redhat.com>
>
> Thanks, applied.
>
> Had to do some adjustments due to minor conflicts, can you please check
> tmp.perf/core?

Thanks, it looks good to me!
Namhyung