Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] dmaengine: idxd: Remove unused status variable in
 irq_process_work_list()
To:     Nathan Chancellor <nathan@kernel.org>,
        Vinod Koul <vkoul@kernel.org>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210802175820.3153920-1-nathan@kernel.org>
From:   Dave Jiang <dave.jiang@intel.com>
Message-ID: <d03981eb-67da-55fe-bc82-d83b00a22944@intel.com>
Date:   Mon, 2 Aug 2021 11:02:17 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210802175820.3153920-1-nathan@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 8/2/2021 10:58 AM, Nathan Chancellor wrote:
> status is no longer used within this block:
>
> drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status'
> [-Wunused-variable]
>                  u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
>                     ^
> 1 warning generated.
>
> Fixes: b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Acked-by: Dave Jiang <dave.jiang@intel.com>

Thanks.


> ---
>   drivers/dma/idxd/irq.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index 65dc7bbb0a13..91e46ca3a0ad 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry,
>   	spin_unlock_irqrestore(&irq_entry->list_lock, flags);
>   
>   	list_for_each_entry(desc, &flist, list) {
> -		u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
> -
>   		/*
>   		 * Check against the original status as ABORT is software defined
>   		 * and 0xff, which DSA_COMP_STATUS_MASK can mask out.
>
> base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d