Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210730235304.3179882-1-rajatja@google.com> <YQgKIok9DOTgmyvw@lahna>
In-Reply-To: <YQgKIok9DOTgmyvw@lahna>
Reply-To: rajatxjain@gmail.com
From:   Rajat Jain <rajatxjain@gmail.com>
Date:   Mon, 2 Aug 2021 11:49:44 -0700
Message-ID: <CAA93t1pR4_-H0pPa0xeVa2b7xv995Q37hGAFNCQ4y2vWyRN23g@mail.gmail.com>
Subject: Re: [PATCH v3] thunderbolt: For dev authorization changes, include
 the actual event in udev change notification
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     Rajat Jain <rajatja@google.com>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        linux-usb@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg KH <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 2, 2021 at 8:07 AM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> Hi Rajat,
>
> On Fri, Jul 30, 2021 at 04:53:04PM -0700, Rajat Jain wrote:
> > For security, we would like to monitor and track when the thunderbolt
> > devices are authorized and deauthorized (i.e. when the thunderbolt sysfs
> > "authorized" attribute changes). Currently the userspace gets a udev
> > change notification when there is a change, but the state may have
> > changed (again) by the time we look at the authorized attribute in
> > sysfs. So an authorization event may go unnoticed. Thus make it easier
> > by informing the actual change (new value of authorized attribute) in
> > the udev change notification.
> >
> > The change is included as a key value "authorized=<val>" where <val>
> > is the new value of sysfs attribute "authorized", and is described at
> > Documentation/ABI/testing/sysfs-bus-thunderbolt under
> > /sys/bus/thunderbolt/devices/.../authorized
> >
> > Signed-off-by: Rajat Jain <rajatja@google.com>
>
> I did some tiny changes to the title, commit message and the comment and
> applied to thunderbolt.git/next, thanks!

Thank you!

Rajat