Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Aug 2021 21:16:14 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Mason Zhang <mason.zhang@mediatek.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        leilk.liu@mediatek.com, wsd_upstream@mediatek.com
Subject: Re: [PATCH 2/3] spi: modify set_cs_timing parameter
Message-ID: <20210802201614.GA39900@sirena.org.uk>
References: <20210719091642.24633-1-mason.zhang@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn"
Content-Disposition: inline
In-Reply-To: <20210719091642.24633-1-mason.zhang@mediatek.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 19, 2021 at 05:16:43PM +0800, Mason Zhang wrote:
> From: Mason Zhang <Mason.Zhang@mediatek.com>
>=20
> No need pass in spi_delay to set_cs_timing callback.

This breaks the build:

/mnt/kernel/drivers/spi/spi-tegra114.c: In function 'tegra_spi_probe':
/mnt/kernel/drivers/spi/spi-tegra114.c:1328:24: error: assignment to 'int (=
*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi=
_device *, struct spi_delay *, struct spi_delay *, struct spi_delay *)' [-W=
error=3Dincompatible-pointer-types]
  master->set_cs_timing =3D tegra_spi_set_hw_cs_timing;
                        ^

--bp/iNruPH9dso1Pn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEIUo0ACgkQJNaLcl1U
h9A9nAf9F1Go1sfPbVr4y4p+ywDUg5Wsr+MKi1rOBL4AbcQ1yxaoPt+Hy9u9SMos
0LRfPt0j7LOGZr7vifhjc3oUF1RlB9y6gUMBcLiim6+4pbUz+Tajw2porzvSiK94
MvdhImTpbS8LPsEKwhXkpogz2uBiOMzmIlGHJL/k2gsewC1xGlXmdORTM+UBfr9Q
EXPNo9RPLAJP4WGoHjenHIQ7iixQnoLHnikVJtzET2heloGFaTdm0XUL2KUSE7s8
vOe18JfW8HRf19mr0CNVp4cKg4jE1gQEzXS7s64laov5hmoaFpf6eXVDFX7F0/u+
EVjpgvgR5/Yb/J/BntGxYQQyaGxUHA==
=rKDf
-----END PGP SIGNATURE-----

--bp/iNruPH9dso1Pn--