Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Arnd Bergmann <arnd@kernel.org>
CC:     Simon Horman <simon.horman@corigine.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
        Ivan Vecera <ivecera@redhat.com>,
        Parav Pandit <parav@nvidia.com>,
        Networking <netdev@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "oss-drivers@corigine.com" <oss-drivers@corigine.com>
Subject: Re: [PATCH] switchdev: add Kconfig dependencies for bridge
Thread-Topic: [PATCH] switchdev: add Kconfig dependencies for bridge
Thread-Index: AQHXh61yQBka7eM/OUS0Ww/tlViNv6tgZe6AgAAjW4CAAAnwgIAADhEAgAAHHIA=
Date:   Mon, 2 Aug 2021 20:20:47 +0000
Message-ID: <20210802202047.sqc6yef75dcoowuc@skbuf>
References: <20210802144813.1152762-1-arnd@kernel.org>
 <20210802162250.GA12345@corigine.com>
 <CAK8P3a0R1wvqNE=tGAZt0GPTZFQVw=0Y3AX0WCK4hMWewBc2qA@mail.gmail.com>
 <20210802190459.ruhfa23xcoqg2vj6@skbuf>
 <CAK8P3a1sT+bJitQH6B5=+bnKzn-LMJX1LnQtGTBptuDG-co94g@mail.gmail.com>
In-Reply-To: <CAK8P3a1sT+bJitQH6B5=+bnKzn-LMJX1LnQtGTBptuDG-co94g@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5/XCrQGuRjZwNXw17mPky6Hhi3EMlZ24q4/Kx8Zv7KQQi6x+XtSpOcA+s0Xp?=
 =?us-ascii?Q?TQ9tIADsjqbazf71nMn5gbbDDMkuyWqpfxbB2JKY/9NyMEpODd9eEM7DdUmD?=
 =?us-ascii?Q?HXZWh6SDvhi6rkdVkGro2HtWMFFESLe1U3znPPhtoyosArgi71DiueB80/1r?=
 =?us-ascii?Q?DdyO/jeRI+s73op1M23LGn26gJdXCmDurU0U74CtSoh1pFtjuRet3kLUVKi+?=
 =?us-ascii?Q?qCueUWqeKp+3MScBlYO6Ogxk8apfwQxhtlbMpBa8+npBlGMx7Go99irZd5bh?=
 =?us-ascii?Q?MMYpQTn3X3+n9/WPDb3qO9Oygy8fSkv6L1nBVvUJC90ftkEqeRsrIHEZzWki?=
 =?us-ascii?Q?mkGKnN5+9q0IP+apyWZsscUZ7d3P7U49FFJN/ANCBcWvpVwdGUCjAoZexz82?=
 =?us-ascii?Q?He0I4ccC46dHz9aIAkiYkBxVUM0rir6MTuXI7PJK8m2WY9XkC++rNeV5GYSS?=
 =?us-ascii?Q?M5RK4/QxnHshctNdM/XLCxRmm0OjH78s1OZVrvFFT/D2M2vpKLeZUpYSEsWG?=
 =?us-ascii?Q?vqPnzZt/IR8ESbzMOz51s6Vfi5AqtG9mtvIFk4nlLhU00AHtswuXBt188n6U?=
 =?us-ascii?Q?racY2rF7P86OVTTVjGoX1p7iRqer1/wzdGXtxPFK5fQsI5cFth3f4J0U5UDK?=
 =?us-ascii?Q?qE4GeYzZQEbkzJ5rUduSkuE7gm9iAjP9q5U7rxir9NL3qd5nawhUFAqKqW5M?=
 =?us-ascii?Q?xVrzlqNy+gbiGVe7VgsSHjnjZC6Evoki1W7Dmyz+Lp01BxfnAoyDdFqe4eUk?=
 =?us-ascii?Q?7Y2t6TngKcsCYs4S3VptYu3bX2W1PSAzmcYWHnhLOijvKecS3exrFDIdMPye?=
 =?us-ascii?Q?t7Y1ZyLrOfyegWESi6jX9IAGsRK+rBX4r71tXXkmtRJTD/OTfIs7EQgsOCRa?=
 =?us-ascii?Q?b4UFt2LbYJaZNP/mT21dDZjk5JGpGPmmY6YDh/y91Ehsb9TZdPmp0HC3OzfW?=
 =?us-ascii?Q?D25HJ6YB+nwv57G/1Q7vfbLIdW/9qHWWaZSqCkWz2lf09bI1ykPQ9LKL5WQ3?=
 =?us-ascii?Q?lsvQlUyoCQ9/E9UfmTbkbKa8QHAjqtw/gJjvU9kKw9eDRtksG4/Zx6ZcnzW4?=
 =?us-ascii?Q?LGdJBTvGV0+DRO8qGenpncSvyM4XzEwHppj6UlYS2yxkL7MEQbAfZq5Mhbha?=
 =?us-ascii?Q?8otYk/d0AgSpvIvkUxZunV8uww04YqKQG4mMZ6hhEsm70Ffxx3elQLGybTAI?=
 =?us-ascii?Q?skQrQiODcaWrtmCGZyTmiIPaMn7F7nfLEPlMiHKVtNp3z3b5me28qvRQCWCq?=
 =?us-ascii?Q?X3J0LPbLdGL2KNWZ0rG2Lavs2OOAy/2056qxT4xgysnMyrS7+8LaNfeSRPio?=
 =?us-ascii?Q?pyRgPP/T0mOpzMIdM4HlO8r9?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <66D7CD25520E78469E6616D59F8EDEDA@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 149df573-17c7-41c2-c881-08d955f303db
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2021 20:20:47.8176
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UvfZB1CQnbwGZ7GuEszncas3KoqIQYV7myf/+3NgMlT9agBfCx2dhY91h2x7sS0th/TjKhotDP8B5z1vdixtqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7119
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 02, 2021 at 09:55:20PM +0200, Arnd Bergmann wrote:
> On Mon, Aug 2, 2021 at 9:05 PM Vladimir Oltean <vladimir.oltean@nxp.com> =
wrote:
> >
> > On Mon, Aug 02, 2021 at 08:29:25PM +0200, Arnd Bergmann wrote:
> > > If this looks correct to you, I can submit it as a standalone patch.
> >
> > I think it's easiest I just ask you to provide a .config that triggers
> > actual build failures and we can go from there.
>=20
> This one is with an arm64 allmodconfig, plus
>=20
> CONFIG_PTP_1588_CLOCK=3Dy
> CONFIG_TI_K3_AM65_CPTS=3Dy
> CONFIG_TI_K3_AM65_CPSW_NUSS=3Dy

Yeah, ok, I remember now, I saw that TI_CPSW_SWITCHDEV is tristate, and
incorrectly thought that TI_K3_AM65_CPSW_SWITCHDEV (which is mostly a
copy-paste job of the main cpsw anyway, makes you cringe that they wrote
a separate driver for it) is tristate too.

The options are either to make TI_K3_AM65_CPSW_SWITCHDEV tristate like
TI_CPSW_SWITCHDEV is, and to edit the Makefile accordingly to make
am65-cpsw-switchdev.o part of obj-$(CONFIG_TI_K3_AM65_CPSW_SWITCHDEV),
or to extend the BRIDGE || BRIDGE=3Dn dependency to TI_K3_AM65_CPSW_NUSS
which is the direct tristate dependency of CONFIG_TI_K3_AM65_CPSW_SWITCHDEV=
,
and to make CONFIG_TI_K3_AM65_CPSW_SWITCHDEV simply depend on BRIDGE.=