Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1908634pxy;
        Mon, 2 Aug 2021 13:34:34 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzjrkOuuRTQYc+MW97AGC8WAZynURZqobHdq+W+czsKwYdawEBiEaFdKKnh+TktlwQIBUGK
X-Received: by 2002:a17:906:3699:: with SMTP id a25mr16935616ejc.452.1627936474226;
        Mon, 02 Aug 2021 13:34:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1627936474; cv=none;
        d=google.com; s=arc-20160816;
        b=RKattysMUsA5zP6ynuRlY2+nehTQXUZixqS0zWOLu2dEoQQGoExOFsUF3yys6s3nOr
         1I8F2HDpcz1YlqyTXKr68TcyjWT7Yjq2vn8G35iI1JSP4mR+c79CsSkIqSPHOR9uEUFq
         +QlkiJRU8qSGQVO4b0Nh1CW3FF+rKO2hlcFXyEWu17b+wPLj8mT5Bk80V6k7bY0Kny4W
         zj6DCQIoX8ra/T/nEBli1zONYpYmCqArO/berzfF2XQ2Db/fM16nkekhLDukeXq7lx2E
         NYvll+gBdEP49v2AWv66I3jPb87xk3agcC5/8suddqzvi9Di9TuSZ8EWUKvMhC2o11Dl
         gOjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=ffeYCENxQ4KsG6r4BpGQVZmx9seSJ5/kQeF4B+BbZmk=;
        b=PiaPYMSW9gXbTu2IjEMEKGGN4nq5qcH5T8fox8aCKauZ4G31JGExsqb5t96/VUNFCx
         40VeRpaYKP8l7p8Ul3t5Bxdsnu9+ytmaZvHPkDQZPpg7d0ba3iwZ7Ht6WK5xKZx/KnRB
         I5kqu9k9tfgKzzb642Y9jVtkB60Kx1RGSTPj8MK5HSUhojkQ2P0ut0eK6n4XTbCOZiBO
         gs3+BrFrJmb2sO1deJIKvGdqCskg0dZdVMLMoY1bUnEebX2wuDk0RT+9R7aEUDXDJ+/P
         26/Qm2P2BBJzvi9mdpmCmp2+8mYa4jru8fDlPyLs+dA0dLdZYrpZLp8vWWa0XTqV5H1J
         kImA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cA3Zk9hk;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id nc1si10512793ejc.377.2021.08.02.13.34.10;
        Mon, 02 Aug 2021 13:34:34 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cA3Zk9hk;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230448AbhHBUcp (ORCPT <rfc822;liq3ea@gmail.com> + 99 others);
        Mon, 2 Aug 2021 16:32:45 -0400
Received: from mail.kernel.org ([198.145.29.99]:56280 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229729AbhHBUcm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Aug 2021 16:32:42 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 16F4160D07;
        Mon,  2 Aug 2021 20:32:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1627936352;
        bh=7Omv5X3Y5yxWtYvKeuj6gzKo2AOy6KsbmDol1EN2zbA=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=cA3Zk9hkCToaUg0zm9Es4aHNDzwrtmj0F9dFDoYejpNrAZL6G4EcwcrDmhLK1ym1w
         kEhalschuUFLdwQqZsTV6EIVz4NVF93syTVMxY5/lb5JZAwSdazHKqcdSsKJ/HGEZf
         /69fKF19AEWyyMpxb7catLPAuqgJwXnS7O7fRk8+m8p9iOwrih7A1fSdqNtgqJ6Xfv
         POAbG8c5k//sbYcTgXZBPKMHZ4jHpr0FHXDdINNJX8WgsrBdE1fT/YIRekkhe1jev+
         Jl4Pg0c7GvnlhakMGitXFndsnWXg9tUd8/iUewyak873rUXmP179OSFh/gSPsD24Se
         3JDssKIJ0X19A==
Date:   Mon, 2 Aug 2021 13:32:30 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Joakim Zhang <qiangqing.zhang@nxp.com>
Cc:     davem@davemloft.net, andrew@lunn.ch, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work
Message-ID: <20210802133230.1a17ac4c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210730114709.12385-1-qiangqing.zhang@nxp.com>
References: <20210730114709.12385-1-qiangqing.zhang@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 30 Jul 2021 19:47:09 +0800 Joakim Zhang wrote:
> @@ -3806,6 +3827,10 @@ fec_probe(struct platform_device *pdev)
>  		fep->phy_interface = interface;
>  	}
>  
> +	ret = fec_enet_parse_rgmii_delay(fep, np);
> +	if (ret)
> +		goto failed_phy;

You're jumping to the wrong label, it looks like phy_node needs to be
released at this point.