Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Aug 2021 13:41:41 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Charan Teja Kalla <charante@codeaurora.org>
Cc:     Mike Rapoport <rppt@kernel.org>, mcgrof@kernel.org,
        keescook@chromium.org, yzaikin@google.com,
        dave.hansen@linux.intel.com, vbabka@suse.cz,
        mgorman@techsingularity.net, nigupta@nvidia.com, corbet@lwn.net,
        khalid.aziz@oracle.com, rientjes@google.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
        vinmenon@codeaurora.org
Subject: Re: [PATCH V5] mm: compaction: support triggering of proactive
 compaction by user
Message-Id: <20210802134141.dbff2d5f850bbe84f3bef4d5@linux-foundation.org>
In-Reply-To: <1089d373-221e-7094-b778-ac260ca139a5@codeaurora.org>
References: <1627653207-12317-1-git-send-email-charante@codeaurora.org>
        <YQRTqNF3xn+tB+qN@kernel.org>
        <1089d373-221e-7094-b778-ac260ca139a5@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2 Aug 2021 17:30:16 +0530 Charan Teja Kalla <charante@codeaurora.org> wrote:

> Thanks Mike for the review!!
> 
> On 7/31/2021 1:01 AM, Mike Rapoport wrote:
> >> diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst
> >> index 003d5cc..b526cf6 100644
> >> --- a/Documentation/admin-guide/sysctl/vm.rst
> >> +++ b/Documentation/admin-guide/sysctl/vm.rst
> >> @@ -118,7 +118,8 @@ compaction_proactiveness
> >>  
> >>  This tunable takes a value in the range [0, 100] with a default value of
> >>  20. This tunable determines how aggressively compaction is done in the
> >> -background. Setting it to 0 disables proactive compaction.
> >> +background. On write of non zero value to this tunable will immediately
> > Nit: I think "Write of non zero ..."
> 
> Can Andrew change it while applying the patch ?

I have done so, thanks.