Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210802174139.1908760-1-ramjiyani@google.com> <CAHRSSEzUcSpWxQzjhGoDsk3uTm=anFri2jHVKDoLrCXVY8i0WA@mail.gmail.com>
In-Reply-To: <CAHRSSEzUcSpWxQzjhGoDsk3uTm=anFri2jHVKDoLrCXVY8i0WA@mail.gmail.com>
From:   Ramji Jiyani <ramjiyani@google.com>
Date:   Mon, 2 Aug 2021 15:08:51 -0700
Message-ID: <CAKUd0B_Dx8E8CyuWoFYTVJLVTLoa0ay9Gtuo=92foUany8QZrg@mail.gmail.com>
Subject: Re: [PATCH] binder: Add invalid handle info in user error log
To:     Todd Kjos <tkjos@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Todd Kjos <tkjos@android.com>,
        Martijn Coenen <maco@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Christian Brauner <christian@brauner.io>,
        Hridya Valsaraju <hridya@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        kernel-team@android.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 2, 2021 at 11:22 AM Todd Kjos <tkjos@google.com> wrote:
>
> On Mon, Aug 2, 2021 at 10:41 AM 'Ramji Jiyani' via kernel-team
> <kernel-team@android.com> wrote:
> >
> > In case of a fail transaction to the target node; user error log currently
>
> nit: I'd rephrase this to something like  "In the case of a failed
> transaction, only the thread and process id are logged. Add the handle
> info..."

Thanks for the review. Submitted v2 with the fix.

>
> > only prints the thread and process id. Add handle info for the reference
> > to the target node in user error log to aid debugging.
> >
> > Signed-off-by: Ramji Jiyani <ramjiyani@google.com>
>
> Acked-by: Todd Kjos <tkjos@google.com>

Thanks for the Ack.

>
> > ---
> >  drivers/android/binder.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> > index bcec598b89f2..d9030cb6b1e4 100644
> > --- a/drivers/android/binder.c
> > +++ b/drivers/android/binder.c
> > @@ -2547,8 +2547,8 @@ static void binder_transaction(struct binder_proc *proc,
> >                                                 ref->node, &target_proc,
> >                                                 &return_error);
> >                         } else {
> > -                               binder_user_error("%d:%d got transaction to invalid handle\n",
> > -                                                 proc->pid, thread->pid);
> > +                               binder_user_error("%d:%d got transaction to invalid handle, %u\n",
> > +                                                 proc->pid, thread->pid, tr->target.handle);
> >                                 return_error = BR_FAILED_REPLY;
> >                         }
> >                         binder_proc_unlock(proc);
> > --
> > 2.32.0.554.ge1b32706d8-goog
> >
> > --
> > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
> >