Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1627927742-8675-1-git-send-email-raagjadav@gmail.com>
In-Reply-To: <1627927742-8675-1-git-send-email-raagjadav@gmail.com>
From:   Li Yang <leoyang.li@nxp.com>
Date:   Mon, 2 Aug 2021 17:44:29 -0500
Message-ID: <CADRPPNQ2M1N1pV2brfFRXOf1ASK2bhiZpQivNhNws_+RUfCT-g@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: ls1046a: fix eeprom entries
To:     Raag Jadav <raagjadav@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 2, 2021 at 1:10 PM Raag Jadav <raagjadav@gmail.com> wrote:
>
> ls1046afrwy and ls1046ardb boards have CAT24C04[1] and CAT24C05[2]
> eeproms respectively. Both are 4Kb (512 bytes) in size.

These part names are from onsemi instead of atmel.  Are there same
part names from atmel which are also compatible with the onsemi parts?
 If we want to use onsemi only part names, probably we will need two
compatible strings with the first one from onsemi and the second from
atmel.  Although the binding doesn't support onsemi prefix yet.

> Remove multi-address entries, as we have auto-rollover support
> in at24 driver.

The device tree should describe hardware instead of matching how
driver deal with it.  Is the board really using a single chip or
multiple chips here?

>
> [1] https://www.onsemi.com/pdf/datasheet/cat24c01-d.pdf
> [2] https://www.onsemi.com/pdf/datasheet/cat24c03-d.pdf
>
> Signed-off-by: Raag Jadav <raagjadav@gmail.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts | 8 +-------
>  arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts  | 7 +------
>  2 files changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> index db3d303..83afe21 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-frwy.dts
> @@ -83,15 +83,9 @@
>                         };
>
>                         eeprom@52 {
> -                               compatible = "atmel,24c512";
> +                               compatible = "atmel,24c04";
>                                 reg = <0x52>;
>                         };
> -
> -                       eeprom@53 {
> -                               compatible = "atmel,24c512";
> -                               reg = <0x53>;
> -                       };
> -
>                 };
>         };
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> index 60acdf0..d220f98 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts
> @@ -59,14 +59,9 @@
>         };
>
>         eeprom@52 {
> -               compatible = "atmel,24c512";
> +               compatible = "atmel,24c04";
>                 reg = <0x52>;
>         };
> -
> -       eeprom@53 {
> -               compatible = "atmel,24c512";
> -               reg = <0x53>;
> -       };
>  };
>
>  &i2c3 {
> --
> 2.7.4
>