Content-class: urn:content-classes:message
MIME-Version: 1.0
Subject: RE: [PATCH 2/3] x86: remove duplicated parser for "pci=noacpi"
Date: Mon, 27 Nov 2006 13:46:52 -0800
Message-ID: <5986589C150B2F49A46483AC44C7BCA4907241@ssvlexmb2.amd.com>
Thread-Topic: [PATCH 2/3] x86: remove duplicated parser for "pci=noacpi"
Thread-Index: AccRukkdBp41KfC3TO2ya/BJ4Ka9dQAseIFA
From: "Lu, Yinghai" <yinghai.lu@amd.com>
To: "Andi Kleen" <ak@muc.de>
cc: "Andrew Morton" <akpm@osdl.org>,
       "Eric W. Biederman" <ebiederm@xmission.com>,
       linux-kernel@vger.kernel.org, "Greg KH" <gregkh@suse.de>,
       "Len Brown" <len.brown@intel.com>
Content-Type: text/plain;
 charset=us-ascii
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 830
Lines: 27


-----Original Message-----
From: Andi Kleen [mailto:ak@muc.de] 
Sent: Sunday, November 26, 2006 4:22 PM

>Are you sure it's correct? The drivers/pci pci= parsing
>isn't early and there tend to be nasty ordering issues.
>I can't see where it would go wrong here, but it probably
>needs very careful double checking.

I double check that, we don't need the parser in
arch/i386/kernel/acpi/boot.c for 
pci=noapci.

Actually, pcibios_setup in arch/i386/kernel/pci/common.c that process
pci=noacpi will be
called by pci_setup in drivers/pci/pci.c, and 
early_param("pci", pci_setup);

YH


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/