Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] trace: eradicate noisy warning in trace_osnoise.c
To:     Daniel Bristot de Oliveira <bristot@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
        Ingo Molnar <mingo@redhat.com>
References: <20210731000055.28876-1-rdunlap@infradead.org>
 <20210730204050.46975ae2@oasis.local.home>
 <d4fdf5f0-ba3b-1260-b320-3045f218e6a6@infradead.org>
 <f8d3b5d4-a539-8f47-eeb4-39b055f131e3@redhat.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <eb82accb-442f-7d93-65f1-a6c34b9a4431@infradead.org>
Date:   Mon, 2 Aug 2021 21:12:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <f8d3b5d4-a539-8f47-eeb4-39b055f131e3@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/2/21 12:58 AM, Daniel Bristot de Oliveira wrote:
> On 7/31/21 3:11 AM, Randy Dunlap wrote:
>> On 7/30/21 5:40 PM, Steven Rostedt wrote:
>>> On Fri, 30 Jul 2021 17:00:55 -0700
>>> Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>>> OK, I'm officially tired of this noise warning coming from
>>>> trace_osnoise.c, so shut it up. Also, adding new warnings is not OK.
>>> I agree adding "new warnings" is not OK, but this is a stupid warning.
>>>
>>>> ../kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
>>>> ../kernel/trace/trace_osnoise.c:1461:8: warning: ‘main’ is usually a function [-Wmain]
>>>>    void *main = osnoise_main;
>>>>          ^~~~
>>>>
>>>> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
>>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>>> Suggested-by: Matthew Wilcox <willy@infradead.org>
>>>> Cc: Steven Rostedt <rostedt@goodmis.org>
>>>> Cc: Ingo Molnar <mingo@redhat.com>
>>>> Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
>>>> ---
>>>>   kernel/trace/Makefile |    2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> --- mmotm-2021-0728-1824.orig/kernel/trace/Makefile
>>>> +++ mmotm-2021-0728-1824/kernel/trace/Makefile
>>>> @@ -36,6 +36,8 @@ CFLAGS_bpf_trace.o := -I$(src)
>>>>   CFLAGS_trace_benchmark.o := -I$(src)
>>>>   CFLAGS_trace_events_filter.o := -I$(src)
>>>>   
>>>> +CFLAGS_trace_osnoise.o := -Wno-main
>>> Why just add it here. It's a silly warning to have for the kernel at
>>> all. Should this not be added in a more global place?
>> I don't know of any other places that name something 'main' when it is
>> not a main() function.
>>
> 
> I would say that we either use -Wno-main for the entire kernel or rename the
> main variable to tracer_main....

I'm OK with the latter...

thanks.