Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 03 Aug 2021 09:40:50 +0200
Message-ID: <s5hsfzrvuv1.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Salah Triki <salah.triki@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Pavel Skripkin <paskripkin@gmail.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Mark Brown <broonie@kernel.org>, Joe Perches <joe@perches.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: usb: get lock before calling  usb_enable_autosuspend()
In-Reply-To: <20210802225339.GA1461793@pc>
References: <20210802225339.GA1461793@pc>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 03 Aug 2021 00:53:39 +0200,
Salah Triki wrote:
> 
> Based on the documentation of usb_enable_autosuspend(), the
> caller must hold udev's device lock.

The device lock is already held in the caller side (in the driver
core), hence this change will lead to a deadlock.


thanks,

Takashi

> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
>  sound/usb/card.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/usb/card.c b/sound/usb/card.c
> index 2f6a62416c05..9290ba0acd5f 100644
> --- a/sound/usb/card.c
> +++ b/sound/usb/card.c
> @@ -907,8 +907,13 @@ static void usb_audio_disconnect(struct usb_interface *intf)
>  		}
>  	}
>  
> -	if (chip->quirk_type & QUIRK_SETUP_DISABLE_AUTOSUSPEND)
> -		usb_enable_autosuspend(interface_to_usbdev(intf));
> +	if (chip->quirk_type & QUIRK_SETUP_DISABLE_AUTOSUSPEND) {
> +		struct usb_device *udev = interface_to_usbdev(intf);
> +
> +		usb_lock_device(udev);
> +		usb_enable_autosuspend(udev);
> +		usb_unlock_device(udev);
> +	}
>  
>  	chip->num_interfaces--;
>  	if (chip->num_interfaces <= 0) {
> -- 
> 2.25.1
>