To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
       Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@redhat.com>,
       Greg Kroah-Hartman <gregkh@suse.de>,
       Thomas Gleixner <tglx@linutronix.de>, Tom Zanussi <zanussi@us.ibm.com>,
       Karim Yaghmour <karim@opersys.com>, Paul Mundt <lethal@linux-sh.org>,
       Jes Sorensen <jes@sgi.com>, Richard J Moore <richardj_moore@uk.ibm.com>,
       "Martin J. Bligh" <mbligh@mbligh.org>,
       Michel Dagenais <michel.dagenais@polymtl.ca>,
       Douglas Niehaus <niehaus@eecs.ku.edu>, ltt-dev@shafik.org,
       systemtap@sources.redhat.com
Subject: Re: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers
References: <20061124215401.GD25048@Krystal>
From: fche@redhat.com (Frank Ch. Eigler)
Date: 27 Nov 2006 21:23:17 -0500
In-Reply-To: <20061124215401.GD25048@Krystal>
Message-ID: <y0mu00kpawa.fsf@ton.toronto.redhat.com>
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 980
Lines: 27

Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> writes:

> This patch adds the Linux Kernel Markers [...]
> Signed-off-by : Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

If it helps,
Acked-by: Frank Ch. Eigler <fche@redhat.com>


One question:

> [...]
> +	/* Markers in modules. */ 
> +	list_for_each_entry(mod, &modules, list) {
> +		if (mod->license_gplok)
> +			found += marker_set_probe_range(name, format, probe,
> +				mod->markers, mod->markers+mod->num_markers);
> +	}
> [...]
> +EXPORT_SYMBOL(marker_set_probe);

Are you sure the license_gplok check is necessary here?  We should
consider encouraging non-gpl module writers to instrument their code,
to give users a slightly better chance of debugging problems.


- FChE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/