Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp2320051pxy; Tue, 3 Aug 2021 03:33:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFvNL7mAP8EViANzIDiUmM9pZIGS8sIanhipN0zhWsTO5PSwxFwp0jHfTtxsT2LEHG540O X-Received: by 2002:a05:6402:5:: with SMTP id d5mr24407342edu.359.1627986836063; Tue, 03 Aug 2021 03:33:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627986836; cv=none; d=google.com; s=arc-20160816; b=LYk5briqpKFrevfhbQ+BY+23c347gwOxx4QWkc1jbCU8yclvUGb0+ggqUBcCkFiXzf LqNRhWuHqnTtmwuwA0eCaNPTY2BcZCVmOr0XC3QjOE2tJ1Az9WPqg5kBPK0MrQdM7Tyq ct1uggvwEsNV4TmPhA49BafeOkh5zax4WsZc9SGGOk2TfYiHWnO8PU01OQboP7LfuIJy NQtzoKHfSDJlaZctxdhFbWw7RkK3Ff3QNHkba/cWzb/PIfTeazZoRj2iPFCBC/KTTAkP W8G8a3X32uGiUzQsvKLfhgTjXFCLk4ok3+QFNrcRfQ2rcbipG/lDArmIMK4jciYmb7fZ 568g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=3psQaSG4d8w1oQM2avr7nhWCNx0TL7drom5fez4dSiA=; b=IR2e2qzUGvgxR4WdG6Xv+gitoJKLjLtU0/ym2JRqYN9s38OOzcrpPz5pJEQYhHDWY6 I2Fy2O1nUjkOhIoBM6WiYh/+YzqoMVKkUYDxGDl01quhRC1tI5hEOsK5yCWVStQbg+xj zv0i+nKT5tRb9Sa9KKl3ZcFjTSrrn25YwsVx/TTd4lTuazq8q2dolw0HylwesEUqzAji zlKHoW4/3P6j2zzGaVoIU4lqV8gcujQ1dq/ZZtrqKhmipNGu13CMjXIWZWWAVGOjbnLH CAvRWXsv630xYqWZuXtlULMaGtf14gaqCl4Efkl7edY5N8S3606gKR5SqCrjgQeRfrmS 7zzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fIfnWsy3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nc19si1979012ejc.426.2021.08.03.03.33.29; Tue, 03 Aug 2021 03:33:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fIfnWsy3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234998AbhHCKaR (ORCPT + 99 others); Tue, 3 Aug 2021 06:30:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234674AbhHCKaQ (ORCPT ); Tue, 3 Aug 2021 06:30:16 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF1DDC06175F; Tue, 3 Aug 2021 03:30:04 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so9573904oth.7; Tue, 03 Aug 2021 03:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3psQaSG4d8w1oQM2avr7nhWCNx0TL7drom5fez4dSiA=; b=fIfnWsy3hsqYB+PJtAaqeFHZ2boRJZ5sjE/ghiWyO7OXl3t78XlU35QhG2nOjwQw/S T7GmDRZ9VA+QBgDBuBGktWIhdhlZU8y/L4vnzPvwpyJfP4jT9GsTk1bJhUoQjO2c6NLu HX6d8qiCRup83YWKzbWwfLsVoqRsP3ZTk6VBn3fR3uiseGmyP+OlSPXL+47EemdkSDdM usvB9EZlI95pRRVWj3+FoE4evyPoPANbEC70Jg9DBHDX6StbDfi1PDfclEB0yVuAvc/K Tg5ZXW9ac+ngp/hGny7Jqnxc8UjtB6gF0XmpE9FgEk3z9BNDT3QlXlayKxRlxiQsav/R Swag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3psQaSG4d8w1oQM2avr7nhWCNx0TL7drom5fez4dSiA=; b=rHa63ZLhkE4rMGLDF2yH0xOjOD55/ys5OxFg/pC6onOp2gNmTdyIOX2A8Ga6dfpXvL IjUvyb6Dn/V0mQoJRVHcs3Ghd33FO7NvP4KdFxIDrv43enjPXSrexvsTyaqai+dFYBBN 1Bl2VERDrYfX6uZJt4b6/p3o/Dbnd8VNtydtOEbP6fZ68TbYZWJ/eBIZa9NjrWCtklse UoAE90ciuxGY9+kbWQhdXn7I7zEu2ElTZOTPDTLRWjYe1MNZIReHA8RZEi09mH+GXvhF bMFpNqcL7ktlhFTjvcELp/l3eYkaCPTsewOplYaWCViSTzhQm+SDZnp/+4TAjaBby5T2 AK4w== X-Gm-Message-State: AOAM532EJNU9LeaEoa0EMCEsJv+OnnN/sR1mH1WLdf0vd8TI46vmJuGs GTkKXQlNaM9e0ZTd3jmo1JlEC/D207BipGn9q2U= X-Received: by 2002:a9d:27a4:: with SMTP id c33mr15305949otb.281.1627986604246; Tue, 03 Aug 2021 03:30:04 -0700 (PDT) MIME-Version: 1.0 References: <20210802121215.703023-1-eizan@chromium.org> In-Reply-To: <20210802121215.703023-1-eizan@chromium.org> From: Enric Balletbo Serra Date: Tue, 3 Aug 2021 12:29:52 +0200 Message-ID: Subject: Re: [PATCH v6 0/9] Refactor MTK MDP driver into core/components To: Eizan Miyamoto Cc: linux-kernel , Chen-Yu Tsai , Houlong Wei , Yong Wu , Enric Balletbo i Serra , devicetree , Chun-Kuang Hu , Andrew-CT Chen , Matthias Brugger , Mauro Carvalho Chehab , Minghsiu Tsai , Rob Herring , Linux ARM , Linux Media Mailing List , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, Missatge de Eizan Miyamoto del dia dl., 2 d=E2=80=99ag= . 2021 a les 14:12: > > > This is an update to > https://patchwork.kernel.org/project/linux-mediatek/list/?series=3D283075 > To address some comments and fixes. > > This series has been verified to work on 5.13. > The series have also been validated on top of 5.14-rc4 and linux-next on an Acer Chromebook R 13 without observing any problems and running some video decoding tests, so, for the full series. Tested-by: Enric Balletbo i Serra > > Changes in v6: > - Don't propagate errors from clock_on/off as an afterthought. > - Split apart modifying mdp driver to be loadable from mmsys from > actually loading it from mmsys into two changs to make review easier. > - Update devicetree bindings to reflect no longer needing the > mediatek,vpu property in the mdp_rdma0 device node. > - Some stylistic cleanups. > > Changes in v5: > - rebase and test on 5.13-next @ e2f74b13dbe6 > > Changes in v4: > - rebase and test on 5.13 > - don't depend on https://patchwork.kernel.org/project/linux-mediatek/lis= t/?series=3D464873 > > Changes in v3: > - get mdp master from aliases instead of strcmp against of_node->name > > Changes in v2: > - rebased onto Linux 5.12 > - 100 char line length allowance was utilized in a few places > - Removal of a redundant dev_err() print at the end of > mtk_mdp_comp_init() > - Instead of printing errors and ignoring them, I've added a patch to > correctly propagate them. > - Use of C style comments. > - Three additional patches were added to eliminate dependency on the > mediatek,vpu property inside the mdp_rdma0 device node. > > Eizan Miyamoto (9): > mtk-mdp: propagate errors from clock_on > mtk-mdp: add driver to probe mdp components > mtk-mdp: use pm_runtime in MDP component driver > media: mtk-mdp: don't pm_run_time_get/put for master comp in clock_on > mtk-mdp: make mdp driver to be loadable by platform_device_register*() > soc: mediatek: mmsys: instantiate mdp virtual device from mmsys > media: mtk-mdp: use mdp-rdma0 alias to point to MDP master > dts: mtk-mdp: remove mediatek,vpu property from primary MDP device > dt-bindings: mediatek: remove vpu requirement from mtk-mdp > > .../bindings/media/mediatek-mdp.txt | 3 - > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 - > drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 268 +++++++++++++++-- > drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 34 +-- > drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 282 ++++++++++++------ > drivers/media/platform/mtk-mdp/mtk_mdp_core.h | 3 + > drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 4 +- > drivers/soc/mediatek/mtk-mmsys.c | 20 +- > 8 files changed, 470 insertions(+), 145 deletions(-) > > -- > 2.32.0.554.ge1b32706d8-goog >