Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] xen: rename wrong named pfn related variables
To:     Juergen Gross <jgross@suse.com>
CC:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, x86@kernel.org
References: <20210616073007.5215-1-jgross@suse.com>
 <20210616073007.5215-3-jgross@suse.com>
 <8dbeb9ea-56c9-de30-4d5f-fc9c0ced6ac4@suse.com>
 <79434ec4-4543-97ad-b010-3f2c1b6a55ad@suse.com>
 <b9c64bcd-4192-0075-ddf5-711e84301063@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
Message-ID: <94d629fd-27e2-f2be-ed26-c3e04e95c5b4@suse.com>
Date:   Tue, 3 Aug 2021 12:42:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <b9c64bcd-4192-0075-ddf5-711e84301063@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.156.60.236] (37.24.206.209) by PR2PR09CA0019.eurprd09.prod.outlook.com (2603:10a6:101:16::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Tue, 3 Aug 2021 10:42:34 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dfc0995f-998d-49d9-949a-08d9566b67b1
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB28295A4568E4C692BECE2F2BB3F09@VI1PR0402MB2829.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PmCxdNryIsX0vr8BQHusl8I7ssAdVmulsuse7dQY8ajnyTUmrgyrKnzPmDiiIb/4Z+CDmMSCZuSTts7yKxrNV4z5mTbDgCWDIKuWRqVk01oF0mTc+CegiXcPQ+ZxK04sZuO+k8E2R1dlUkTZzojfxyGJMkec9W47kY9a2F5Mor7KfmKSSzd8KhlCBbfpuTvNMTwOMwSlZVNe4ILrwZUpvZ+RA5BDdDefnziSosAMuFceM6rpwtokn/j7tjFPIUkVCXg3wrv+KxFB5XSvtgIkaWsLspeFVn2HKZuTJsg+4mPZ5gdvVzdOQjeDEbfjA3/TtUfnW3eZsXq3W0ilBpwvdABVRM2Vs6DWslNxSKBOu6OWNhkH35r7EOm/Ut9eDlGNs8/Csl0SeRLWaTl+RKuRiTeuiufreY7Ubc6VX/dFEYaWtUf3HHoUaIcSO1kmHCjML7hGamn1PSlt3hrPCyLH5odHNwWaEl55lYhY86Vm+vkeRv7hpqRpf141FXsNQ8SYgUSexFk3quXi3tby6ZBnU4OHpC2KzyMA+8L8mknnYkaEBQINCmOzK2iVpXcVsnZPQBHOYbBvCYUtYFMHgsdZuajG/kpCgxHOrMdMzM7bhoog5diFQykY2Itj6cuPnW9oKLv03nw3dG06BSjun5loxu3iB+viWzHCd4F797M5TlAZEMdQsOnECEZWDRfakFzKakLBFqoCnTkvNxdo7MlqwTTG5wqUufAAMW23g08XdN0=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(346002)(376002)(136003)(396003)(478600001)(83380400001)(66476007)(37006003)(316002)(16576012)(36756003)(66946007)(53546011)(5660300002)(8676002)(31696002)(38100700002)(66556008)(86362001)(54906003)(8936002)(31686004)(2906002)(6486002)(26005)(6862004)(4326008)(6636002)(956004)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?j8t4LPYmuM+UA/XptHS0QuCgqBEf3m/LA+jBllUfEKaKDVX3cxC84TA05+gQ?=
 =?us-ascii?Q?hWFmdmDtzIH1lzw6y2ibwmG9l+cKNpvkR2vKvT3ANP3SJE0wv1tR8mLVnmNm?=
 =?us-ascii?Q?W1w+sm6bEq+gIOOn8S6X2PtVTtaPpV5KN5qxSU2eMsJUvwZFR1dxp/UgKEKE?=
 =?us-ascii?Q?XZEhaNa+eOjJNl4azExLP6UIxzP3xuP2YHGtXLEXCW4GRIgAO3973rjpDIVZ?=
 =?us-ascii?Q?YJx6neqz/GoxsXQgKb+0u5iZPrQ4n6JGSfp4lql7clIu2ugRIrzKFoLpnsvM?=
 =?us-ascii?Q?RjfZv8Ui3zX6VyHcjLyflD9/7y0DbCKQsgu+Y4jF1FZNKYhVpbQwMbAuMGei?=
 =?us-ascii?Q?pHqrXvXyCtI3utEMDXNDqPMGiYqCii81fglzuSFiG/DU2h4L2AQ8pEw8MYP3?=
 =?us-ascii?Q?HeN3/ws7yIt7Q6kKjogG54Xl/hWXNtGOUtdpDRav/DovrTlRPIIgLNLH9KU8?=
 =?us-ascii?Q?zRL+ziGFKR/h32Q4gNSm2KOA4iHFDo3oF0JKcML/OTZ3dgTc0B51v4udyQHY?=
 =?us-ascii?Q?fjYJ/EcgS+DmDuqK28swnRg+t2AVQM9aCCLArx2Y1x6HZsCCTdLrhm81t21O?=
 =?us-ascii?Q?IeBAV98BxM9PLRdfq8ikJGdx8W82JQ9c8HC6RylLTFqzGyymZlIYygZnmApH?=
 =?us-ascii?Q?14nMSms6K9Y7xF04KDKmC419um650vY7qJbjbDKe5cF936ZFVfamMszSI8mf?=
 =?us-ascii?Q?qYQYC4l7rSdEIPDN+CuERnMcfbYVBfs4odbEe9akNYhDGqtfqzACzrmJ7hkO?=
 =?us-ascii?Q?OblgPN89wdK49p5k6ZQs8JbWZ2cdNRjBiaZIngQuo9UBdz52rru7E0To1uRh?=
 =?us-ascii?Q?XBSRDG0UrRbF1K09sjS9gewyH727c6Dbg7lS2MQ5DvNXYnwkoNnM6ytzfMfU?=
 =?us-ascii?Q?3COes1bOJB2CEc35Dprd7A8XE9i8eFrTHTjJ96HhDOpMjYf/5mQMhcQFNXES?=
 =?us-ascii?Q?NGXYvA46Z06x8JQQFcrvd62ZiD9M5urjznnW2+jUKaSQRz/55YDj+Ier25sZ?=
 =?us-ascii?Q?BuuPRIEwB667KAsZufyAtafGXDQZcSVy7TwR67nDf5R3nGX+ohmjDvE6hc8j?=
 =?us-ascii?Q?sSFjBFQ6YI1NM5bqBI0AbG8644hbEWZQx18llsRae3t2Hw8y0t31UHlIaXWz?=
 =?us-ascii?Q?lySgSpcZyaVGJbFVX79yLTIAUk/mefEp1/PSkaSYiNThfD2rSS6hkWGXUvfH?=
 =?us-ascii?Q?uVnKoeq5Bz1maX88eEYjl+amggYzd2QOc4i1EM9ObH4p0q0ikfYwo0MB5C0T?=
 =?us-ascii?Q?B2m11AlkCaRjWinfgFL+rnZrXMRBCCwA3+GE0EFKx0O+p6pyprZRxOFU12/i?=
 =?us-ascii?Q?jJIb7Dpmok99378J+iRStOg8?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfc0995f-998d-49d9-949a-08d9566b67b1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2021 10:42:35.2365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F0e6H7pmWn2ZNpmsCif4akAejTQjlU6BV79PbrC3Va03NZ1v+8R7VbkZJnI3gCe2gNuttyBHfsxtmbzypvQqjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 30.07.2021 11:00, Juergen Gross wrote:
> On 16.06.21 12:43, Juergen Gross wrote:
>> On 16.06.21 11:56, Jan Beulich wrote:
>>> On 16.06.2021 09:30, Juergen Gross wrote:
>>>> --- a/arch/x86/xen/p2m.c
>>>> +++ b/arch/x86/xen/p2m.c
>>>> @@ -95,8 +95,8 @@ unsigned long *xen_p2m_addr __read_mostly;
>>>> =C2=A0 EXPORT_SYMBOL_GPL(xen_p2m_addr);
>>>> =C2=A0 unsigned long xen_p2m_size __read_mostly;
>>>> =C2=A0 EXPORT_SYMBOL_GPL(xen_p2m_size);
>>>> -unsigned long xen_max_p2m_pfn __read_mostly;
>>>> -EXPORT_SYMBOL_GPL(xen_max_p2m_pfn);
>>>> +unsigned long xen_p2m_max_size __read_mostly;
>>>> +EXPORT_SYMBOL_GPL(xen_p2m_max_size);
>>>
>>> Instead of renaming the exported variable (which will break consumers
>>> anyway), how about dropping the apparently unneeded export at this
>>> occasion?
>>
>> Why do you think it isn't needed? It is being referenced via the inline
>> function __pfn_to_mfn() in arch/x86/include/asm/xen/page.h. And
>> __pfn_to_mfn() is used via lots of other inline functions and macros.
>>
>>> Further it looks to me as if xen_p2m_size and this variable
>>> were actually always kept in sync, so I'd like to put up the question
>>> of dropping one of the two.
>>
>> Hmm, should be possible, yes.
>=20
> Looking into this it seems this is not possible.
>=20
> xen_p2m_size always holds the number of p2m entries in the p2m table,
> including invalid ones at the end. xen_p2m_pfn_limit however contains
> the (rounded up) index after the last valid p2m entry.

I'm afraid I can't follow:

xen_build_dynamic_phys_to_machine() sets xen_p2m_size and then syncs
its value to what so far has been xen_max_p2m_pfn.

xen_vmalloc_p2m_tree() sets xen_max_p2m_pfn and then syncs its value
to xen_p2m_size.

I therefore can't see how the two values would hold different values,
except for the brief periods between updating one and then the other.

Jan