Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Aug 2021 14:39:30 +0200
From:   Fabio Aiuto <fabioaiuto83@gmail.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     gregkh@linuxfoundation.org, hdegoede@redhat.com,
        Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: commit c7e88ecbe328 ("staging: r8188eu: remove rtw_buf_free()
 function")
Message-ID: <20210803123929.GA1898@agape.jhs>
References: <20210803072129.GA1422@agape.jhs>
 <26260563.P9vmH3Ooqy@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <26260563.P9vmH3Ooqy@localhost.localdomain>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Fabio,

On Tue, Aug 03, 2021 at 02:23:25PM +0200, Fabio M. De Francesco wrote:
> On Tuesday, August 3, 2021 9:21:30 AM CEST Fabio Aiuto wrote:
> > 
> > Do you have any idea of what happened? This
> > topic could give us all deeper understanding
> > of kernel memory management.
> > 
> Hi Fabio,
> 
> I've just briefly looked at that c7e88ecbe328. I have no time to dig it deeper 
> but at a first look it seems that the following line is the culprit:
> 
> kfree(&pmlmepriv->assoc_req);
> 
> It should be:
> 
> kfree(pmlmepriv->assoc_req);

I think you are right :)

I didn't noticed rtw_buf_free's first argument is
a double star pointer.

> 
> The second line frees the memory location whose address is saved in assoc_rec; 
> the first line instead frees assoc_req itself.
> 
> Regards,
> 
> Fabio 
> 
> 
> 

thank you,

fabio