Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Aug 2021 13:47:26 +0100
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     <alexandru.tachici@analog.com>
CC:     <jic23@kernel.org>, <linux-iio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] iio: adc: Fix flags in sigma-delta drivers
Message-ID: <20210803134726.000067f0@Huawei.com>
In-Reply-To: <20210803091741.8924-1-alexandru.tachici@analog.com>
References: <20210731150926.42a2da31@jic23-huawei>
        <20210803091741.8924-1-alexandru.tachici@analog.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 3 Aug 2021 12:17:41 +0300
<alexandru.tachici@analog.com> wrote:

> In Sigma-Delta devices the SDO line is also used as an interrupt.
> Leaving IRQ on level instead of falling might trigger a sample read
> when the IRQ is enabled, as the SDO line is already low. Not sure
> if SDO line will always imediately go high in ad_sd_buffer_postenable
> before the IRQ is enabled.

ok. That last bit sounds like a good justification.  It might do the
wrong thing on initial startup.  Please resend with that in the patch
descriptions for those you are modifying.

For those where it is being introduced, we probably want to leave the
interrupt type to firmware (i.e. patch 1)

> 
> Also the datasheets seem to explicitly say the falling edge of the SDO
> should be used as an interrupt.

Reference?

> 
> -Alexandru