Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Aug 2021 16:38:33 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kari Argillander <kari.argillander@gmail.com>
Cc:     Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
        linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz,
        aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org,
        joe@perches.com, mark@harmstone.com, nborisov@suse.com,
        linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com, hch@lst.de,
        ebiggers@kernel.org, andy.lavr@gmail.com, oleksandr@natalenko.name
Subject: Re: [PATCH] Restyle comments to better align with kernel-doc
Message-ID: <20210803133833.GL25548@kadam>
References: <20210729134943.778917-1-almaz.alexandrovich@paragon-software.com>
 <20210803115709.zd3gjmxw7oe6b4zk@kari-VirtualBox>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210803115709.zd3gjmxw7oe6b4zk@kari-VirtualBox>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JN2P275CA0040.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Tue, 3 Aug 2021 13:38:46 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e48a1cf3-66d7-4d33-16bc-08d956840b8c
X-MS-TrafficTypeDiagnostic: CO6PR10MB5569:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO6PR10MB5569BDF07EC6014A222A45EB8EF09@CO6PR10MB5569.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2582;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6wWm4gQci5mVSWdei6yEWkbKRc5Cjf4VoIMmFoN4uckPv9x+AuqfW89/OngfsXlVovWT3jIH3X3ZrTmMRRTJoEMVriRCzbKllBFRJ6+wzrfIXuNC/OLqphJHACQAwXGXj6CB+uabOm5lu5msoCrXTvbueR6bBe33oGC+IdAaDv8T2TBfp3Cbdeaz7SvaE8m6bV/mSNYsBH/P57dTwRangdpXpNTaAvLxRhhxny6jITEI8BNqx6ZHh0fI0ayWyhXO5ITogG4oZjyw4BVoUVD0N3WI9WQT7hXXoRZNHUtAWlrg29YA+rn1PLVdJXQsgR7xLP2LK7zkkVQs+tpdkb9X+gFWLkZZt6wlFnNlEMt/Wxw4tCM0Vk63Kpnikh/TUGvuZpdJvzOtIJ8b3LU7PToT3cLzdaUgFXYZ/2DfxOETDfythJsFKfIQ1go8R+z7himzMULnCXFCd9L/cyAWFklRmf7pE6QXlgi/2stS42awFc8B4jCWl58bsDArkW2OvF+c2cfrvaD4pv/IqG5nFlQYJ5hMEbQq84XwYNqDK52IBC17lxegWxhReB83IPzKyTCHP5ribhx4e6qUyt+zwS7AKGbNxC/E1lGjpok60jZAoT/b+ub/eg0Vk2Uygk8dl7ZVf8b12S3E0DbyOvrtNfhAsuBA//Dfin2rjuUFXmdCCe0Nyu+afla0aoidnbEnFUTU+/RpCKldTWZeFVzzvDyGMQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(136003)(366004)(39860400002)(376002)(38100700002)(6666004)(8676002)(66946007)(38350700002)(52116002)(33656002)(8936002)(66476007)(55016002)(66556008)(26005)(6916009)(9686003)(44832011)(316002)(9576002)(33716001)(86362001)(4326008)(478600001)(6496006)(5660300002)(7416002)(2906002)(186003)(956004)(1076003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?glLSVixW7/5hSf+i0JD+jIZVycsDWFO6WRBY5fnPad9NnlQerVz6c9M3aa0V?=
 =?us-ascii?Q?K3K8Azs61ijd/DKF5CVZwBvsBGLDEZx20yXQDPBh6t8GSGgNutF4eDruYaqo?=
 =?us-ascii?Q?8QpErewEGafK/oR37dwekct2Ikqc5PpJJEk081vEh5dM5ceFJZV7QJ8kb/g5?=
 =?us-ascii?Q?dsd2Ijia0ZsnsvFTJnx5wsi56sSG8j+i3NbfIuZEpG9RalLurbHNciVPx/cb?=
 =?us-ascii?Q?yxKCI+IoPtchhd+77DLZD7wJaYqwUGc+Y9DZ0RblsW3JkGmNGxb73bfOxEV4?=
 =?us-ascii?Q?lfQOD8MlJjHS1cCSVB2RAuWs2ZnohyQXPOjry5TVKJXoRm1daMVEaZGmD68I?=
 =?us-ascii?Q?f18YE1GqbJO8bj1MyaTr8zrkI5UArvassmHl7lbLOWcLAqWf/6ofeHydKkQA?=
 =?us-ascii?Q?X1uOx40PJy3lv9/P/omHW7c58FKJPgvhC1LwUlO+0FLtDfMHkZPab1L3QeRk?=
 =?us-ascii?Q?1JyKfRiBk4zdRqOnKVX5/CVvcQy0sfMV03fZDb7C7nQLLGETphiWM1qwAxxY?=
 =?us-ascii?Q?ibT77xmxZaGKX+yMSDO6KHYhsyLTQ4LtkSReHGRudDim3yiWG8y/uc+8bKqy?=
 =?us-ascii?Q?ma3+w00xa3giaSd8we70Aje09jgSS96ULsPn6ra5wHS+s8iaeRs7r0+x518A?=
 =?us-ascii?Q?JDLejITAX1zqYJ1baFrwfu+3b9t3VYtXO0hmYhCl8aOd/72/lKD6GgpsM0fy?=
 =?us-ascii?Q?wW51HyLS7SQaYYLNZy8ieIM0aCfQWvyC8UoR5eBFpzyk8xS1uL+H9seC8Awx?=
 =?us-ascii?Q?OHsSuzfLjiujI2kg/LGc5UCSWJAIxb/KSK3G7l/bJsKvuTdmttfSQgIRc6nK?=
 =?us-ascii?Q?mfooydwETzT7342AZi2yS8PFfYKalvBiRpCOsbVM+g89c3IWTL9QGHiRYTcC?=
 =?us-ascii?Q?yzkk4ZRgqiKWiuT2ReW3c9ffrjTI/te+HJ8bk2jzSUEuWzOjj46MsKpOVEuY?=
 =?us-ascii?Q?L0eyI2mvloonIi+DyJbe0+/GT9ojtTTfDd+tBi8cfMgU8YPWssjkJNsWogl2?=
 =?us-ascii?Q?8fyo85Zy5qG9P9L9yC5joDfhbCML/RuPfwSzmqEmkWwBVci2stBeMXXIsIWa?=
 =?us-ascii?Q?+wZxFZ3cVEIeXbewb3vkvJdkJBdtfP124PcTnUqdRELii258k0pFg/I7riS8?=
 =?us-ascii?Q?2Es3UNnu5lrBZVAbMLBAEzjWaP+9KS+nZPHYzPMuJqCTgWSmRf+FzNztbsLy?=
 =?us-ascii?Q?QYSmpIc+ZTds7ShZHfvmmZiJhvPUUadfPluAdkFcaYMxW1RSEmgX6Qrwo5nv?=
 =?us-ascii?Q?HZCYisRViVq5rksmvJmD3BagdrZTAHvTHOppiU5TPTiP3/QUQf6l+KFguiB/?=
 =?us-ascii?Q?JditOI6ul23om1tpgn6Xfau6?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e48a1cf3-66d7-4d33-16bc-08d956840b8c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2021 13:38:58.1356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8zUgUHPrzsuSzjwWa3Qn1LG8jR8QwiJ8G02tmCAJllEVjwj6QXEBpUDQzob2NiYWfDpXyrqhAi32fugJiyX/gjRubNm/eDGiwYgEUDwSOi8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5569
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10064 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=763 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108030090
X-Proofpoint-GUID: W8sJHpVxyde_thda3B_5N6wgzkTm1Qvw
X-Proofpoint-ORIG-GUID: W8sJHpVxyde_thda3B_5N6wgzkTm1Qvw
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Missing subsystem prefix in the subject.

On Tue, Aug 03, 2021 at 02:57:09PM +0300, Kari Argillander wrote:
> Capitalize comments and end with period for better reading.
> 
> Also function comments are now little more kernel-doc style. This way we
> can easily convert them to kernel-doc style if we want. Note that these
> are not yet complete with this style. Example function comments start
> with /* and in kernel-doc style they start /**.
> 
> Use imperative mood in function descriptions.
> 
> Change words like ntfs -> NTFS, linux -> Linux.
> 
> Use "we" not "I" when commenting code.

These are all nonsense style guidelines that you invented yourself.  We
already have too much pointless bureaucracy.  If you can't understand
the documentation or if there are typos then, sure, fix that.  But let's
not invent new rules.

(Also it annoys me when people pretend to be stupid "I can't understand
what a NULL deference is.  Ohhh...  You mean a NULL *pointer*
dereference!  You left out the word *pointer* so I didn't understand!")

regards,
dan carpenter