Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp2549964pxy; Tue, 3 Aug 2021 09:00:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX7Mafo1bZnG+MT/kPG1Vg3+7TUKk1or/iHJuDnVV6xkbn9+hXIOXNwQpfrUEPHbMzkTjG X-Received: by 2002:a05:6602:d9:: with SMTP id z25mr602636ioe.154.1628006432594; Tue, 03 Aug 2021 09:00:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628006432; cv=none; d=google.com; s=arc-20160816; b=LaDwF6zHJHE+BmcRDasp/rRytY8C2jWgXpIQiE9Lmj2NYq41aVE4xj/SmIuW218DFs ZZD2eLnwx4YydznNy5YlozYLOjQ8qx5g5rMdqrLNCqZDBoGzANJojYyqZhD/u93Evk9/ GzmVG+Ovmj3WxI8t2tfldaIRrwem8y60WPT1v2MLP0RFospLjm0AhxHTrZ41meFlTByZ L9aFFmIcvsJoyUa9sy9R0/UY8BjYC5ft14yRof4Ctv/kblyKII9E8VR44ANkW1eqNoZY US/qIS3GjrKIvpxh4n9n8em6wmj/WK9PohngGeoTMjxNR4jHq45FjQQNEjugqWWAE7cs kV1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=XyTeMXNgu90s6jed1cfMkwZQ5N13tw+IsKe++yQWSs4=; b=cSqHKxBI+GuILh3VD1QrhL124vaZJ1GNhwbd5+jqpPxmKJYbVV9iCUgiydPLFqw7fU uEfS3pSx2BmpY1FaLMqm+ATr5FaK0lJddoUP66FOKds1gnIGwyy6SP0dtRCe41HNqq17 kWghp1Ab4vzivI/fGGVbqHDdxnJnFWRc8QbqcsslfYM2ysjKNwIO033Kdg6+Qt6KIAzL PDtgWzakz54O6dETx4Ipo04HO7lYrQ39Nc16jQwJbpVtcf6Gf20oFISaH+2AMzauQa1i Yj/5VCo2LzT/26ZwwU5Ydme43WvUSUliXeVJLMhxOyXD/gLoIPq98geqy55aHRof0wBv 5WLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CXEcYW8V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l15si16937054ios.94.2021.08.03.09.00.19; Tue, 03 Aug 2021 09:00:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CXEcYW8V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237213AbhHCP7q (ORCPT + 99 others); Tue, 3 Aug 2021 11:59:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:48938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237186AbhHCP7o (ORCPT ); Tue, 3 Aug 2021 11:59:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99C5360F45; Tue, 3 Aug 2021 15:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628006372; bh=ChhPSCYwVwBW+Gw7+iatuovIf2TIbBAIu4oLOgUZzyY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CXEcYW8VOiRy/IqDk4w1z47ZV6TB8DMXPTzW1CYY5HfajRsDDtvi8Xev/ZUwWC48+ Aa51HsvYdXIMh8yk5fPYG1VmnBomN8B/Upoq7GG5AzB6SdEhYNL0QSksUWV8kHjKX5 lQuqpJzsqwsPv6M7XeD8A3Mn4C6MTFIOaDuaKGvo6egbC7csK0LzykiKuk1XGKtvwN /pNDxIDlyTL3a5/+kc1KmIonqd46lgyDOr548FG0l6EC8AcJjUWNc56z32KU1oKWbz M7higY0/dGWoOrUd7ahds/l7oZ46vMzb6IOwp0J0I6mwXo6rp+4o2jXSrek6Ya4TRD 5vDGdL3cNsNPQ== Date: Tue, 3 Aug 2021 08:59:30 -0700 From: Jakub Kicinski To: yajun.deng@linux.dev Cc: "kernel test robot" , davem@davemloft.net, mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, kbuild-all@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, mptcp@lists.linux.dev, Denis Kirjanov Subject: Re: [PATCH net-next] net: Modify sock_set_keepalive() for more scenarios Message-ID: <20210803085930.103d37dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <202108031929.b1AMeeUj-lkp@intel.com> <20210803082553.25194-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 03 Aug 2021 11:42:39 +0000 yajun.deng@linux.dev wrote: > The tcp_create_listen_sock() function was already dropped in commit > <2dc6b1158c28c3a5e86d162628810312f98d5e97> by Alexander Aring. We don't have the commit you're quoting in the networking trees. You should modify tcp_create_listen_sock() and we'll deal with the conflict during the merge window. Unless obviously you should wait and "send the patch within a context of other scenarios".. (I'm unclear on what Denis is referring to.)