Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp2555515pxy; Tue, 3 Aug 2021 09:06:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2oY/XJi/XZqwrmVuku3/gZA7799BTPH9MVxLP9n7z/reuHrPOBWZV04Rg3LologexZ+Ti X-Received: by 2002:a6b:fe03:: with SMTP id x3mr1604384ioh.120.1628006797156; Tue, 03 Aug 2021 09:06:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628006797; cv=none; d=google.com; s=arc-20160816; b=gmgHThc/ZRBwwh/tW24YD4ilV70l8PWKSv4Nu0i3G7z49nSWJ73Eku9HUVD6iFz6AJ 9dehbQGBBDJeINV9KMUsWZIsOHarguiVy4Gw/PsluLw5/e9VQL4B5FHTVcbssXb5uJdB b6cPBXlR5Z84qFHmOjx9HZNc9WkRjRrGdTApC2AeBjFCVC0Hr7ag9qKTAkKRYp/YRBEW a9zgS7kbsjuHgX7eIUObwN4JAUaDax4YZhfY4kQcp1Ml9sPvQciAIE6W7AeOi9jmIo7l D+mTRPSL0LAxHg5WBnL3mZHi9ADkVQEhKfg/X4xdgYMkI+QZBo9DglRNBFUG78b41uzK oedg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rFG+y2/f0kIS+1piSi01lqKfhQxPbZdynLRltnbgxiQ=; b=y4djn86C7HTS9pRIlmtlsgFKmmB4ZYWrdCT7mRWcseo9NsNjvKTbKQN+DbGNy1Ihag d2wGSx6JkLtJG8em58eAqj/0M+la6kGbzVfwOvf0Xc9Z5vt0k82tE+augmPfcRz4BaBD v177KPa+GIv7w61faJQ1zSokcno7NTZe7WK3Cw3JZqjltSmNfHDFJnyhmjpdY0LAb9Ye Eh0X+f+vjmg/11Mlp86DkVRbK0ob1e287oZPX5z4kcG4Mbflsn0EeUBsv6W2xEm7ml2N 4cq+S/NKPD33dkcw70xpD4+xyBDlS/0VlTofPwOj+GRGdf7wXlSS6mty1KSpwj/+qccx 4DmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b4ukp4ub; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n7si16871598jaj.4.2021.08.03.09.06.17; Tue, 03 Aug 2021 09:06:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b4ukp4ub; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231688AbhHCQE5 (ORCPT + 99 others); Tue, 3 Aug 2021 12:04:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231659AbhHCQEv (ORCPT ); Tue, 3 Aug 2021 12:04:51 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93DBEC061757; Tue, 3 Aug 2021 09:04:37 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id mt6so30265084pjb.1; Tue, 03 Aug 2021 09:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rFG+y2/f0kIS+1piSi01lqKfhQxPbZdynLRltnbgxiQ=; b=b4ukp4ubuRoZUf5QUsgGIX5Z8hvILnPKu2bruY8jXI93TywzIyFGzaosjq4ZjaNoAC OKdQZZJ06HFDVSEohb37uw6lIL88NyO5QjsVGO0KoSM/rbmyRPcvJzuP6Qh3bGN9zyul alerxWFjJxOIGbCUqIZGOXxcxx7QHqCQBazx/skeJLZLvZixB9/WZfmx7Wxi4RZpE/WS E3kmThx1F+PtgAXmLlYi4AsW3TzJoFxMLq4dkOsy+A6ym1ZMYGm+dns1Wgd73GlDasVH 7P5x9yiaipdWdfFRLVnsY9pdTOua3l35OpEPyzZdHquo5u6TBeWZa9zW9T1AgPjqBbgu VtUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rFG+y2/f0kIS+1piSi01lqKfhQxPbZdynLRltnbgxiQ=; b=Ez03jqJpsgo2pNeJfrrL7xJS55ucLBZrnbu3wknXD8ZX/OfgooQb2I8qBZSUkv/GeG zz35VR3UBMiD4zh7tQ7XzlFrfuck1dLZXOib2hhbz8F1f8vbgKbE2DZiASasVFCAJfk0 5GadMQjgIOm18SL2bbVsKDlkN6R3Z/7xAQ/3q+9ynmgbHNb2Ta8rzRdQIZfdfndG3VKa vc5jNLbE+wQZNHFXAYIHU8fDk0J7PrYHMMxoan6wBWXoPSvHg066GWXWeRHOQK993P4+ ANZM3IZgX3C78v6iMA3BY14FCEa5AgNSed1cH0GEhLyyd/R2NCeo+vJdG/cTcNpOtc+x hsbg== X-Gm-Message-State: AOAM532fjO6QCA2v2P9csPNMB71oR/kbrzHQov0+2qhFrGujIXgDwIIa s06FeL3h65IeGEvT8ZGGuvQ= X-Received: by 2002:a63:62c7:: with SMTP id w190mr288455pgb.55.1628006677214; Tue, 03 Aug 2021 09:04:37 -0700 (PDT) Received: from haswell-ubuntu20.lan ([138.197.212.246]) by smtp.gmail.com with ESMTPSA id y6sm14390653pjr.48.2021.08.03.09.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Aug 2021 09:04:36 -0700 (PDT) From: DENG Qingfang To: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Eric Woudstra , =?UTF-8?q?Ren=C3=A9=20van=20Dorst?= , Frank Wunderlich , Ilya Lipnitskiy Subject: [PATCH net-next v2 3/4] net: dsa: mt7530: set STP state on filter ID 1 Date: Wed, 4 Aug 2021 00:04:03 +0800 Message-Id: <20210803160405.3025624-4-dqfext@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210803160405.3025624-1-dqfext@gmail.com> References: <20210803160405.3025624-1-dqfext@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As filter ID 1 is the only one used for bridges, set STP state on it. Signed-off-by: DENG Qingfang --- v1 -> v2: use FID enum instead of hardcoding. drivers/net/dsa/mt7530.c | 3 ++- drivers/net/dsa/mt7530.h | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 606a9f4db579..9b39ccd9dd4c 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -1147,7 +1147,8 @@ mt7530_stp_state_set(struct dsa_switch *ds, int port, u8 state) break; } - mt7530_rmw(priv, MT7530_SSP_P(port), FID_PST_MASK, stp_state); + mt7530_rmw(priv, MT7530_SSP_P(port), FID_PST_MASK(FID_BRIDGED), + FID_PST(FID_BRIDGED, stp_state)); } static int diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h index d44640bbd865..5b70ccef9459 100644 --- a/drivers/net/dsa/mt7530.h +++ b/drivers/net/dsa/mt7530.h @@ -186,8 +186,8 @@ enum mt7530_vlan_egress_attr { /* Register for port STP state control */ #define MT7530_SSP_P(x) (0x2000 + ((x) * 0x100)) -#define FID_PST(x) ((x) & 0x3) -#define FID_PST_MASK FID_PST(0x3) +#define FID_PST(fid, state) (((state) & 0x3) << ((fid) * 2)) +#define FID_PST_MASK(fid) FID_PST(fid, 0x3) enum mt7530_stp_state { MT7530_STP_DISABLED = 0, -- 2.25.1