Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Message-ID: <trinity-0f9449b8-5114-46e5-9a4f-00b62155a938-1628010948338@3c-app-gmx-bs54>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Sungbo Eo <mans0n@gorani.run>
Cc:     linux-mediatek@lists.infradead.org,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Min Guo <min.guo@mediatek.com>, devicetree@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Sungbo Eo <mans0n@gorani.run>
Subject: Aw: [PATCH 0/2] Add MUSB for MT7623
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 3 Aug 2021 19:15:48 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <20210803151320.71531-1-mans0n@gorani.run>
References: <20210803151320.71531-1-mans0n@gorani.run>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

> Gesendet: Dienstag, 03. August 2021 um 17:13 Uhr
> Von: "Sungbo Eo" <mans0n@gorani.run>
> An: linux-mediatek@lists.infradead.org
> Cc: "Chunfeng Yun" <chunfeng.yun@mediatek.com>, "Greg Kroah-Hartman" <gr=
egkh@linuxfoundation.org>, "Rob Herring" <robh+dt@kernel.org>, "Matthias B=
rugger" <matthias.bgg@gmail.com>, "Min Guo" <min.guo@mediatek.com>, "Frank=
 Wunderlich" <frank-w@public-files.de>, devicetree@vger.kernel.org, linux-=
usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vg=
er.kernel.org, "Sungbo Eo" <mans0n@gorani.run>
> Betreff: [PATCH 0/2] Add MUSB for MT7623
>
> These patches add support for the MUSB controller on Mediatek MT7623.
> Tested on Mercury RUSH-318AC Wi-Fi router.
>
> I got to know this from a BPI-R2 forum post [1], and managed to make it =
work on OpenWrt snapshot.
> I'd like to know if this also works on BPI-R2, I can happily share the d=
etails if needed.
> And I've just copy & pasted nodes from mt2701, please let me know if I m=
issed some big differences between SoCs...
>
> [1] http://forum.banana-pi.org/t/bpi-r2-otg-port/10551

thanks for working on it. do both otg-roles (host/client) work on your dev=
ice?

unfortunately at least host-mode does not work (do not know how to test cl=
ient mode). i guess because iddig and vusb nodes are missing.

i took your Patchset and enabled the usb-node for bpi-r2.

+&usb3 {
+       status =3D "okay";
+};

and added these config-symbols:

+CONFIG_USB_CONN_GPIO=3Dy
+CONFIG_USB_MUSB_HDRC=3Dy
+CONFIG_USB_MUSB_MEDIATEK=3Dy
+CONFIG_NOP_USB_XCEIV=3Dy
+CONFIG_USB_CONFIGFS=3Dy
+#CONFIG_USB_CONFIGFS_MASS_STORAGE=3Dy
+#CONFIG_PHY_MTK_TPHY=3Dy
+CONFIG_USB_GADGET=3Dy
+CONFIG_USB_MUSB_DUAL_ROLE=3Dy
+CONFIG_USB_INVENTRA_DMA=3Dy

btw. imho otg-node should be named usb0 as other dts (kernel 4.4) also use=
 usb0, else i think it's confusing.

in my last attempt i had these below usb-node in boards devicetree:

+       usb_vbus: regulator@0 {
+               compatible =3D "regulator-fixed";
+               regulator-name =3D "usb_vbus";
+               regulator-min-microvolt =3D <5000000>;
+               regulator-max-microvolt =3D <5000000>;
+               gpio =3D <&pio 237 GPIO_ACTIVE_HIGH>;
+               enable-active-high;
+       };
+
+       connector{
+               compatible =3D "gpio-usb-b-connector", "usb-b-connector";
+               type =3D "micro";
+               id-gpios =3D <&pio 44 GPIO_ACTIVE_HIGH>;
+               vbus-supply =3D <&usb_vbus>;
+       };

after adding these i see the connection of otg-cable with usb-stick in dme=
sg:

[   53.656304] usb-conn-gpio 11200000.usb:connector: repeated rot
[   53.696324] usb-conn-gpio 11200000.usb:connector: repeated role: host

but usb-stick is not powered (led of the stick is off) and of course i see=
 no mass-storage device.

and now i'm back on the traceback on power down i've reported Author of mu=
sb driver some time ago

[  156.785185] WARNING: CPU: 0 PID: 1 at drivers/power/reset/mt6323-powero=
ff.c:4
[  156.795156] Unable to power off system

[  156.884496] [<c0cca1ec>] (warn_slowpath_fmt) from [<c090562c>] (mt6323_=
do_pw)
[  156.893203]  r8:c3296d40 r7:00000024 r6:0ccccb60 r5:c10fe3d8 r4:0000000=
0
[  156.900030] [<c09054b0>] (mt6323_do_pwroff) from [<c010ba68>] (machine_=
power)
[  156.908558]  r8:fee1dead r7:c1312590 r6:92f61d00 r5:00000000 r4:4321fed=
c
[  156.915385] [<c010ba34>] (machine_power_off) from [<c01524bc>] (kernel_=
power)

i guess it's related to the usb_vbus.

regards Frank