Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp2690452pxy; Tue, 3 Aug 2021 12:33:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSJUW5AMUESBi8G0QCDrD9Tf6D4uy/df3WhzmebfUKWjq0jI4LFsZdCNloQbos/8Jb7jtY X-Received: by 2002:a05:6e02:1073:: with SMTP id q19mr305896ilj.110.1628019181784; Tue, 03 Aug 2021 12:33:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628019181; cv=none; d=google.com; s=arc-20160816; b=woOJfkkhzbw+Zq5i4LdytJvznfWdYlqnL4EFmSGZPhq74LAHm/kRqJ+3BlVUB+vKgA 9w9imC6Knb54bEaVDw/ROQuTazNEKxPMrcrZW4CTp3iSxyAJuqq+H8qo8I3Ao9EOoSAo t4EwK9onwhO0RlcDJM5Tocy3ksgxlgt6UsQdpQRZNNtxBegAJyXRHQVWw9JXvZPKR1iZ v1kPdjHqcg8lD4ul2Q+soMIeUWgxKomyVIqefY/QrBcstmNO3aepZie3FORYSbeEzwcC BVzvksPSQT34RUoM4x/mx0O/9IXJfL3LJrD3lax2n+Jvw1DF4+RPols+ynT9ETwmlewa iYaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=zRB6M0ndbNBDTV2jKQ4fFjFRD55yRk55LIlB0zy8Prs=; b=z3P5VTtPjDWgotLdN9y/IIYkXpMvYpYH8FyqOYf4+fNg9cnZ5YU3tBsCWoKpv+3hKK rJs5vPVw94VpJxHDSpakdtW7iLLL8yK1PWS+Px+YbjNJ8LkkGe0tt07OqT8sYcxvGJzs mwhxFkPIyL3N69fujxRk3bkMeBO33D3AeUTsK3LwuxvJ2csE19HwGPkVIFvfgyytCGL2 pCNrMqAa8XUtsupw4xIg6p7RkqBTlFkT6sJImkABHz9S1XBhUUYNDL3bMec294QruDY8 02LSmDYJSYSwm0u5QJMm9l5y2HifIlUu+V4RtHM2rvyx4KYRzzn52TICow07roHJ7YpW CvFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nLiKixCz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j17si15235148jaj.70.2021.08.03.12.32.48; Tue, 03 Aug 2021 12:33:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nLiKixCz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239633AbhHCTbQ (ORCPT + 99 others); Tue, 3 Aug 2021 15:31:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:39934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239395AbhHCTbQ (ORCPT ); Tue, 3 Aug 2021 15:31:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 36EC2603E7; Tue, 3 Aug 2021 19:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628019064; bh=QY2GEHpzXPPU0n5auFTFTfMaTFjPa4x8HiZo7mTWQgE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nLiKixCz8EnFb9V5uP5sl2zskq4skQRGJDWsaHY+BjhKr6Vl/zauwb4+7GEMHEU2t nMSXVjmqUsApK2A+HzwrWQ3HxtMgiWvhP2a9pJNFeLgGVo1hM9/A8/Xw64V7CMjQTV vXFIVSILYauP+bOsMEYUTco7ZNI3ona3u7GJ2sUtXSOzBjU2ay/EWb3qvxEYDCspHc H7UH7ykNGZfycktslFB0KNDzdaxhQipIYUCAehTwlDN1IV3cJCl1NiL0t7HoSyhOGA Dm25+oiXlRm7TU8thaVxRAE76DCalCv28td2CmW0TtnT+mwUR8q7mk+BSwNH+D1xah akfxiBDhQao8A== Date: Tue, 3 Aug 2021 20:30:49 +0100 From: Mark Brown To: Andy Shevchenko Cc: Mason Zhang , Matthias Brugger , Laxman Dewangan , linux-spi , Linux Kernel Mailing List , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Mediatek WSD Upstream Subject: Re: [PATCH v2 3/4] spi: mediatek: modify set_cs_timing callback Message-ID: <20210803193049.GQ4668@sirena.org.uk> References: <20210803102428.6476-1-Mason.Zhang@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z87VqPJ/HsYrR2WM" Content-Disposition: inline In-Reply-To: X-Cookie: There's only one everything. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --z87VqPJ/HsYrR2WM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 03, 2021 at 09:20:19PM +0300, Andy Shevchenko wrote: > On Tue, Aug 3, 2021 at 1:42 PM Mason Zhang wrote: > > + inactive = inactive ? inactive : 1; > All of these can be simplified by using ?: (short ternary) form. Please don't, if anything just don't use the ternery operator at all for things like this - it doesn't help with legibility. --z87VqPJ/HsYrR2WM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEJmWIACgkQJNaLcl1U h9DkVgf/Rv7cu2sTnh6I4OzeDeohVJspONWje3p7I9opiL1FrbONWkc1yKFmhBay 7aUfYhbl9Z+VXUyWmuBCe668PGRT/j0a/9uVsQaKER1xNaW3BaWH5Av99TSZsyB+ J90YRP+TqT9G60dD5jgHodAJ3jEJePoU+7CXCuR4OvhBqdn7SVLD0BMBiwH90cOg CeyEHO/go1UN/B+CZbKds2d1/uYPh2wmH2JHsmxoYFIRxLKdQkEVpRgTy13dnzy2 p2doLPsVrdHI04N2O4yZKEZrmi5YEtReig8tyGRjMYdP1bC//tLdw21Fy49CsFxD e8hBwYgr3MfOaL/EW96PbEdXWRGaKw== =HNVE -----END PGP SIGNATURE----- --z87VqPJ/HsYrR2WM--