Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Aug 2021 22:21:38 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Maximilian Luz <luzmaximilian@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mark Gross <mgross@linux.intel.com>
Subject: Re: [PATCH v1 1/1] platform/surface: aggregator: Ouse y instead of
 objs in Makefile
Message-ID: <YQmXQlZqoUCHhSdn@smile.fi.intel.com>
References: <20210803175000.72880-1-andriy.shevchenko@linux.intel.com>
 <d8d1837a-583b-3926-5057-755acc84a5c9@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d8d1837a-583b-3926-5057-755acc84a5c9@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Aug 03, 2021 at 08:40:10PM +0200, Maximilian Luz wrote:
> On 8/3/21 7:50 PM, Andy Shevchenko wrote:
> > The 'objs' is for user space tools, for the kernel modules
> > we should use 'y'.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Thank you! I was previously not aware of that distinction. Two small
> notes:
> 
>  - There is a typo in the subject line.
>  - With that change, the ifeq could be placed in-line (see note below).

Will address both.

> All in all looks good to me (assuming the typo gets fixed).
> 
> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>

Thanks!

-- 
With Best Regards,
Andy Shevchenko