Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Aug 2021 13:37:34 -0600
From:   Rob Herring <robh@kernel.org>
To:     Kyle Tso <kyletso@google.com>
Cc:     linux@roeck-us.net, heikki.krogerus@linux.intel.com,
        gregkh@linuxfoundation.org, badhri@google.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: connector: Add pd-supported property
Message-ID: <YQma/tXBtfWGk4Ge@robh.at.kernel.org>
References: <20210730061832.1927936-1-kyletso@google.com>
 <20210730061832.1927936-2-kyletso@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210730061832.1927936-2-kyletso@google.com>
Precedence: bulk

On Fri, Jul 30, 2021 at 02:18:31PM +0800, Kyle Tso wrote:
> Set "pd-unsupported" property if the Type-C connector has no power
> delivery support.
> 
> Signed-off-by: Kyle Tso <kyletso@google.com>
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml          | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 92b49bc37939..21ec470117a6 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -111,6 +111,10 @@ properties:
>        - 1.5A
>        - 3.0A
>  
> +  pd-unsupported:

'disable-pd' or 'pd-disable' would be a bit more consistent with other 
flags like to enable/disable things.

> +    description: Set this property if the Type-C connector has no power delivery support.
> +    type: boolean
> +
>    # The following are optional properties for "usb-c-connector" with power
>    # delivery support.
>    source-pdos:
> -- 
> 2.32.0.554.ge1b32706d8-goog
> 
>