Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp2768412pxy; Tue, 3 Aug 2021 14:52:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzki/i4rC6Whf0qhnGYPBvaSrH3nLgCuDxxdR4UT2eD3TP1WKeZ49fguNgkTtQ/TTSGH+rH X-Received: by 2002:a92:dc49:: with SMTP id x9mr206877ilq.236.1628027578248; Tue, 03 Aug 2021 14:52:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628027578; cv=none; d=google.com; s=arc-20160816; b=qEaBvAf+ktcd7DFALyXUJ0JyTXb8DyhlxttOyBhfFD3doOWxH8gA7Llbf2nTWXZQTB bi1nF6RgmycR82vdw6bE82GV6auKQ1bemxV69I2k4lEe4bQlgyVMr9Z40KOiHfrW3oYH FnZzerWKBCwRuGKMqFDLfUdmloqMzZQpQvKYSgpn0noN6BMt7cjHqRW9YFTMH4pzRHVH 9PZUUUlU2gnRrq7jsBMG/EovSStlk/pEcUVEAa0V7VLT2nKLSx4E89owSHo8wOF4HM9M dnb1JuU+6c5gnX16kei5HKmxJMQMm6TqRuJZkOiprDAx3+SRlk2xRC8zkJETtZc7I+So JQwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=AxvOLKilIULgcPFV2in0tE/4rOw2k+VTDOGyUxzz+l4=; b=iZLSK97vHrBqgIidhTauuWq4T+7Koq0BsF75tfFZ4K/qaFnmBeaWK4WrfVjAlCODyt HLsfU2eenrN3ni1T5d6lTJVyzCO0rGAetcG5PWL/8Av8NHF1gbg4CYBohXcKsfbQjZRQ NHEjje9pIEgIYPzsaNNPICQweOWRBEZ4AOyj4DRUGBxD79QFY1skzi17YKg3jbhE2F5X M4Nqm05blvISn3g1yBfs8TsIBPg4n7VO2a6CtL2hnyfnWEmF8xNv7evV6JDwjQ/7Toqe 7MPcwqwds2/AOWJDItLIy1KxDyAWjxv7d5qi26jqmVhnuhmdhPKVYeS6fznDQgfEqGHY zVrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a26si118542jao.66.2021.08.03.14.52.46; Tue, 03 Aug 2021 14:52:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbhHCVvE (ORCPT + 99 others); Tue, 3 Aug 2021 17:51:04 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:40028 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhHCVvC (ORCPT ); Tue, 3 Aug 2021 17:51:02 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 537381C0B76; Tue, 3 Aug 2021 23:50:50 +0200 (CEST) Date: Tue, 3 Aug 2021 23:50:49 +0200 From: Pavel Machek To: andy@surfacebook.localdomain Cc: Linus Walleij , Andy Shevchenko , Amireddy Mallikarjuna reddy , Abanoub Sameh , Marek =?iso-8859-1?Q?Beh=FAn?= , Krzysztof Kozlowski , Linux LED Subsystem , linux-kernel Subject: Re: [PATCH v2 12/13] leds: rt8515: Put fwnode in any case during ->probe() Message-ID: <20210803215049.GC30387@amd> References: <20210529111935.3849707-1-andy.shevchenko@gmail.com> <20210529111935.3849707-12-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QRj9sO5tAVLaXnSD" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QRj9sO5tAVLaXnSD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat 2021-06-05 12:46:11, andy@surfacebook.localdomain wrote: > Tue, Jun 01, 2021 at 12:06:05PM +0200, Linus Walleij kirjoitti: > > On Sat, May 29, 2021 at 1:19 PM Andy Shevchenko > > wrote: > >=20 > > > fwnode_get_next_available_child_node() bumps a reference counting of > > > a returned variable. We have to balance it whenever we return to > > > the caller. > > > > > > Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver") > > > Cc: Linus Walleij > > > Signed-off-by: Andy Shevchenko > >=20 > > Reviewed-by: Linus Walleij >=20 > Thanks! >=20 > Pavel, can you, please, review this batch? I think I addressed most of yo= ur > comments if not all. 10-12 applied, thanks. Pavel --=20 http://www.livejournal.com/~pavelmachek --QRj9sO5tAVLaXnSD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmEJujkACgkQMOfwapXb+vJEVQCeID25VeF3Y503w5mOvpeJAY2p R44An0ewAIbhsFtjTGN/eb7UywUywqlY =f9Cw -----END PGP SIGNATURE----- --QRj9sO5tAVLaXnSD--