Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp2769184pxy; Tue, 3 Aug 2021 14:54:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxORt+mIe3Ea5sSccc85wDyTsum1GirTlrOJAaeG53cNvDRf6oL52EPcpflznrgBYSw+tAg X-Received: by 2002:a05:6602:1203:: with SMTP id y3mr3781149iot.192.1628027657513; Tue, 03 Aug 2021 14:54:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628027657; cv=none; d=google.com; s=arc-20160816; b=Wga1+6uFjZT5a0yck2MFoi/+Jr+Y2Q+GOKmpPeFHJIesAdtB0LJev9mCcvKtGRczn5 altSx6oxGRt78IgAPZ2yMRKokGjg/MJn8loECQFONM7zp8ZgXchw2CTm45Dw+5JWhnn5 IkNxZWTxczyaTvYOReaVBEGaTcxjXF5C8ck20koIkcYKRBKLtd6a4gK/frgV3ARxOvBB ml7jEIZ+m1xMGeNTBMDrucdFdonWg9G6Jqf8o0Yj2M/DDj3MqbyIFUHgF5ixbXuBYZjI wGHKqnrIvg2bho6UTaowsnzUn/CiDQ3u/B0og6fUmGC/v1AZdF3xiSOU5Q+S75uXfJqK A1IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=C6rQ94kRGzyXpDGKkGbk+k/WptQ6VqF+IalIQYhlHR8=; b=nNotlZpyv6IpeLW6QelU15mdZ2BMD9j3PPKCKj3s7wcaREPzbM8Z9IYeVlY7eRzFNI Rr4SbK6RgD6BpYs3E3rfmYM3eLr0ZbQsvwJSbCh7QM5pIeLn5gADxy/7+g2ildY5kr6M wj6tppfH/4VBDux7/GAufemYQz76HiZCLM3tZaDsmXQ9OLKiUL7dx6QMY6deiWG7EjIJ t97ep1dNenhnT9PnBMgyzlwT/9LGsPDDFxUSBTYa3KVQpKKFAO2EnOSZu90K4p0N6MvD jFBXkTdeyCYHQEp93YoWH+CI0ltZArjGfsouF3oeAj1+0456v1HtjTs2l3k6OlbMTeEY K1tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j17si207396ilq.87.2021.08.03.14.54.05; Tue, 03 Aug 2021 14:54:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbhHCVvj (ORCPT + 99 others); Tue, 3 Aug 2021 17:51:39 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:40088 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbhHCVvi (ORCPT ); Tue, 3 Aug 2021 17:51:38 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 4F4001C0B76; Tue, 3 Aug 2021 23:51:26 +0200 (CEST) Date: Tue, 3 Aug 2021 23:51:25 +0200 From: Pavel Machek To: andy@surfacebook.localdomain Cc: Linus Walleij , Andy Shevchenko , Amireddy Mallikarjuna reddy , Abanoub Sameh , Marek =?iso-8859-1?Q?Beh=FAn?= , Krzysztof Kozlowski , Linux LED Subsystem , linux-kernel Subject: Re: [PATCH v2 12/13] leds: rt8515: Put fwnode in any case during ->probe() Message-ID: <20210803215125.GD30387@amd> References: <20210529111935.3849707-1-andy.shevchenko@gmail.com> <20210529111935.3849707-12-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wULyF7TL5taEdwHz" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wULyF7TL5taEdwHz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat 2021-06-05 12:46:11, andy@surfacebook.localdomain wrote: > Tue, Jun 01, 2021 at 12:06:05PM +0200, Linus Walleij kirjoitti: > > On Sat, May 29, 2021 at 1:19 PM Andy Shevchenko > > wrote: > >=20 > > > fwnode_get_next_available_child_node() bumps a reference counting of > > > a returned variable. We have to balance it whenever we return to > > > the caller. > > > > > > Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver") > > > Cc: Linus Walleij > > > Signed-off-by: Andy Shevchenko > >=20 > > Reviewed-by: Linus Walleij >=20 > Thanks! >=20 > Pavel, can you, please, review this batch? I think I addressed most of yo= ur > comments if not all. Your original email is: From: andy@surfacebook.localdomain . I don't believe that's right. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --wULyF7TL5taEdwHz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmEJul0ACgkQMOfwapXb+vKkwQCgiKGNe5VZmqG5rkBTgkbNofob wLUAnA4PfBVNO2HjVetvu3Wifm4D9z7J =fEin -----END PGP SIGNATURE----- --wULyF7TL5taEdwHz--