Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "cang@codeaurora.org" <cang@codeaurora.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scsi: ufs: Remove useless if-state in
 ufshcd_add_command_trace
Thread-Topic: [PATCH] scsi: ufs: Remove useless if-state in
 ufshcd_add_command_trace
Thread-Index: AQHXh8ld0Lx2t1dhZ0+LdbWRaSJCIKti5lcg
Date:   Wed, 4 Aug 2021 06:38:32 +0000
Message-ID: <DM6PR04MB65755981B606ECC00D1F198BFCF19@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210802180803.100033-1-huobean@gmail.com>
In-Reply-To: <20210802180803.100033-1-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A/rAsMlJYJf1H3272KjouGAAnCAq8LtlGojaxoKYvG/BeVLK4sw53T2mALBw?=
 =?us-ascii?Q?jrtR6URHcbaethBzdCi5WNlE2vUe8S/5pFrXAZxX7m+zuPUhXujK3VnVM3Zn?=
 =?us-ascii?Q?qSCmEowIG3SbbPSDQoNEmmTb6RM//rQZ2P61nmiCD5U33rXcgWAwpeL2Ah+v?=
 =?us-ascii?Q?6I8U2G8T/dTHGPP5AVPR74djnAoKN3QLfslS7yrSmxM2O6F3pt1rCtOS4b2k?=
 =?us-ascii?Q?vMKvtsZeMmIVGgMSoNMgToZ6WalZ4VJkP0PyxV+oM8kI0kBXHNPirgr9Mq9d?=
 =?us-ascii?Q?ertNktC55OY8JJcyEyA52XDC07epwHkX0jQksOLTPrQ/5EdfpTTUJ34op7QT?=
 =?us-ascii?Q?FeKrRVJS2KJQp4A8HdowBlqprN9uFq8q+N9aYKzPIP3JHeS9cCDZensQv/LY?=
 =?us-ascii?Q?pzZmZrgXCdTmtCzMGxLQEbIBYNB5qhVFXoLyJh2TQXUFccENJ/VZS65jbpXX?=
 =?us-ascii?Q?wq1rE8bCareApsUK+Cr0mw0X4Xr3t5H4NYIh8SFeuVaz4vIIzomRIjrUvH4V?=
 =?us-ascii?Q?Vo1+t6ffIRNDVLRpa8B6ywl15KL4lQwPfso9W1fU319MnFSzxESq0gjuYQyZ?=
 =?us-ascii?Q?+GO3Tak6VJ8XMuRDt1xu1Hb6Q7GMe+O2/+AcuslON6gPiIp65kp4i8+ReBuU?=
 =?us-ascii?Q?zbNd2kl0L3yabH88jYI2LxEdvJzuCRBmXnaGNFqIOdjCcIt373GwbdWL184e?=
 =?us-ascii?Q?7XmWCEBnjyXmozCgSlr2QG/Kjo0qYPOk0SSTkEpm11pm1W2lC4U8vj1nkTMg?=
 =?us-ascii?Q?X4EFwFDxDHyrAuBO8KdtgXkZ54FpSWtSTnysHWuUzaNsFFuE/PcdSp2h7xMz?=
 =?us-ascii?Q?abE+ZIsJpRKVFbuTzkmFHrXWKXAmlNuFwC81jEYiqmpldi1oMn1My+wBSTYN?=
 =?us-ascii?Q?In34HiIIfVnHDW8b7QLPwu2UnLrDBJRk0k8xyxWU0rF8ZxjIHC0AvfF5yU32?=
 =?us-ascii?Q?5Spue9/SVN8Lpp4y4GIIT32jKoVhihCFmeodfM6nX5bHerm6R7gvpOh/Ws4T?=
 =?us-ascii?Q?mmDs041bGbftJtPS4QLVCjl7pwFPZWwP7IDEpS6ItXb1abICcrCOuzF4G6vW?=
 =?us-ascii?Q?vXSWBatvAFetJo4Hx4HwcnHerYwFkw0ag/BF8QPlfgE77kxgduLB0RaYcCbf?=
 =?us-ascii?Q?CUKkJ3s+JY9Mri7b3kpoAqGbqEnR4UDD7epyzkfkt0CTvLJEclaF6n6eN7ZU?=
 =?us-ascii?Q?eo8dnqqD/3J6j83OwRCUfC4dyFS+fsy+CR0P0Q+XFA9/jrj88tu7gsQUeJXn?=
 =?us-ascii?Q?vlHKk0TukAtwl4Gmk3YazYnsXHIzWlzyHEg7W04SLtmUwCzm6TQ6lTTzo+eN?=
 =?us-ascii?Q?e8MI8brWQoosAIUppyorHC76?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1208a3f-71c0-4c29-6f5c-08d957127a96
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2021 06:38:32.5550
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rL2lgI++KsgE/UAOj5xigtiA4rDdE3KfZz67zv1kxEIRJlN+L6ZfCFxqJGghikjU5Ut8rGwPPWKctT0EphKuCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6589
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> From: Bean Huo <beanhuo@micron.com>
>=20
> ufshcd_add_cmd_upiu_trace() will be called anyway, so move if-state down,
> make code simpler.
>=20
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>


> ---
>  drivers/scsi/ufs/ufshcd.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> 064a44e628d6..02f54153fd6d 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -380,14 +380,11 @@ static void ufshcd_add_command_trace(struct
> ufs_hba *hba, unsigned int tag,
>         if (!cmd)
>                 return;
>=20
> -       if (!trace_ufshcd_command_enabled()) {
> -               /* trace UPIU W/O tracing command */
> -               ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
> -               return;
> -       }
> -
>         /* trace UPIU also */
>         ufshcd_add_cmd_upiu_trace(hba, tag, str_t);
> +       if (!trace_ufshcd_command_enabled())
> +               return;
> +
>         opcode =3D cmd->cmnd[0];
>         lba =3D scsi_get_lba(cmd);
>=20
> --
> 2.25.1