Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Aug 2021 09:20:58 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Colin Ian King <colin.king@canonical.com>
Cc:     Angelo Dureghello <angelo@kernel-space.org>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-can@vger.kernel.org,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: can: flexcan: add mcf5441x support
Message-ID: <20210804072058.vechdbtfcdz66rmz@pengutronix.de>
References: <7c80c17f-e38a-8fb1-f3c7-987187a2c4d8@canonical.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ujbc5qq3llttedpi"
Content-Disposition: inline
In-Reply-To: <7c80c17f-e38a-8fb1-f3c7-987187a2c4d8@canonical.com>
Precedence: bulk


--ujbc5qq3llttedpi
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 03.08.2021 16:23:26, Colin Ian King wrote:
> I'm not sure if it's possible for priv->clk_ipg and priv_clk_per to both
> be null, so I'm not sure if err can end up being not set. However, it
> does seem that either err should be zero or some err value, but I was
> unsure how err should be initialized in this corner case. As it stands,
> err probably needs to be set just to be safe.

ACK - There was already a patch that fixes the problem, but I've not
included it in a pull request:

https://lore.kernel.org/linux-can/20210728075428.1493568-1-mkl@pengutronix.=
de/

Will send now one.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--ujbc5qq3llttedpi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmEKP9cACgkQqclaivrt
76nhcQf+JviYcYhXs2AfGXxhXa1mOiIyxbhtAdJofmRGNZosFUBcRk7VUI8t4e8B
f9bZ1kVN3VwybiLQoYdxeAHcoSCEC0DYFoAuJlQFuOC5wsk3b0/lph/aK8D37Z4d
+cqxEdhu95JgZDDROYwYabWIN0vuym5jPAqyGKwvbvbBVxShHhpQrEbimZq4eENR
9OImRAkrjyP3v90E8scC4aupHcrsGmiDPZTSvqw1KOqK4hKYwl/wzgiIoB7QWftL
5+vHqrLqejpmhCYaHsF6UvLAd5rg2+3nyu83r9o5stuMKn7c0o4lDezpA/S0hi8x
0cVLp12P4s5rJCJkJ04lZmZLYQ11kQ==
=V9nl
-----END PGP SIGNATURE-----

--ujbc5qq3llttedpi--