Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 4 Aug 2021 13:58:38 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Salah Triki <salah.triki@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Fabio Aiuto <fabioaiuto83@gmail.com>,
        Ross Schmidt <ross.schm.dev@gmail.com>,
        Marco Cesati <marcocesati@gmail.com>,
        Brother Matthew De Angelis <matthew.v.deangelis@gmail.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Ivan Safonov <insafonov@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tablet: acecad: update the reference count of the usb
 interface structure
Message-ID: <20210804105838.GE1931@kadam>
References: <20210731160938.GA909566@pc>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210731160938.GA909566@pc>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNXP275CA0048.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:18::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Wed, 4 Aug 2021 10:58:53 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2b9289ee-b679-484f-3628-08d95736dcf4
X-MS-TrafficTypeDiagnostic: CO1PR10MB4547:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB4547C95E5755AA2BE59FDDD08EF19@CO1PR10MB4547.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ENmWllKt5eFlHwwdr64WtCqiiiWYzipb04npqtbI0zhXjiaOlExMO+TiTeLpBr5Kt0O04NgBx7VbGGXhBwp4unDKE42M5Wdx64dzgMo0FRpGk8Js5VpTuPACzhrXurt6kieJ9EdwX6yEX/ZyrrHujMQreHFCDv7vAoElPTkkluJhQZ2IeNQiE6MkkydgVgCcwNVczP4olVdbkgPvA/ie/OeYFlHJUKZt7l+ZBOVVwqcpn5ZoiprGqz9L05dH5RGi1xdNX3xr1d/dLK/cdJIewbUDq0ANOQ8kI04lef3f3hBk4SPbKoHnvbTQkWx9Gvz8+kIItvUt9I38FV1rTQ4HCa1GXkBt39l4gqE9w95KvUN0t46ZSa/MlsHXDNjWuKvSTJuORgeiAwO83j5cSCSQTLpOROR1AGI2J9k+TEyDdQSHi9A/pmm7dhNvoNCmuinivTt7/MA+unKiLe80S2dLald0zI0NcbvOrW1s1uM/6Nr+7BzBdaEgrjlcDaDhbRXUQWV20cQDkxtnPFEZF4W0oZBK2/PhsjLg3hPNDMHVSsNKFUSBp4YnGRdYkCny5kostLcH7UiStB2Ms8h9iJIWL9ysZIXwbsiPxozjS1l9B2TGG+nOwzeGrVOvEfyexCy0c2Vh76aOZRDzRKXrBqSFotG9CMSgJphhr6MA0RymOpZBImy7wqmfANGpcLVL7CQYe3dcewjhVN+J70Ub5c6CAQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(39860400002)(396003)(376002)(136003)(8676002)(956004)(4326008)(8936002)(6666004)(478600001)(316002)(9576002)(54906003)(33656002)(38100700002)(6916009)(38350700002)(83380400001)(4744005)(33716001)(6496006)(2906002)(55016002)(44832011)(26005)(186003)(86362001)(9686003)(52116002)(5660300002)(1076003)(66946007)(66476007)(66556008)(7416002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jJmTbn/+tX6DJKULD3l+lPdoUzSn0tIr3NhI2dM58t/JU06X83s92t6M4d26?=
 =?us-ascii?Q?Nqq36qljXemQ8hKW7Ls5KCV694L42gGo7xxS665yab9ygB6r9Vr9kdVnx1Jz?=
 =?us-ascii?Q?goiu6QsrMX29tVtjVRYjKtO2Alc4AKYEGTZ4aKpqsQ6rA222ax3+L671H5cW?=
 =?us-ascii?Q?X6QcmAyBlBx1i9ERkYI+ScFgIBdcUIp0l6Mpbc+puO2YHQeyiCOpaHZR8yjP?=
 =?us-ascii?Q?JUqGuibq3QhmFxRWUDbj8veu/IbFNicDF83hilMoIb7n9phujSSB8J419W3u?=
 =?us-ascii?Q?oOY5wRHU59+MyBZue2tObH7Xaqrjg0zvy3HPlUAUUNceM+DJf14znL3rd56H?=
 =?us-ascii?Q?aeBDGq0RmbcwBKzCFVZFjVIOQsKZ/lszICPT2o4xCSVootZIJN7qaL1XyEVR?=
 =?us-ascii?Q?ocXFj5wtbhNzf8oG8Ok66OGT9Cek51PAB1ASPbYEF04mNAw0GGkVcrqc/adc?=
 =?us-ascii?Q?p/+J2a8ynrQZ5WlSz/RA2f5XPJ02czAZo8IfnCK2YcYtYmI1wE6vTS5deklE?=
 =?us-ascii?Q?ZFK3qTnPru4ltG3jmcB/5AZJY5grmk1qOozAWEx4bV7n3qs6LLA/ijpSNWLy?=
 =?us-ascii?Q?+frtM4SylkXxUXurvuYRBKq7TZqqR82Ys8ApZ75HvfDs7IG8s4jYD2GPhrdI?=
 =?us-ascii?Q?OFz4cY1X3NGNejWRrodU4WLxyP1r68ammU8AQ0HPSlVqFvtp4MY7cglN74HW?=
 =?us-ascii?Q?yVNokTzZjztIoXUbh8IkO/WkY4yfOzEHjwZSrxV71dAZGCk61N+kHO0FgpYj?=
 =?us-ascii?Q?/+mQZOiBRHIXCB8XNtUzFNsKrxZyYcpQ2H8ivXRPESiqj8ZlWLBX79Li9gog?=
 =?us-ascii?Q?ljVqD7ETPipKecr6D8UmdHnp8EPXxz21OV2R/qsqQF4Q1LUXYVIXAVyXL0Hb?=
 =?us-ascii?Q?G6e4SKU6gsjfBeC+9fgGIM2XHNyxUIWOpb9Zq0M4biKVpaOXnXZ5UNB9d770?=
 =?us-ascii?Q?bs/443vamT457PSLAgD/yFNP1GV7y3hSW96EggGFG91SjkakziBzwr8FnA8v?=
 =?us-ascii?Q?k9cotClMJfqbzBcXgeOfsyTGvf84pJsKmwnLa0HCx2Qtc/K3fMkB57Frfo3+?=
 =?us-ascii?Q?2Rm/d3+bzODugaVkc8eGAEnxoe3GhENrQHDmwliRAalUdfhaSk/ULAe/2doY?=
 =?us-ascii?Q?9Gx1AWWWpUL4NvTY0rSX1i9gqgA+r4N2yBN5N/9xz6llDN0Q5hoVHJSNQWfD?=
 =?us-ascii?Q?GtfOtqBqj7O0uQS3n5POEwLAc4s74WCy+Sx9Jk5VGSQOtl++khlSaEV1xVMM?=
 =?us-ascii?Q?GYnbFc2/wRCOscIIF92rnhm3+IEDfTtZ79r7I0AL05MkOvhyCLMZnuxfX++o?=
 =?us-ascii?Q?OGeN2r7kE3DzMs0XG9ZhG8M7?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b9289ee-b679-484f-3628-08d95736dcf4
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2021 10:59:00.0935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6qKVaM7TBE6xz+SyevNdP8WVPEAZ5PE8BwI8xesYEVtnH/q1hFzzHXlUjh47Yt72pxf4Lx7RdEnYethM+yAA0WiJ0c2HDY8SQAbA5VaJ2bU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4547
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10065 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0
 suspectscore=0 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108040056
X-Proofpoint-ORIG-GUID: EXEF5CHbQH8Wm9z6OsO9-EF10JRKmvrY
X-Proofpoint-GUID: EXEF5CHbQH8Wm9z6OsO9-EF10JRKmvrY
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 31, 2021 at 05:09:38PM +0100, Salah Triki wrote:
>  drivers/input/tablet/acecad.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c
> index a38d1fe97334..85fe134a30ee 100644
> --- a/drivers/input/tablet/acecad.c
> +++ b/drivers/input/tablet/acecad.c
> @@ -151,7 +151,7 @@ static int usb_acecad_probe(struct usb_interface *intf, const struct usb_device_
>  		goto fail2;
>  	}
>  
> -	acecad->intf = intf;
> +	acecad->intf = usb_get_intf(intf);
>  	acecad->input = input_dev;
>  
>  	if (dev->manufacturer)

As I mentioned earlier, you need to drop the reference if
input_register_device() fails.

regards,
dan carpenter