Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp59964pxt; Wed, 4 Aug 2021 06:00:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRTHV5NAvOdxtIaDEtjxwIciicPffaS1Ug7CYqn0ZflhKPsFOHnLcFd55wzATwCztPIVIq X-Received: by 2002:a19:f008:: with SMTP id p8mr9401538lfc.302.1628082050865; Wed, 04 Aug 2021 06:00:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628082050; cv=none; d=google.com; s=arc-20160816; b=tjP3lkzARm/iJbn5aw3usgi0qB24AmF54nssk+6p9x4Z2q+SeOCQAzd0I9pMsD8vAM +/BPd+7uTLl5n+w8SFB5TbE0VYOZ+e1Xm9CoZ1e5jR/0kD6lMw+u8ZvWMfqBMVeOKxaW gcCrgav6ro7Q4spSiG6/g9VzxhdoUYRbAF5gvEFQVVmDZaIyVq7dZ2xzhe/gHZKe/BC1 OFu7oKmzzfFpDFnvNfbE5Dr7OQVQSt1pBsKBbTYFUGiceYrcdX5fE9ZbirD5Ksc44RIn 0kfZl5l8IlsWcvUN50PJ1H7FF1zr1IQctMVFlHmKQMLgCt3NyRCw9XcFAWdh7tscjkJL H87g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=E1t0SNn5x7f6Dj4MvLfPbAe/nFhEaNG0D5+fMN+d0a4=; b=czoQS1bBry+Aa1mmtrGz9OBhy1+pOSQeNAMgl5oA6Zz5pJgP5giqUrjKiVZp9W52/l j7AVPX8E8SdllkElig+0n4bIev5Vzpi/fId+p4vk/BpUR7MgKYK7vO1F9ZBE8Bjm744m yq4P8GH9G5YV1E9M0hdQchvSbhRPPSvxESd+I6x3yacpZxB33FjGnYge3PF1sm7XX3S3 372EYb8ys5IhYyvltuftOl8w/ROe+0vey0d66I7j3noCco88uTKBKYpDMbD29YzPGOPI C7iWNkznZPvJ19AlT1fDngl/VkmYAG326ChqQeX0FNq7K84Loz9K4c8zPN6drCFPwltQ rkQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nf2KyfVL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si2023862edv.265.2021.08.04.06.00.18; Wed, 04 Aug 2021 06:00:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nf2KyfVL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237040AbhHDLNj (ORCPT + 99 others); Wed, 4 Aug 2021 07:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236897AbhHDLNb (ORCPT ); Wed, 4 Aug 2021 07:13:31 -0400 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0470C06179A for ; Wed, 4 Aug 2021 04:13:17 -0700 (PDT) Received: by mail-vs1-xe33.google.com with SMTP id k24so785035vsg.9 for ; Wed, 04 Aug 2021 04:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E1t0SNn5x7f6Dj4MvLfPbAe/nFhEaNG0D5+fMN+d0a4=; b=Nf2KyfVLFfCtc3VuPIByG76ejagI+MoZoGEbfaqyQkA4Edo4g7jlqu/TWtLlZBzI2Z s/nx4C8zYdl+AXVtju2jqdk0NwvbRNpbMn7sJOtpBwATeiCEHms9sG0ky0iednIbrJje 8ErulyiXYP6SX4XSHeQER6RRMpM4uVyDS3WvWceptahkfNpmAaeCos8+6XMsuDosj3Yd au34bdb0Q+VMDOHYvMgodwhSP5NRwqRF5rIdxF/LQH5Mqif1pck1+6eRAWRmnVj+viJe OZWCpHHFesk0dsxMLa6m7NXG+cBA/KMcQaOeYi4wnGW8EyM+xI2+ucKP1wcogYE6UXEz wnyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E1t0SNn5x7f6Dj4MvLfPbAe/nFhEaNG0D5+fMN+d0a4=; b=Rjop+axWjB0ADFiubk9QBsg2QWcoC5vQomw4bTVgIvDUrQ2uuoRNkFJClOuE+BkpOZ xUdCtd9/RH6+GPGwx1QzIdTKG4iCXVomC0EtddLWkUNr8GRY3TIVoXQ2ixJn5d7VdsUf ssbcIRRl72tbv1J91ZxcT9CZHGmZ7h7JC3pNfY58E/GR8bkGu98dSZYW7jab2aRu91KV OONV11ElYftS7SLQD1s4SvjuZPVCJqDZFpcRoYD8QAVWVfuH7yiadSgc7hFVkLxJi/Ar a5tq/MlWoBhkxQFQnVxc2O1KbTBF84sNNNrCHTCkd6++ExnY4wlPoXJH926li9BizLdo RMAg== X-Gm-Message-State: AOAM533UkwnFjIpxZJ3rTsC443JyqTIsKK1M+sZk33UDjRNed9gljJq5 1dBtaiQdbUtfWKuv88jmtIshoiX+B9nbvVMLGQtAWQ== X-Received: by 2002:a67:7c14:: with SMTP id x20mr9690293vsc.42.1628075596862; Wed, 04 Aug 2021 04:13:16 -0700 (PDT) MIME-Version: 1.0 References: <20210712060928.4161649-1-hch@lst.de> <20210712060928.4161649-3-hch@lst.de> In-Reply-To: <20210712060928.4161649-3-hch@lst.de> From: Ulf Hansson Date: Wed, 4 Aug 2021 13:12:40 +0200 Message-ID: Subject: Re: [PATCH 2/6] mmc: mmc_spi: replace flush_kernel_dcache_page with flush_dcache_page To: Christoph Hellwig Cc: Linus Torvalds , Andrew Morton , "James E.J. Bottomley" , Russell King , Guo Ren , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Vincent Chen , Helge Deller , Yoshinori Sato , Rich Felker , Geoff Levand , Paul Cercueil , Alex Shi , Linux Kernel Mailing List , Linux ARM , linux-csky@vger.kernel.org, linux-mips , linux-parisc@vger.kernel.org, Linux-sh list , linux-mmc , linux-scsi , linux-mm@kvack.org, Linux Documentation Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Jul 2021 at 08:11, Christoph Hellwig wrote: > > Pages passed to block drivers can be mapped page cache pages, so we > must use flush_dcache_page here instead of the more limited > flush_kernel_dcache_page that is intended for highmem pages only. > > Signed-off-by: Christoph Hellwig Apologies for the delay! Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/mmc/host/mmc_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c > index 65c65bb5737f..3d28a3d3001b 100644 > --- a/drivers/mmc/host/mmc_spi.c > +++ b/drivers/mmc/host/mmc_spi.c > @@ -948,7 +948,7 @@ mmc_spi_data_do(struct mmc_spi_host *host, struct mmc_command *cmd, > > /* discard mappings */ > if (direction == DMA_FROM_DEVICE) > - flush_kernel_dcache_page(sg_page(sg)); > + flush_dcache_page(sg_page(sg)); > kunmap(sg_page(sg)); > if (dma_dev) > dma_unmap_page(dma_dev, dma_addr, PAGE_SIZE, dir); > -- > 2.30.2 >